Page MenuHomePhabricator
Differential D31879

[ARM] Add diag string for movw/movt immediates in assembly
ClosedPublic
Actions

Authored by olista01 on Apr 10 2017, 3:32 AM.

Details

Reviewers
rengolin
SjoerdMeijer
Commits
rG878216dd055f: [ARM] Add diag string for movw/movt immediates in assembly
rL314888: [ARM] Add diag string for movw/movt immediates in assembly
Summary

This adds diagnostics for invalid immediate operands to the MOVW and MOVT instructions (ARM and Thumb).

This depends on D31607 (and it's dependencies), which added the mechanism to table-generate these diagnostic messages.

Diff Detail

Repository
rL LLVM

Event Timeline

olista01 created this revision.Apr 10 2017, 3:32 AM
Herald added a subscriber: aemerson. · View Herald TranscriptApr 10 2017, 3:32 AM
rengolin accepted this revision.Apr 18 2017, 6:56 AM

LGTM. Thanks!

This revision is now accepted and ready to land.Apr 18 2017, 6:56 AM
Closed by commit rL314888: [ARM] Add diag string for movw/movt immediates in assembly (authored by olista01). · Explain WhyOct 4 2017, 2:26 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
lib/
Target/
ARM/
1 line
test/
MC/
ARM/
4 lines
4 lines

Diff 117641

View Options

llvm/trunk/lib/Target/ARM/ARMInstrInfo.td

Loading...
View Options

llvm/trunk/test/MC/ARM/diagnostics.s

Loading...
View Options

llvm/trunk/test/MC/ARM/thumb2-diagnostics.s

Loading...