This is an archive of the discontinued LLVM Phabricator instance.

[ARM, Asm] Use correct source location for register tokens

Authored by olista01 on Mar 31 2017, 8:49 AM.



tryParseRegister advances the lexer, so we need to take copies of the start and end locations of the register operand before calling it.

Previously, the caret in the diagnostic pointer to the comma after the r0 operand in the test, rather than the start of the operand.

Diff Detail


Event Timeline

olista01 created this revision.Mar 31 2017, 8:49 AM
sanwou01 edited reviewers, added: sanwou01; removed: sanne.wouda.Mar 31 2017, 11:07 AM
rengolin accepted this revision.Aug 14 2017, 11:57 AM
This revision is now accepted and ready to land.Aug 14 2017, 11:57 AM
This revision was automatically updated to reflect the committed changes.