Page MenuHomePhabricator
Differential D36746

[Asm] Improve "too few operands" errors
ClosedPublic
Actions

Authored by olista01 on Aug 15 2017, 8:23 AM.

Details

Reviewers
rengolin
echristo
SjoerdMeijer
Commits
rG1e73e95f3c82: [Asm] Improve "too few operands" errors
rL318770: [Asm] Improve "too few operands" errors
Summary
  • We can still emit this error if the actual instruction has two or more operands missing compared to the expected one.
  • We should only emit this error once per instruction.

Diff Detail

Repository
rL LLVM

Event Timeline

olista01 created this revision.Aug 15 2017, 8:23 AM
Herald added a subscriber: javed.absar. · View Herald TranscriptAug 15 2017, 8:23 AM
olista01 added a parent revision: D36744: [Asm] Finish matching once end of formal and actual lists reached (NFC).Aug 15 2017, 8:23 AM
olista01 added a child revision: D36747: [Asm, ARM] Add fallback diag for multiple invalid operands.Aug 15 2017, 8:26 AM
olista01 added a comment.Nov 21 2017, 4:01 AM

Ping

rengolin accepted this revision.Nov 21 2017, 5:23 AM

LGTM, thanks!

This revision is now accepted and ready to land.Nov 21 2017, 5:23 AM
Closed by commit rL318770: [Asm] Improve "too few operands" errors (authored by olista01). · Explain WhyNov 21 2017, 7:17 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
llvm/
trunk/
lib/
Target/
ARM/
AsmParser/
10 lines
test/
MC/
ARM/
6 lines
16 lines
9 lines
6 lines
utils/
TableGen/
2 lines

Diff 123790

View Options

llvm/trunk/lib/Target/ARM/AsmParser/ARMAsmParser.cpp

Loading...
View Options

llvm/trunk/test/MC/ARM/diagnostics.s

Loading...
View Options

llvm/trunk/test/MC/ARM/ldrd-strd-gnu-bad-inst.s

Loading...
View Options

llvm/trunk/test/MC/ARM/thumb-diagnostics.s

Loading...
View Options

llvm/trunk/test/MC/ARM/thumb2-diagnostics.s

Loading...
View Options

llvm/trunk/utils/TableGen/AsmMatcherEmitter.cpp

Loading...