This is an archive of the discontinued LLVM Phabricator instance.

Differential D36689

[ARM, Asm] Change grammar of immediate operand diagnostics
ClosedPublic

Authored by olista01 on Aug 14 2017, 9:07 AM.

Details

Reviewers
rengolin
SjoerdMeijer
echristo
Commits
rG5a7aae3a8037: [ARM, Asm] Change grammar of immediate operand diagnostics
rL314887: [ARM, Asm] Change grammar of immediate operand diagnostics
Summary

Currently, our diagnostics for assembly operands are not consistent.
Some start with (for example) "immediate operand must be ...",
and some with "operand must be an immediate ...". I think the latter
form is preferable for a few reasons:

  • It's unambiguous that it is referring to the expected type of operand, not the type the user provided. For example, the user could provide an register operand, and get a message taking about an operand is if it is already an immediate, just not in the accepted range.
  • It allows us to have a consistent style once we add diagnostics for operands that could take two forms, for example a label or pc-relative memory operand.

Diff Detail

Repository
rL LLVM

Revision Contents

Diff 117640

llvm/trunk/lib/Target/ARM/ARMInstrInfo.td

Show First 20 Lines • Show All 454 Lines • ▼ Show 20 Lines
//===----------------------------------------------------------------------===// //===----------------------------------------------------------------------===//
// Operand Definitions. // Operand Definitions.
// //
// Immediate operands with a shared generic asm render method. // Immediate operands with a shared generic asm render method.
class ImmAsmOperand<int Low, int High> : AsmOperandClass { class ImmAsmOperand<int Low, int High> : AsmOperandClass {
let RenderMethod = "addImmOperands"; let RenderMethod = "addImmOperands";
let PredicateMethod = "isImmediate<" # Low # "," # High # ">"; let PredicateMethod = "isImmediate<" # Low # "," # High # ">";
let DiagnosticString = "immediate operand must be in the range [" # Low # "," # High # "]"; let DiagnosticString = "operand must be an immediate in the range [" # Low # "," # High # "]";
} }
class ImmAsmOperandMinusOne<int Low, int High> : AsmOperandClass { class ImmAsmOperandMinusOne<int Low, int High> : AsmOperandClass {
let PredicateMethod = "isImmediate<" # Low # "," # High # ">"; let PredicateMethod = "isImmediate<" # Low # "," # High # ">";
let DiagnosticType = "ImmRange" # Low # "_" # High; let DiagnosticType = "ImmRange" # Low # "_" # High;
let DiagnosticString = "immediate operand must be in the range [" # Low # "," # High # "]"; let DiagnosticString = "operand must be an immediate in the range [" # Low # "," # High # "]";
} }
// Operands that are part of a memory addressing mode. // Operands that are part of a memory addressing mode.
class MemOperand : Operand<i32> { let OperandType = "OPERAND_MEMORY"; } class MemOperand : Operand<i32> { let OperandType = "OPERAND_MEMORY"; }
// Branch target. // Branch target.
// FIXME: rename brtarget to t2_brtarget // FIXME: rename brtarget to t2_brtarget
def brtarget : Operand<OtherVT> { def brtarget : Operand<OtherVT> {
▲ Show 20 Lines • Show All 354 Lines • ▼ Show 20 Lines
def Imm256_65535ExprAsmOperand: ImmAsmOperand<256,65535> { let Name = "Imm256_65535Expr"; } def Imm256_65535ExprAsmOperand: ImmAsmOperand<256,65535> { let Name = "Imm256_65535Expr"; }
def imm256_65535_expr : Operand<i32> { def imm256_65535_expr : Operand<i32> {
let ParserMatchClass = Imm256_65535ExprAsmOperand; let ParserMatchClass = Imm256_65535ExprAsmOperand;
} }
/// imm24b - True if the 32-bit immediate is encodable in 24 bits. /// imm24b - True if the 32-bit immediate is encodable in 24 bits.
def Imm24bitAsmOperand: ImmAsmOperand<0,0xffffff> { def Imm24bitAsmOperand: ImmAsmOperand<0,0xffffff> {
let Name = "Imm24bit"; let Name = "Imm24bit";
let DiagnosticString = "immediate operand must be in the range [0,0xffffff]"; let DiagnosticString = "operand must be an immediate in the range [0,0xffffff]";
} }
def imm24b : Operand<i32>, ImmLeaf<i32, [{ def imm24b : Operand<i32>, ImmLeaf<i32, [{
return Imm >= 0 && Imm <= 0xffffff; return Imm >= 0 && Imm <= 0xffffff;
}]> { }]> {
let ParserMatchClass = Imm24bitAsmOperand; let ParserMatchClass = Imm24bitAsmOperand;
} }
▲ Show 20 Lines • Show All 5,263 Lines • Show Last 20 Lines

llvm/trunk/test/MC/ARM/basic-arm-instructions-v8.1a.s

Show First 20 Lines • Show All 190 Lines • ▼ Show 20 Lines
//CHECK-V8: setpan #1 //CHECK-V8: setpan #1
//CHECK-V8: ^ //CHECK-V8: ^
setpan setpan
setpan #-1 setpan #-1
setpan #2 setpan #2
//CHECK-ERROR: error: too few operands for instruction //CHECK-ERROR: error: too few operands for instruction
//CHECK-ERROR: setpan //CHECK-ERROR: setpan
//CHECK-ERROR: ^ //CHECK-ERROR: ^
//CHECK-ERROR: error: immediate operand must be in the range [0,1] //CHECK-ERROR: error: operand must be an immediate in the range [0,1]
//CHECK-ERROR: setpan #-1 //CHECK-ERROR: setpan #-1
//CHECK-ERROR: ^ //CHECK-ERROR: ^
//CHECK-ERROR: error: immediate operand must be in the range [0,1] //CHECK-ERROR: error: operand must be an immediate in the range [0,1]
//CHECK-ERROR: setpan #2 //CHECK-ERROR: setpan #2
//CHECK-ERROR: ^ //CHECK-ERROR: ^
it eq it eq
setpaneq #0 setpaneq #0
//CHECK-THUMB-ERROR: error: instruction 'setpan' is not predicable, but condition code specified //CHECK-THUMB-ERROR: error: instruction 'setpan' is not predicable, but condition code specified
//CHECK-THUMB-ERROR: setpaneq #0 //CHECK-THUMB-ERROR: setpaneq #0
//CHECK-THUMB-ERROR: ^ //CHECK-THUMB-ERROR: ^

llvm/trunk/test/MC/ARM/diagnostics.s

Show First 20 Lines • Show All 88 Lines • ▼ Show 20 Lines
@ CHECK-ERRORS: pld r4, [r5, r6, ror #32] @ CHECK-ERRORS: pld r4, [r5, r6, ror #32]
@ CHECK-ERRORS: error: ']' expected @ CHECK-ERRORS: error: ']' expected
@ CHECK-ERRORS: pld r4, [r5, r6, rrx #0] @ CHECK-ERRORS: pld r4, [r5, r6, rrx #0]
@ Out of range 16-bit immediate on BKPT @ Out of range 16-bit immediate on BKPT
bkpt #65536 bkpt #65536
@ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this: @ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this:
@ CHECK-ERRORS: note: immediate operand must be in the range [0,65535] @ CHECK-ERRORS: note: operand must be an immediate in the range [0,65535]
@ CHECK-ERRORS: note: too many operands for instruction @ CHECK-ERRORS: note: too many operands for instruction
@ CHECK-ERRORS: bkpt #65536 @ CHECK-ERRORS: bkpt #65536
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ Out of range immediates for v8 HLT instruction. @ Out of range immediates for v8 HLT instruction.
hlt #65536 hlt #65536
hlt #-1 hlt #-1
@CHECK-ERRORS-V7: error: invalid instruction @CHECK-ERRORS-V7: error: invalid instruction
@CHECK-ERRORS-V8: error: immediate operand must be in the range [0,65535] @CHECK-ERRORS-V8: error: operand must be an immediate in the range [0,65535]
@CHECK-ERRORS: hlt #65536 @CHECK-ERRORS: hlt #65536
@CHECK-ERRORS: ^ @CHECK-ERRORS: ^
@CHECK-ERRORS-V7: error: invalid instruction @CHECK-ERRORS-V7: error: invalid instruction
@CHECK-ERRORS-V8: error: immediate operand must be in the range [0,65535] @CHECK-ERRORS-V8: error: operand must be an immediate in the range [0,65535]
@CHECK-ERRORS: hlt #-1 @CHECK-ERRORS: hlt #-1
@CHECK-ERRORS: ^ @CHECK-ERRORS: ^
@ Illegal condition code for v8 HLT instruction. @ Illegal condition code for v8 HLT instruction.
hlteq #2 hlteq #2
hltlt #23 hltlt #23
@CHECK-ERRORS: error: instruction 'hlt' is not predicable, but condition code specified @CHECK-ERRORS: error: instruction 'hlt' is not predicable, but condition code specified
@CHECK-ERRORS: hlteq #2 @CHECK-ERRORS: hlteq #2
@CHECK-ERRORS: ^ @CHECK-ERRORS: ^
@CHECK-ERRORS: error: instruction 'hlt' is not predicable, but condition code specified @CHECK-ERRORS: error: instruction 'hlt' is not predicable, but condition code specified
@CHECK-ERRORS: hltlt #23 @CHECK-ERRORS: hltlt #23
@CHECK-ERRORS: ^ @CHECK-ERRORS: ^
@ Out of range 4 and 3 bit immediates on CDP[2] @ Out of range 4 and 3 bit immediates on CDP[2]
@ Out of range immediates for CDP/CDP2 @ Out of range immediates for CDP/CDP2
cdp p7, #2, c1, c1, c1, #8 cdp p7, #2, c1, c1, c1, #8
cdp p7, #1, c1, c1, c1, #8 cdp p7, #1, c1, c1, c1, #8
cdp2 p7, #2, c1, c1, c1, #8 cdp2 p7, #2, c1, c1, c1, #8
cdp2 p7, #1, c1, c1, c1, #8 cdp2 p7, #1, c1, c1, c1, #8
@ CHECK-ERRORS-V7: error: immediate operand must be in the range [0,7] @ CHECK-ERRORS-V7: error: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V7: error: immediate operand must be in the range [0,7] @ CHECK-ERRORS-V7: error: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V7: error: immediate operand must be in the range [0,7] @ CHECK-ERRORS-V7: error: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V7: error: immediate operand must be in the range [0,7] @ CHECK-ERRORS-V7: error: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V8: error: invalid instruction @ CHECK-ERRORS-V8: error: invalid instruction
@ CHECK-ERRORS-V8: error: invalid instruction @ CHECK-ERRORS-V8: error: invalid instruction
@ CHECK-ERRORS-V8: error: invalid instruction @ CHECK-ERRORS-V8: error: invalid instruction
@ CHECK-ERRORS-V8: error: invalid instruction @ CHECK-ERRORS-V8: error: invalid instruction
@ Out of range immediates for DBG @ Out of range immediates for DBG
dbg #-1 dbg #-1
dbg #16 dbg #16
@ CHECK-ERRORS-V7: error: immediate operand must be in the range [0,15] @ CHECK-ERRORS-V7: error: operand must be an immediate in the range [0,15]
@ CHECK-ERRORS-V7: error: immediate operand must be in the range [0,15] @ CHECK-ERRORS-V7: error: operand must be an immediate in the range [0,15]
@ CHECK-ERRORS-V8: error: immediate operand must be in the range [0,15] @ CHECK-ERRORS-V8: error: operand must be an immediate in the range [0,15]
@ CHECK-ERRORS-V8: error: immediate operand must be in the range [0,15] @ CHECK-ERRORS-V8: error: operand must be an immediate in the range [0,15]
@ Double-check that we're synced up with the right diagnostics. @ Double-check that we're synced up with the right diagnostics.
@ CHECK-ERRORS: dbg #16 @ CHECK-ERRORS: dbg #16
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ Out of range immediate for MCR/MCR2/MCRR/MCRR2 @ Out of range immediate for MCR/MCR2/MCRR/MCRR2
mcr p7, #8, r5, c1, c1, #4 mcr p7, #8, r5, c1, c1, #4
mcr p7, #2, r5, c1, c1, #8 mcr p7, #2, r5, c1, c1, #8
mcr2 p7, #8, r5, c1, c1, #4 mcr2 p7, #8, r5, c1, c1, #4
mcr2 p7, #1, r5, c1, c1, #8 mcr2 p7, #1, r5, c1, c1, #8
mcrr p7, #16, r5, r4, c1 mcrr p7, #16, r5, r4, c1
mcrr2 p7, #16, r5, r4, c1 mcrr2 p7, #16, r5, r4, c1
@ CHECK-ERRORS: immediate operand must be in the range [0,7] @ CHECK-ERRORS: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS: immediate operand must be in the range [0,7] @ CHECK-ERRORS: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V7: immediate operand must be in the range [0,7] @ CHECK-ERRORS-V7: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V7: immediate operand must be in the range [0,7] @ CHECK-ERRORS-V7: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V8: invalid instruction @ CHECK-ERRORS-V8: invalid instruction
@ CHECK-ERRORS-V8: too many operands for instruction @ CHECK-ERRORS-V8: too many operands for instruction
@ CHECK-ERRORS: immediate operand must be in the range [0,15] @ CHECK-ERRORS: operand must be an immediate in the range [0,15]
@ CHECK-ERRORS-V7: immediate operand must be in the range [0,15] @ CHECK-ERRORS-V7: operand must be an immediate in the range [0,15]
@ CHECK-ERRORS-V8: invalid instruction @ CHECK-ERRORS-V8: invalid instruction
@ p10 and p11 are reserved for NEON @ p10 and p11 are reserved for NEON
mcr p10, #2, r5, c1, c1, #4 mcr p10, #2, r5, c1, c1, #4
mcrr p11, #8, r5, r4, c1 mcrr p11, #8, r5, r4, c1
@ CHECK-ERRORS: error: invalid operand for instruction @ CHECK-ERRORS: error: invalid operand for instruction
@ CHECK-ERRORS: error: invalid operand for instruction @ CHECK-ERRORS: error: invalid operand for instruction
Show All 17 Lines@ CHECK-ERRORS: ^
@ Out of range immediates for MRC/MRC2/MRRC/MRRC2 @ Out of range immediates for MRC/MRC2/MRRC/MRRC2
mrc p14, #8, r1, c1, c2, #4 mrc p14, #8, r1, c1, c2, #4
mrc p14, #1, r1, c1, c2, #8 mrc p14, #1, r1, c1, c2, #8
mrc2 p14, #8, r1, c1, c2, #4 mrc2 p14, #8, r1, c1, c2, #4
mrc2 p14, #0, r1, c1, c2, #9 mrc2 p14, #0, r1, c1, c2, #9
mrrc p7, #16, r5, r4, c1 mrrc p7, #16, r5, r4, c1
mrrc2 p7, #17, r5, r4, c1 mrrc2 p7, #17, r5, r4, c1
@ CHECK-ERRORS: immediate operand must be in the range [0,7] @ CHECK-ERRORS: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS: immediate operand must be in the range [0,7] @ CHECK-ERRORS: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V7: immediate operand must be in the range [0,7] @ CHECK-ERRORS-V7: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V8: invalid instruction @ CHECK-ERRORS-V8: invalid instruction
@ CHECK-ERRORS-V7: immediate operand must be in the range [0,7] @ CHECK-ERRORS-V7: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V8: too many operands for instruction @ CHECK-ERRORS-V8: too many operands for instruction
@ CHECK-ERRORS: immediate operand must be in the range [0,15] @ CHECK-ERRORS: operand must be an immediate in the range [0,15]
@ CHECK-ERRORS-V7: immediate operand must be in the range [0,15] @ CHECK-ERRORS-V7: operand must be an immediate in the range [0,15]
@ CHECK-ERRORS-V8: invalid instruction @ CHECK-ERRORS-V8: invalid instruction
@ Shifter operand validation for PKH instructions. @ Shifter operand validation for PKH instructions.
pkhbt r2, r2, r3, lsl #-1 pkhbt r2, r2, r3, lsl #-1
pkhbt r2, r2, r3, lsl #32 pkhbt r2, r2, r3, lsl #32
pkhtb r2, r2, r3, asr #0 pkhtb r2, r2, r3, asr #0
pkhtb r2, r2, r3, asr #33 pkhtb r2, r2, r3, asr #33
pkhbt r2, r2, r3, asr #3 pkhbt r2, r2, r3, asr #3
▲ Show 20 Lines • Show All 41 Lines • ▼ Show 20 Lines@ CHECK-ERRORS: ^
ssat r8, #1, r10, lsl #-1 ssat r8, #1, r10, lsl #-1
ssat r8, #1, r10, lsl #32 ssat r8, #1, r10, lsl #32
ssat r8, #1, r10, asr #0 ssat r8, #1, r10, asr #0
ssat r8, #1, r10, asr #33 ssat r8, #1, r10, asr #33
ssat r8, #1, r10, lsr #5 ssat r8, #1, r10, lsr #5
ssat r8, #1, r10, lsl fred ssat r8, #1, r10, lsl fred
ssat r8, #1, r10, lsl #fred ssat r8, #1, r10, lsl #fred
@ CHECK-ERRORS: error: immediate operand must be in the range [1,32] @ CHECK-ERRORS: error: operand must be an immediate in the range [1,32]
@ CHECK-ERRORS: ssat r8, #0, r10, lsl #8 @ CHECK-ERRORS: ssat r8, #0, r10, lsl #8
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: error: immediate operand must be in the range [1,32] @ CHECK-ERRORS: error: operand must be an immediate in the range [1,32]
@ CHECK-ERRORS: ssat r8, #33, r10, lsl #8 @ CHECK-ERRORS: ssat r8, #33, r10, lsl #8
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: error: 'lsr' shift amount must be in range [0,31] @ CHECK-ERRORS: error: 'lsr' shift amount must be in range [0,31]
@ CHECK-ERRORS: ssat r8, #1, r10, lsl #-1 @ CHECK-ERRORS: ssat r8, #1, r10, lsl #-1
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: error: 'lsr' shift amount must be in range [0,31] @ CHECK-ERRORS: error: 'lsr' shift amount must be in range [0,31]
@ CHECK-ERRORS: ssat r8, #1, r10, lsl #32 @ CHECK-ERRORS: ssat r8, #1, r10, lsl #32
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
Show All 12 Lines
@ CHECK-ERRORS: error: shift amount must be an immediate @ CHECK-ERRORS: error: shift amount must be an immediate
@ CHECK-ERRORS: ssat r8, #1, r10, lsl #fred @ CHECK-ERRORS: ssat r8, #1, r10, lsl #fred
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ Out of range immediates for SSAT16 @ Out of range immediates for SSAT16
ssat16 r2, #0, r7 ssat16 r2, #0, r7
ssat16 r3, #17, r5 ssat16 r3, #17, r5
@ CHECK-ERRORS: error: immediate operand must be in the range [1,16] @ CHECK-ERRORS: error: operand must be an immediate in the range [1,16]
@ CHECK-ERRORS: ssat16 r2, #0, r7 @ CHECK-ERRORS: ssat16 r2, #0, r7
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: error: immediate operand must be in the range [1,16] @ CHECK-ERRORS: error: operand must be an immediate in the range [1,16]
@ CHECK-ERRORS: ssat16 r3, #17, r5 @ CHECK-ERRORS: ssat16 r3, #17, r5
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ Out of order STM registers @ Out of order STM registers
stmda sp!, {r5, r2} stmda sp!, {r5, r2}
@ CHECK-ERRORS: warning: register list not in ascending order @ CHECK-ERRORS: warning: register list not in ascending order
@ CHECK-ERRORS: stmda sp!, {r5, r2} @ CHECK-ERRORS: stmda sp!, {r5, r2}
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ Out of range immediate on SVC @ Out of range immediate on SVC
svc #0x1000000 svc #0x1000000
@ CHECK-ERRORS: error: immediate operand must be in the range [0,0xffffff] @ CHECK-ERRORS: error: operand must be an immediate in the range [0,0xffffff]
@ CHECK-ERRORS: svc #0x1000000 @ CHECK-ERRORS: svc #0x1000000
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ Out of order Rt/Rt2 operands for ldrexd/strexd @ Out of order Rt/Rt2 operands for ldrexd/strexd
ldrexd r4, r3, [r8] ldrexd r4, r3, [r8]
strexd r6, r5, r3, [r8] strexd r6, r5, r3, [r8]
▲ Show 20 Lines • Show All 407 Lines • Show Last 20 Lines

llvm/trunk/test/MC/ARM/invalid-hint-arm.s

@ RUN: not llvm-mc -triple=armv7-apple-darwin -mcpu=cortex-a8 < %s 2>&1 | FileCheck %s @ RUN: not llvm-mc -triple=armv7-apple-darwin -mcpu=cortex-a8 < %s 2>&1 | FileCheck %s
hint #240 hint #240
hint #1000 hint #1000
@ CHECK: error: immediate operand must be in the range [0,239] @ CHECK: error: operand must be an immediate in the range [0,239]
@ CHECK: error: immediate operand must be in the range [0,239] @ CHECK: error: operand must be an immediate in the range [0,239]

llvm/trunk/test/MC/ARM/invalid-hint-thumb.s

@ RUN: not llvm-mc -triple=thumbv7-apple-darwin -mcpu=cortex-a8 < %s 2>&1 | FileCheck %s @ RUN: not llvm-mc -triple=thumbv7-apple-darwin -mcpu=cortex-a8 < %s 2>&1 | FileCheck %s
hint #240 hint #240
hint #1000 hint #1000
@ FIXME: set the subclasses of the operand classes so that we only get one error for each. @ FIXME: set the subclasses of the operand classes so that we only get one error for each.
@ CHECK: error: invalid instruction, any one of the following would fix this: @ CHECK: error: invalid instruction, any one of the following would fix this:
@ CHECK: note: immediate operand must be in the range [0,239] @ CHECK: note: operand must be an immediate in the range [0,239]
@ CHECK: note: immediate operand must be in the range [0,15] @ CHECK: note: operand must be an immediate in the range [0,15]
@ CHECK: error: invalid instruction, any one of the following would fix this: @ CHECK: error: invalid instruction, any one of the following would fix this:
@ CHECK: note: immediate operand must be in the range [0,239] @ CHECK: note: operand must be an immediate in the range [0,239]
@ CHECK: note: immediate operand must be in the range [0,15] @ CHECK: note: operand must be an immediate in the range [0,15]

llvm/trunk/test/MC/ARM/lsl-zero-errors.s

Show First 20 Lines • Show All 55 Lines • ▼ Show 20 Lines
// CHECK-NONARM: error: invalid instruction, any one of the following would fix this: // CHECK-NONARM: error: invalid instruction, any one of the following would fix this:
// CHECK-NONARM-NEXT: mov pc, r0, lsl #0 // CHECK-NONARM-NEXT: mov pc, r0, lsl #0
// CHECK-NONARM: invalid operand for instruction // CHECK-NONARM: invalid operand for instruction
// CHECK-NONARM: invalid operand for instruction // CHECK-NONARM: invalid operand for instruction
// CHECK-NONARM: error: invalid instruction, any one of the following would fix this: // CHECK-NONARM: error: invalid instruction, any one of the following would fix this:
// CHECK-NONARM-NEXT: mov r0, pc, lsl #0 // CHECK-NONARM-NEXT: mov r0, pc, lsl #0
// CHECK-NONARM: invalid operand for instruction // CHECK-NONARM: invalid operand for instruction
// CHECK-NONARM: invalid operand for instruction // CHECK-NONARM: invalid operand for instruction
// CHECK-NONARM: immediate operand must be in the range [256,65535] // CHECK-NONARM: operand must be an immediate in the range [256,65535]
// CHECK-NONARM: error: invalid instruction, any one of the following would fix this: // CHECK-NONARM: error: invalid instruction, any one of the following would fix this:
// CHECK-NONARM-NEXT: mov pc, pc, lsl #0 // CHECK-NONARM-NEXT: mov pc, pc, lsl #0
// CHECK-NONARM: invalid operand for instruction // CHECK-NONARM: invalid operand for instruction
// CHECK-NONARM: invalid operand for instruction // CHECK-NONARM: invalid operand for instruction
// CHECK-NONARM: error: invalid operand for instruction // CHECK-NONARM: error: invalid operand for instruction
// CHECK-NONARM-NEXT: movs pc, r0, lsl #0 // CHECK-NONARM-NEXT: movs pc, r0, lsl #0
// CHECK-NONARM: error: invalid instruction, any one of the following would fix this: // CHECK-NONARM: error: invalid instruction, any one of the following would fix this:
// CHECK-NONARM-NEXT: movs r0, pc, lsl #0 // CHECK-NONARM-NEXT: movs r0, pc, lsl #0
▲ Show 20 Lines • Show All 64 Lines • Show Last 20 Lines

llvm/trunk/test/MC/ARM/negative-immediates-thumb1-fail.s

# RUN: not llvm-mc -triple thumbv7 -mcpu=cortex-m0 %s 2>&1 | FileCheck %s # RUN: not llvm-mc -triple thumbv7 -mcpu=cortex-m0 %s 2>&1 | FileCheck %s
.thumb .thumb
ADDs r1, r0, #0xFFFFFFF5 ADDs r1, r0, #0xFFFFFFF5
# CHECK: error: invalid instruction, any one of the following would fix this: # CHECK: error: invalid instruction, any one of the following would fix this:
# CHECK-DAG: note: instruction requires: thumb2 # CHECK-DAG: note: instruction requires: thumb2
# CHECK-DAG: note: invalid operand for instruction # CHECK-DAG: note: invalid operand for instruction
# CHECK-DAG: note: immediate operand must be in the range [0,7] # CHECK-DAG: note: operand must be an immediate in the range [0,7]
ADDs r0, #0xFFFFFEFF ADDs r0, #0xFFFFFEFF
# CHECK: error: invalid instruction, any one of the following would fix this: # CHECK: error: invalid instruction, any one of the following would fix this:
# CHECK-DAG: note: invalid operand for instruction # CHECK-DAG: note: invalid operand for instruction
# CHECK-DAG: note: immediate operand must be in the range [0,255] # CHECK-DAG: note: operand must be an immediate in the range [0,255]
SUBs r1, r0, #0xFFFFFFF5 SUBs r1, r0, #0xFFFFFFF5
# CHECK: error: invalid instruction, any one of the following would fix this: # CHECK: error: invalid instruction, any one of the following would fix this:
# CHECK-DAG: note: invalid operand for instruction # CHECK-DAG: note: invalid operand for instruction
# CHECK-DAG: note: immediate operand must be in the range [0,7] # CHECK-DAG: note: operand must be an immediate in the range [0,7]
SUBs r0, #0xFFFFFEFF SUBs r0, #0xFFFFFEFF
# CHECK: error: invalid instruction, any one of the following would fix this: # CHECK: error: invalid instruction, any one of the following would fix this:
# CHECK-DAG: note: invalid operand for instruction # CHECK-DAG: note: invalid operand for instruction
# CHECK-DAG: note: immediate operand must be in the range [0,255] # CHECK-DAG: note: operand must be an immediate in the range [0,255]
ORRs r0, r1, #0xFFFFFF00 ORRs r0, r1, #0xFFFFFF00
# CHECK: error: invalid instruction, any one of the following would fix this: # CHECK: error: invalid instruction, any one of the following would fix this:
# CHECK-DAG: note: instruction requires: thumb2 # CHECK-DAG: note: instruction requires: thumb2
# CHECK-DAG: note: too many operands for instruction # CHECK-DAG: note: too many operands for instruction
ORNs r0, r1, #0xFFFFFF00 ORNs r0, r1, #0xFFFFFF00
# CHECK: error: instruction requires: thumb2 # CHECK: error: instruction requires: thumb2

llvm/trunk/test/MC/ARM/t2-modified-immediate-fixup-error2.s

@ PR28647 @ PR28647
@ RUN: not llvm-mc -triple=thumbv7a-linux-gnueabi -filetype=obj < %s 2>&1 | FileCheck %s @ RUN: not llvm-mc -triple=thumbv7a-linux-gnueabi -filetype=obj < %s 2>&1 | FileCheck %s
.text .text
.syntax unified .syntax unified
.balign 2 .balign 2
@ mov with :upper16: or :lower16: should not match mov with modified immediate @ mov with :upper16: or :lower16: should not match mov with modified immediate
mov r0, :upper16: sym0 mov r0, :upper16: sym0
@ CHECK: error: invalid instruction, any one of the following would fix this: @ CHECK: error: invalid instruction, any one of the following would fix this:
@ CHECK: note: instruction requires: arm-mode @ CHECK: note: instruction requires: arm-mode
@ CHECK: note: invalid operand for instruction @ CHECK: note: invalid operand for instruction
@ CHECK: note: immediate operand must be in the range [256,65535] @ CHECK: note: operand must be an immediate in the range [256,65535]
mov r0, :lower16: sym0 mov r0, :lower16: sym0
@ CHECK: error: invalid instruction, any one of the following would fix this: @ CHECK: error: invalid instruction, any one of the following would fix this:
@ CHECK: note: instruction requires: arm-mode @ CHECK: note: instruction requires: arm-mode
@ CHECK: note: invalid operand for instruction @ CHECK: note: invalid operand for instruction
@ CHECK: note: immediate operand must be in the range [256,65535] @ CHECK: note: operand must be an immediate in the range [256,65535]
.equ sym0, 0x01abcdef .equ sym0, 0x01abcdef

llvm/trunk/test/MC/ARM/thumb-diagnostics.s

Show All 11 Lines
@ ADD instruction w/o 'S' suffix. @ ADD instruction w/o 'S' suffix.
add r1, r2, r3 add r1, r2, r3
@ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this: @ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this:
@ CHECK-ERRORS: add r1, r2, r3 @ CHECK-ERRORS: add r1, r2, r3
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: note: instruction requires: arm-mode @ CHECK-ERRORS: note: instruction requires: arm-mode
@ CHECK-ERRORS: note: instruction requires: thumb2 @ CHECK-ERRORS: note: instruction requires: thumb2
@ CHECK-ERRORS: note: invalid operand for instruction @ CHECK-ERRORS: note: invalid operand for instruction
@ CHECK-ERRORS: note: immediate operand must be in the range [0,7] @ CHECK-ERRORS: note: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS: note: no flag-preserving variant of this instruction available @ CHECK-ERRORS: note: no flag-preserving variant of this instruction available
@ Instructions which require v6+ for both registers to be low regs. @ Instructions which require v6+ for both registers to be low regs.
add r2, r3 add r2, r3
mov r2, r3 mov r2, r3
@ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this: @ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this:
@ CHECK-ERRORS: add r2, r3 @ CHECK-ERRORS: add r2, r3
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: note: instruction variant requires Thumb2 @ CHECK-ERRORS: note: instruction variant requires Thumb2
@ CHECK-ERRORS: note: invalid operand for instruction @ CHECK-ERRORS: note: invalid operand for instruction
@ CHECK-ERRORS-V5: error: instruction variant requires ARMv6 or later @ CHECK-ERRORS-V5: error: instruction variant requires ARMv6 or later
@ CHECK-ERRORS-V5: mov r2, r3 @ CHECK-ERRORS-V5: mov r2, r3
@ CHECK-ERRORS-V5: ^ @ CHECK-ERRORS-V5: ^
@ Out of range immediates for ASR instruction. @ Out of range immediates for ASR instruction.
asrs r2, r3, #33 asrs r2, r3, #33
@ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this: @ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this:
@ CHECK-ERRORS: asrs r2, r3, #33 @ CHECK-ERRORS: asrs r2, r3, #33
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: note: immediate operand must be in the range [1,32] @ CHECK-ERRORS: note: operand must be an immediate in the range [1,32]
@ CHECK-ERRORS: note: too many operands for instruction @ CHECK-ERRORS: note: too many operands for instruction
@ Out of range immediates for BKPT instruction. @ Out of range immediates for BKPT instruction.
bkpt #256 bkpt #256
bkpt #-1 bkpt #-1
@ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this: @ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this:
@ CHECK-ERRORS: bkpt #256 @ CHECK-ERRORS: bkpt #256
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: note: instruction requires: arm-mode @ CHECK-ERRORS: note: instruction requires: arm-mode
@ CHECK-ERRORS: note: immediate operand must be in the range [0,255] @ CHECK-ERRORS: note: operand must be an immediate in the range [0,255]
@ CHECK-ERRORS: note: too many operands for instruction @ CHECK-ERRORS: note: too many operands for instruction
@ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this: @ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this:
@ CHECK-ERRORS: bkpt #-1 @ CHECK-ERRORS: bkpt #-1
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: note: immediate operand must be in the range [0,255] @ CHECK-ERRORS: note: operand must be an immediate in the range [0,255]
@ CHECK-ERRORS: note: too many operands for instruction @ CHECK-ERRORS: note: too many operands for instruction
@ Out of range immediates for v8 HLT instruction. @ Out of range immediates for v8 HLT instruction.
hlt #64 hlt #64
hlt #-1 hlt #-1
@CHECK-ERRORS: error: invalid instruction @CHECK-ERRORS: error: invalid instruction
@CHECK-ERRORS: hlt #64 @CHECK-ERRORS: hlt #64
@CHECK-ERRORS: ^ @CHECK-ERRORS: ^
@CHECK-ERRORS-V8: error: invalid instruction, any one of the following would fix this: @CHECK-ERRORS-V8: error: invalid instruction, any one of the following would fix this:
@CHECK-ERRORS-V8: hlt #64 @CHECK-ERRORS-V8: hlt #64
@CHECK-ERRORS-V8: ^ @CHECK-ERRORS-V8: ^
@CHECK-ERRORS-V8: note: instruction requires: arm-mode @CHECK-ERRORS-V8: note: instruction requires: arm-mode
@CHECK-ERRORS-V8: immediate operand must be in the range [0,63] @CHECK-ERRORS-V8: operand must be an immediate in the range [0,63]
@CHECK-ERRORS: error: invalid instruction @CHECK-ERRORS: error: invalid instruction
@CHECK-ERRORS: hlt #-1 @CHECK-ERRORS: hlt #-1
@CHECK-ERRORS: ^ @CHECK-ERRORS: ^
@CHECK-ERRORS-V8: error: immediate operand must be in the range [0,63] @CHECK-ERRORS-V8: error: operand must be an immediate in the range [0,63]
@CHECK-ERRORS-V8: hlt #-1 @CHECK-ERRORS-V8: hlt #-1
@CHECK-ERRORS-V8: ^ @CHECK-ERRORS-V8: ^
@ Invalid writeback and register lists for LDM @ Invalid writeback and register lists for LDM
ldm r2!, {r5, r8} ldm r2!, {r5, r8}
ldm r2, {r5, r7} ldm r2, {r5, r7}
ldm r2!, {r2, r3, r4} ldm r2!, {r2, r3, r4}
ldm r2!, {r2, r3, r4, r10} ldm r2!, {r2, r3, r4, r10}
▲ Show 20 Lines • Show All 90 Lines • ▼ Show 20 Lines
@ CHECK-ERRORS-V7M: ^ @ CHECK-ERRORS-V7M: ^
@ Out of range immediates for LSL instruction. @ Out of range immediates for LSL instruction.
lsls r4, r5, #-1 lsls r4, r5, #-1
lsls r4, r5, #32 lsls r4, r5, #32
@ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this: @ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this:
@ CHECK-ERRORS: lsls r4, r5, #-1 @ CHECK-ERRORS: lsls r4, r5, #-1
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: note: immediate operand must be in the range [0,31] @ CHECK-ERRORS: note: operand must be an immediate in the range [0,31]
@ CHECK-ERRORS: note: too many operands for instruction @ CHECK-ERRORS: note: too many operands for instruction
@ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this: @ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this:
@ CHECK-ERRORS: lsls r4, r5, #32 @ CHECK-ERRORS: lsls r4, r5, #32
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: note: immediate operand must be in the range [0,31] @ CHECK-ERRORS: note: operand must be an immediate in the range [0,31]
@ CHECK-ERRORS: note: too many operands for instruction @ CHECK-ERRORS: note: too many operands for instruction
@ Mismatched source/destination operands for MUL instruction. @ Mismatched source/destination operands for MUL instruction.
muls r1, r2, r3 muls r1, r2, r3
@ CHECK-ERRORS: error: destination register must match source register @ CHECK-ERRORS: error: destination register must match source register
@ CHECK-ERRORS: muls r1, r2, r3 @ CHECK-ERRORS: muls r1, r2, r3
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
Show All 19 Lines
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: note: instruction requires: thumb2 @ CHECK-ERRORS: note: instruction requires: thumb2
@ CHECK-ERRORS: note: instruction requires: arm-mode @ CHECK-ERRORS: note: instruction requires: arm-mode
@ CHECK-ERRORS: note: invalid operand for instruction @ CHECK-ERRORS: note: invalid operand for instruction
@ Out of range immediate for SVC instruction. @ Out of range immediate for SVC instruction.
svc #-1 svc #-1
svc #256 svc #256
@ CHECK-ERRORS: error: immediate operand must be in the range [0,255] @ CHECK-ERRORS: error: operand must be an immediate in the range [0,255]
@ CHECK-ERRORS: svc #-1 @ CHECK-ERRORS: svc #-1
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this: @ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this:
@ CHECK-ERRORS: svc #256 @ CHECK-ERRORS: svc #256
@ CHECK-ERRORS: ^ @ CHECK-ERRORS: ^
@ CHECK-ERRORS: note: instruction requires: arm-mode @ CHECK-ERRORS: note: instruction requires: arm-mode
@ CHECK-ERRORS: note: immediate operand must be in the range [0,255] @ CHECK-ERRORS: note: operand must be an immediate in the range [0,255]
@ Out of range immediate for ADD SP instructions @ Out of range immediate for ADD SP instructions
add sp, #-1 add sp, #-1
add sp, #3 add sp, #3
add sp, sp, #512 add sp, sp, #512
add r2, sp, #1024 add r2, sp, #1024
@ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this: @ CHECK-ERRORS: error: invalid instruction, any one of the following would fix this:
▲ Show 20 Lines • Show All 107 Lines • Show Last 20 Lines

llvm/trunk/test/MC/ARM/thumb2-diagnostics.s

Show All 33 Lines@ CHECK-ERRORS: ^
@ Out of range immediates for MRC/MRC2/MRRC/MRRC2 @ Out of range immediates for MRC/MRC2/MRRC/MRRC2
mrc p14, #8, r1, c1, c2, #4 mrc p14, #8, r1, c1, c2, #4
mrc p14, #1, r1, c1, c2, #8 mrc p14, #1, r1, c1, c2, #8
mrc2 p14, #8, r1, c1, c2, #4 mrc2 p14, #8, r1, c1, c2, #4
mrc2 p14, #0, r1, c1, c2, #9 mrc2 p14, #0, r1, c1, c2, #9
mrrc p7, #16, r5, r4, c1 mrrc p7, #16, r5, r4, c1
mrrc2 p7, #17, r5, r4, c1 mrrc2 p7, #17, r5, r4, c1
@ CHECK-ERRORS: immediate operand must be in the range [0,7] @ CHECK-ERRORS: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS: immediate operand must be in the range [0,7] @ CHECK-ERRORS: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V7: immediate operand must be in the range [0,7] @ CHECK-ERRORS-V7: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V7: immediate operand must be in the range [0,7] @ CHECK-ERRORS-V7: operand must be an immediate in the range [0,7]
@ CHECK-ERRORS-V8: invalid instruction @ CHECK-ERRORS-V8: invalid instruction
@ CHECK-ERRORS-V8: too many operands for instruction @ CHECK-ERRORS-V8: too many operands for instruction
@ CHECK-ERRORS: immediate operand must be in the range [0,15] @ CHECK-ERRORS: operand must be an immediate in the range [0,15]
@ CHECK-ERRORS-V7: immediate operand must be in the range [0,15] @ CHECK-ERRORS-V7: operand must be an immediate in the range [0,15]
@ CHECK-ERRORS-V8: invalid instruction @ CHECK-ERRORS-V8: invalid instruction
isb #-1 isb #-1
isb #16 isb #16
@ CHECK-ERRORS: error: immediate value out of range @ CHECK-ERRORS: error: immediate value out of range
@ CHECK-ERRORS: error: immediate value out of range @ CHECK-ERRORS: error: immediate value out of range
itt eq itt eq
▲ Show 20 Lines • Show All 85 Lines • Show Last 20 Lines

llvm/trunk/test/MC/ARM/udf-arm-diagnostics.s

@ RUN: not llvm-mc -triple arm-eabi %s 2>&1 | FileCheck %s @ RUN: not llvm-mc -triple arm-eabi %s 2>&1 | FileCheck %s
.syntax unified .syntax unified
.text .text
.arm .arm
undefined: undefined:
udfpl udfpl
@ CHECK: error: instruction 'udf' is not predicable, but condition code specified @ CHECK: error: instruction 'udf' is not predicable, but condition code specified
@ CHECK: udfpl @ CHECK: udfpl
@ CHECK: ^ @ CHECK: ^
udf #65536 udf #65536
@ CHECK: error: immediate operand must be in the range [0,65535] @ CHECK: error: operand must be an immediate in the range [0,65535]
@ CHECK: udf #65536 @ CHECK: udf #65536
@ CHECK: ^ @ CHECK: ^

llvm/trunk/test/MC/ARM/udf-thumb-2-diagnostics.s

Show All 9 Lines
@ CHECK: error: instruction 'udf' is not predicable, but condition code specified @ CHECK: error: instruction 'udf' is not predicable, but condition code specified
@ CHECK: udfpl @ CHECK: udfpl
@ CHECK: ^ @ CHECK: ^
udf #256 udf #256
@ CHECK: error: invalid instruction, any one of the following would fix this: @ CHECK: error: invalid instruction, any one of the following would fix this:
@ CHECK: note: instruction requires: arm-mode @ CHECK: note: instruction requires: arm-mode
@ CHECK: note: immediate operand must be in the range [0,255] @ CHECK: note: operand must be an immediate in the range [0,255]
@ CHECK: udf #256 @ CHECK: udf #256
@ CHECK: ^ @ CHECK: ^
udf.w #65536 udf.w #65536
@ CHECK: error: immediate operand must be in the range [0,65535] @ CHECK: error: operand must be an immediate in the range [0,65535]
@ CHECK: udf.w #65536 @ CHECK: udf.w #65536
@ CHECK: ^ @ CHECK: ^

llvm/trunk/test/MC/ARM/udf-thumb-diagnostics.s

@ RUN: not llvm-mc -triple thumbv6m-eabi %s 2>&1 | FileCheck %s @ RUN: not llvm-mc -triple thumbv6m-eabi %s 2>&1 | FileCheck %s
.syntax unified .syntax unified
.text .text
.thumb .thumb
undefined: undefined:
udfpl udfpl
@ CHECK: error: conditional execution not supported in Thumb1 @ CHECK: error: conditional execution not supported in Thumb1
@ CHECK: udfpl @ CHECK: udfpl
@ CHECK: ^ @ CHECK: ^
udf #256 udf #256
@ CHECK: error: immediate operand must be in the range [0,255] @ CHECK: error: operand must be an immediate in the range [0,255]
@ CHECK: udf #256 @ CHECK: udf #256
@ CHECK: ^ @ CHECK: ^