[clang-tidy] Ignore delegate constructors in cppcoreguidelines-pro-type-member-init

[PiotrZSL]

Summary

Ignore dependend delegate constructors.

Fixes: #37250

clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp

 ProTypeMemberInitCheck::ProTypeMemberInitCheck(StringRef Name,
                                                ClangTidyContext *Context)
     : ClangTidyCheck(Name, Context),
       IgnoreArrays(Options.get("IgnoreArrays", false)),
       UseAssignment(Options.getLocalOrGlobal("UseAssignment", false)) {}
 
 void ProTypeMemberInitCheck::registerMatchers(MatchFinder *Finder) {
   auto IsUserProvidedNonDelegatingConstructor =
-      allOf(isUserProvided(),
-            unless(anyOf(isInstantiated(), isDelegatingConstructor())));
+      allOf(isUserProvided(), unless(isInstantiated()),
+            unless(isDelegatingConstructor()),
+            ofClass(cxxRecordDecl().bind("parent")),
+            unless(hasAnyConstructorInitializer(cxxCtorInitializer(
+                isWritten(), unless(isMemberInitializer()),
+                hasTypeLoc(loc(
+                    qualType(hasDeclaration(equalsBoundNode("parent")))))))));
+
   auto IsNonTrivialDefaultConstructor = allOf(
       isDefaultConstructor(), unless(isUserProvided()),
       hasParent(cxxRecordDecl(unless(isTriviallyDefaultConstructible()))));
   Finder->addMatcher(
       cxxConstructorDecl(isDefinition(),
                          anyOf(IsUserProvidedNonDelegatingConstructor,
                                IsNonTrivialDefaultConstructor))
           .bind("ctor"),

clang-tools-extra/docs/ReleaseNotes.rst

- Improved :doc:`cppcoreguidelines-avoid-non-const-global-variables
   <clang-tidy/checks/cppcoreguidelines/avoid-non-const-global-variables>` check
   to ignore ``static`` variables declared within the scope of
   ``class``/``struct``.
 
 - Improved :doc:`cppcoreguidelines-prefer-member-initializer
   <clang-tidy/checks/cppcoreguidelines/prefer-member-initializer>` check to
   ignore delegate constructors.
 
+- Improved :doc:`cppcoreguidelines-pro-type-member-init
+  <clang-tidy/checks/cppcoreguidelines/pro-type-member-init>` check to ignore
+  dependent delegate constructors.
+
 - Improved :doc:`llvm-namespace-comment
   <clang-tidy/checks/llvm/namespace-comment>` check to provide fixes for
   ``inline`` namespaces in the same format as :program:`clang-format`.
 
 - Improved :doc:`modernize-loop-convert
   <clang-tidy/checks/modernize/loop-convert>` to support for-loops with
   iterators initialized by free functions like ``begin``, ``end``, or ``size``.
 

clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-type-member-init.cpp

 
 // This pathological template fails to compile if actually instantiated. It
 // results in the check seeing a null RecordDecl when examining the base class
 // initializer list.
 template <typename T>
 class PositiveSelfInitialization : NegativeAggregateType
 {
   PositiveSelfInitialization() : PositiveSelfInitialization() {}
-  // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: constructor does not initialize these bases: NegativeAggregateType
-  // CHECK-FIXES: PositiveSelfInitialization() : NegativeAggregateType(), PositiveSelfInitialization() {}
+  // This will be detected by -Wdelegating-ctor-cycles and there is no proper way to fix this
 };
 
 class PositiveIndirectMember {
   struct {
     int *A;
     // CHECK-FIXES: int *A{};
   };
 
struct S3 {
   // CHECK-MESSAGES: :[[@LINE-1]]:3: warning: constructor does not initialize these fields: A [cppcoreguidelines-pro-type-member-init]
   int A;
   // CHECK-FIXES: int A{};
   union {
     int B;
     int C = 0;
   };
 };
+
+// Ignore issues from delegate constructors
+namespace PR37250 {
+  template <typename T>
+  struct A {
+    A() : A(42) {}
+    explicit A(int value) : value_(value) {}
+    int value_;
+  };
+
+  struct B {
+    B() : B(42) {}
+    explicit B(int value) : value_(value) {}
+    int value_;
+  };
+
+  template <typename T>
+  struct C {
+    C() : C(T()) {}
+    explicit C(T value) : value_(value) {}
+    T value_;
+  };
+
+  struct V {
+    unsigned size() const;
+  };
+
+  struct S {
+    unsigned size_;
+
+    S(unsigned size) : size_{size} {}
+
+    template<typename U>
+    S(const U& u) : S(u.size()) {}
+  };
+
+  const V v;
+  const S s{v};
+}