The newly added tests are all about scalable vector types.
Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/test/Transforms/VectorCombine/AArch64/load-insert-store.ll | ||
---|---|---|
8 ↗ | (On Diff #547204) | Was this generated by update_test_checks? |
llvm/test/Transforms/VectorCombine/AArch64/load-insert-store.ll | ||
---|---|---|
8 ↗ | (On Diff #547204) | Yes. All checks were auto generated by update_test_checks, without any manual modifcation. |
llvm/test/Transforms/VectorCombine/AArch64/load-insert-store.ll | ||
---|---|---|
8 ↗ | (On Diff #547204) | I did not see CHECK-SAME in other test files, do we have to manually remove them ? |
I did not notice that there were already negative cases in the common file test/Transform/VectorCombine/load-insert-store.ll, so I only added target specific cases in my new patch version. These cases whether can be transformed depend on the TTI of each backend.
Is this test coverage for an upcoming patch or just more thorough coverage for the existing transform?
llvm/test/Transforms/VectorCombine/AArch64/load-insert-store.ll | ||
---|---|---|
8 ↗ | (On Diff #547204) | This is the version 2 output of update_test_checks, which includes the function signature. Older tests don't. |
I plan to implement several TODOs in VectorCombine. And I hope these cases can be transformed in the future.
llvm/test/Transforms/VectorCombine/AArch64/load-insert-store.ll | ||
---|---|---|
8 ↗ | (On Diff #547204) | So we should keep it as what it is ? |
llvm/test/Transforms/VectorCombine/AArch64/load-insert-store.ll | ||
---|---|---|
8 ↗ | (On Diff #547204) | Yes, you should keep it as is. |