Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Event Timeline
llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop2.txt | ||
---|---|---|
2 | I think we should use the same naming paradigm and workflow for CHECK names as in the codegen tests. To match codegen, it would make -mattr=+real-true16 tests are called 'GFX11'. There is an argument to do the naming the other way, where '-mattr=-real-true16' continues to be GFX11. Both are fine from my PoV; perhaps the choice should me made to minimize merge pain. |
llvm/test/MC/Disassembler/AMDGPU/gfx11_dasm_vop2.txt | ||
---|---|---|
2 |
That was my aim, but in this particular test GFX11 is used as a common prefix. |
Is there any test that verifies that -mattr=-real-true16 is the default? If so, LGTM
All tests that don't use this flag rely on that be the default and wouldn't pass otherwise, so I assume no special tests needed.
I think we should use the same naming paradigm and workflow for CHECK names as in the codegen tests. To match codegen, it would make -mattr=+real-true16 tests are called 'GFX11'. There is an argument to do the naming the other way, where '-mattr=-real-true16' continues to be GFX11. Both are fine from my PoV; perhaps the choice should me made to minimize merge pain.