This is an archive of the discontinued LLVM Phabricator instance.

Differential D156686

[AST] Simplify Type::isSizelessBuiltinType(). NFC.
ClosedPublic

Authored by Jim on Jul 31 2023, 6:19 AM.

Details

Reviewers
kazu
craig.topper
Commits
rG1c1066797c5b: [AST] Simplify Type::isSizelessBuiltinType(). NFC.
Summary

Reuse isSVESizelessBuiltinType() and isRVVSizelessBuiltinType().

Diff Detail

Event Timeline

Jim created this revision.Jul 31 2023, 6:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 6:19 AM
Herald added subscribers: ctetreau, s.egerton, simoncook. · View Herald Transcript
Jim requested review of this revision.Jul 31 2023, 6:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 31 2023, 6:19 AM
Herald added subscribers: cfe-commits, wangpc. · View Herald Transcript
Jim added a reviewer: kazu.Jul 31 2023, 6:19 AM
Harbormaster completed remote builds in B249194: Diff 545625.Jul 31 2023, 7:41 AM
Jim added a reviewer: craig.topper.Jul 31 2023, 8:38 PM
craig.topper added inline comments.Jul 31 2023, 8:43 PM
clang/lib/AST/Type.cpp
2356
Jim updated this revision to Diff 545921.Jul 31 2023, 11:07 PM

Address comment.

Jim marked an inline comment as done.Jul 31 2023, 11:07 PM
Harbormaster completed remote builds in B249394: Diff 545921.Jul 31 2023, 11:43 PM
craig.topper accepted this revision.Aug 1 2023, 9:41 AM

LGTM

This revision is now accepted and ready to land.Aug 1 2023, 9:41 AM
Closed by commit rG1c1066797c5b: [AST] Simplify Type::isSizelessBuiltinType(). NFC. (authored by Jim). · Explain WhyAug 1 2023, 7:47 PM
This revision was automatically updated to reflect the committed changes.
Jim added a commit: rG1c1066797c5b: [AST] Simplify Type::isSizelessBuiltinType(). NFC..

Revision Contents

PathSize
clang/
lib/
AST/
9 lines

Diff 546298

clang/lib/AST/Type.cpp

Show First 20 Lines • Show All 2,347 Lines • ▼ Show 20 Lines case ObjCInterface: {
if (Def) if (Def)
*Def = Interface; *Def = Interface;
return !Interface->hasDefinition(); return !Interface->hasDefinition();
} }
} }
} }
bool Type::isSizelessBuiltinType() const { bool Type::isSizelessBuiltinType() const {
if (isSVESizelessBuiltinType() || isRVVSizelessBuiltinType())
craig.topperUnsubmitted
Done
ReplyInline Actions
bool Type::isSizelessBuiltinType() const {
- if (isSVESizelessBuiltinType())
+ if (isSVESizelessBuiltinType() || isRVVSizelessBuiltinType())
+ return true;
return true;
craig.topper:
return true;
if (const BuiltinType *BT = getAs<BuiltinType>()) { if (const BuiltinType *BT = getAs<BuiltinType>()) {
switch (BT->getKind()) { switch (BT->getKind()) {
// SVE Types
#define SVE_TYPE(Name, Id, SingletonId) case BuiltinType::Id:
#include "clang/Basic/AArch64SVEACLETypes.def"
#define RVV_TYPE(Name, Id, SingletonId) case BuiltinType::Id:
#include "clang/Basic/RISCVVTypes.def"
return true;
// WebAssembly reference types // WebAssembly reference types
#define WASM_TYPE(Name, Id, SingletonId) case BuiltinType::Id: #define WASM_TYPE(Name, Id, SingletonId) case BuiltinType::Id:
#include "clang/Basic/WebAssemblyReferenceTypes.def" #include "clang/Basic/WebAssemblyReferenceTypes.def"
return true; return true;
default: default:
return false; return false;
} }
} }
▲ Show 20 Lines • Show All 2,374 Lines • Show Last 20 Lines