Details
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
llvm/lib/Target/AMDGPU/SIRegisterInfo.td | ||
---|---|---|
1247 | Please add a comment saying when each of these 4 versions shall be used. I think the intention is: | |
llvm/lib/Target/AMDGPU/VOP2Instructions.td | ||
381 | Shall this be renamed to include fake16? I guess a distinct true16 version will be added at a later point. | |
406 | Shall this be renamed to include fake16? I guess a distinct true16 version will be added at a later point. |
llvm/lib/Target/AMDGPU/VOP2Instructions.td | ||
---|---|---|
406 | But this *Is* the fake version, and when merged with the true16 version downstream both will exist. So I think it makes sense to rename immediately. |
llvm/lib/Target/AMDGPU/VOP2Instructions.td | ||
---|---|---|
406 |
Here upstream it will continue to be a fake instruction, which it is here, and downstream it will continue to be the real instruction, which it is there -- all until we decide to support both the versions. There are hundreds of references to _t16 entities here in the mainline, none of which are real True16 things. Renaming them all right away would go against the whole idea of bringing in changes gradually. |
llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp | ||
---|---|---|
1474 | Is it intentional that you're not calling decodeNonVGPRSrcOp here and instead duplicating parts of the function? |
Update decodeSrcOp() to use decodeNonVGPRSrcOp().
llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp | ||
---|---|---|
1474 | Good catch. This is an oversight. |
llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp | ||
---|---|---|
265–318 | [3892/4628] Building CXX object lib/Target/AMDGPU/Disassembler/CMakeFiles/LLVMAMDGPUDisassembler.dir/AMDGPUDisassembler.cpp.o /android0/llvm-project/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:265:21: warning: unused function 'DecodeVGPR_16RegisterClass' [-Wunused-function] static DecodeStatus DecodeVGPR_16RegisterClass(MCInst &Inst, unsigned Imm, ^ /android0/llvm-project/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:278:1: warning: unused function 'DecodeVGPR_16_Lo128RegisterClass' [-Wunused-function] DecodeVGPR_16_Lo128RegisterClass(MCInst &Inst, unsigned Imm, uint64_t /*Addr*/, ^ /android0/llvm-project/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:288:21: warning: unused function 'decodeOperand_VSrcT16_Lo128' [-Wunused-function] static DecodeStatus decodeOperand_VSrcT16_Lo128(MCInst &Inst, unsigned Imm, ^ /android0/llvm-project/llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp:304:21: warning: unused function 'decodeOperand_VSrcT16' [-Wunused-function] static DecodeStatus decodeOperand_VSrcT16(MCInst &Inst, unsigned Imm, ^ |
llvm/lib/Target/AMDGPU/Disassembler/AMDGPUDisassembler.cpp | ||
---|---|---|
265–318 | The following patches down the chain will make these used; I'm about to submit them. |