This is an archive of the discontinued LLVM Phabricator instance.

Differential D155490

[clang][docs] Fix tag target name in link
ClosedPublic

Authored by paulkirth on Jul 17 2023, 10:13 AM.

Details

Reviewers
None
Commits
rG5784c47806cf: [clang][docs] Fix tag target name in link
Summary

The see patch tag conflicted w/ one later in the document. Changing
the text should fix the documentation build error.

Diff Detail

Event Timeline

paulkirth created this revision.Jul 17 2023, 10:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2023, 10:13 AM
paulkirth requested review of this revision.Jul 17 2023, 10:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJul 17 2023, 10:13 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
This revision was not accepted when it landed; it landed in state Needs Review.Jul 17 2023, 10:18 AM
This revision was landed with ongoing or failed builds.
Closed by commit rG5784c47806cf: [clang][docs] Fix tag target name in link (authored by paulkirth). · Explain Why
This revision was automatically updated to reflect the committed changes.
paulkirth added a commit: rG5784c47806cf: [clang][docs] Fix tag target name in link.
aaron.ballman added a subscriber: aaron.ballman.Jul 17 2023, 10:19 AM

LGTM -- feel free to land these kind of fixes without review, since they're getting a failing bot back to green.

paulkirth mentioned this in D146777: [clang] Preliminary fat-lto-object support.Jul 17 2023, 10:19 AM
paulkirth added a comment.Jul 17 2023, 10:22 AM

yeah, I did arc diff w/o thinking about it, and then realized I should
have just pushed immediately.

MaskRay added a subscriber: MaskRay.Jul 17 2023, 10:38 AM

I find that See patch is used elsewhere. Does this change fix a sphinx bot?

paulkirth added a comment.Jul 17 2023, 11:01 AM
In D155490#4507061, @MaskRay wrote:

I find that See patch is used elsewhere. Does this change fix a sphinx bot?

yes: https://lab.llvm.org/buildbot#builders/92/builds/47401

Harbormaster completed remote builds in B245915: Diff 541116.Jul 17 2023, 4:13 PM

Revision Contents

PathSize
clang/
docs/
2 lines

Diff 541120

clang/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 263 Lines • ▼ Show 20 Lines
- ``clang -g -gsplit-dwarf a.c -o obj/x`` (compile and link) now generates the - ``clang -g -gsplit-dwarf a.c -o obj/x`` (compile and link) now generates the
``.dwo`` file at ``obj/x-a.dwo``, instead of a file in the temporary ``.dwo`` file at ``obj/x-a.dwo``, instead of a file in the temporary
directory (``/tmp`` on \*NIX systems, if none of the environment variables directory (``/tmp`` on \*NIX systems, if none of the environment variables
TMPDIR, TMP, and TEMP are specified). TMPDIR, TMP, and TEMP are specified).
- ``-ffat-lto-objects`` can now be used to emit object files with both object - ``-ffat-lto-objects`` can now be used to emit object files with both object
code and LLVM bitcode. Previously this flag was ignored for GCC compatibility. code and LLVM bitcode. Previously this flag was ignored for GCC compatibility.
(`See patch <https://reviews.llvm.org/D146777>`_). (`See related patch <https://reviews.llvm.org/D146777>`_).
Removed Compiler Flags Removed Compiler Flags
------------------------- -------------------------
- The deprecated flag `-fmodules-ts` is removed. Please use ``-std=c++20`` - The deprecated flag `-fmodules-ts` is removed. Please use ``-std=c++20``
or higher to use standard C++ modules instead. or higher to use standard C++ modules instead.
- The deprecated flag `-fcoroutines-ts` is removed. Please use ``-std=c++20`` - The deprecated flag `-fcoroutines-ts` is removed. Please use ``-std=c++20``
or higher to use standard C++ coroutines instead. or higher to use standard C++ coroutines instead.
- The CodeGen flag `-lower-global-dtors-via-cxa-atexit` which affects how global - The CodeGen flag `-lower-global-dtors-via-cxa-atexit` which affects how global
▲ Show 20 Lines • Show All 650 Lines • Show Last 20 Lines