This is an archive of the discontinued LLVM Phabricator instance.

[flang] Add PowerPC vec_convert, vec_ctf and vec_cvf intrinsic
ClosedPublic

Authored by kkwli0 on Jul 13 2023, 2:04 PM.

Details

Summary

This patch is to add vec_convert, vec_ctf and vec_cvf intrinsic and the semantic checking for the vec_ctf.

Co-authored-by: Paul Scoropan <1paulscoropan@gmail.com>

Diff Detail

Event Timeline

kkwli0 created this revision.Jul 13 2023, 2:04 PM
Herald added a reviewer: aartbik. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
kkwli0 requested review of this revision.Jul 13 2023, 2:04 PM
DanielCChen requested changes to this revision.Jul 18 2023, 8:19 AM
DanielCChen added inline comments.
flang/module/__ppc_intrinsics.f90
34

#undef ELEM_FUNC_VRVR_2

127

Probably should use assumed-rank instead as it is a standard feature.

136

Same as above.

145

Same as above.

171

Nit: The #undef seems out of the order of #define.

402

VEC_VR_VR_2

403

VR_VR_2

670

It seems there is no #define for this one.

671

Same as above.

672

Same as above.

672

Same as above.

673

Same as above.

673

Seems these *_2 don't have corresponding #define. Same apply to the ones below.

809

Nit: #undef order.

This revision now requires changes to proceed.Jul 18 2023, 8:19 AM
kkwli0 marked 14 inline comments as done.Jul 18 2023, 2:30 PM
kkwli0 added inline comments.
flang/module/__ppc_intrinsics.f90
127

Assumed rank entity of vector type is not supported yet.

670

Remove it

671

Remove it.

kkwli0 updated this revision to Diff 541738.Jul 18 2023, 2:33 PM
kkwli0 marked 3 inline comments as done.

Address review comments and rebase.

This revision is now accepted and ready to land.Jul 19 2023, 5:56 PM
flang/module/__ppc_intrinsics.f90