- User Since
- Nov 10 2022, 8:05 AM (45 w, 3 d)
Aug 21 2023
Aug 18 2023
Aug 17 2023
Aug 16 2023
Close this review as a different implementation that uses derived type wrapper approach has been landed.
Landed with commit c09d3c1ead632e39c19a78049f6e663b6dbebc4e
Aug 15 2023
Aug 14 2023
Aug 10 2023
Thanks for keeping the ordering consistent. LGTM now.
Aug 9 2023
Ping. Would the reviewers please review this patch?
Aug 3 2023
Aug 2 2023
Fix the test header to to only dump llvm IR.
To remove the pwr10 check as we plan to do it as target feature checking as in clang.
Rebase to include the fix of adding llvm_unreachable.
Thanks to @klausler for fixing it!
Jul 28 2023
Jul 27 2023
Fix the build failure due to chang-format checking.
Jul 26 2023
Remove check for mma intrinsics from this patch. It will be added back in with the MMA intrinsic patch.
To address review comments.
Jul 25 2023
It seems the module and the test are missing from the last update. Put them back in after rebase.
Add semantic checking for specific supported cpu. In this case, power10.
Add the test cases.
Address review comments to remove unrelated changes.
Jul 24 2023
Jul 21 2023
Fixing a build failure using clang as the build compiler.
Jul 20 2023
Attempt to fix the x64 Window build failure that failed due to linker error as:
Add the MMA intrinsic module and the testing of LLVM IR.
Jul 19 2023
Jul 18 2023
Jul 11 2023
The code gen part LGTM.
Jun 9 2023
Jun 8 2023
May 25 2023
Sorry that the patch file was accidentally added to the review. This revision is to remove it.
To address review comments. Separating typeCompatible into two Booleans.
May 24 2023
May 17 2023
Apr 5 2023
Mar 28 2023
@klausler @jeanPerier We have been looking into the derived type wrapper approach. Besides the question in my response to Peter's comments regarding if the derived types layout is OK to represent those 3 different vector types, I have another question of type compatibility checking.
Consider the following vector code:
Mar 27 2023
Thanks for the quick response!
Mar 26 2023
Thanks for the review and the comments!
Mar 24 2023
Mar 23 2023
Jan 19 2023
Jan 17 2023
Ping: I appreciate it if reviewers can review the change. Thanks to all.
Jan 11 2023
I tried to add “rG LLVM Github Monorepo” in the Repository field before creating the revision, but it disappeared. Does someone know why it happened?