This is an archive of the discontinued LLVM Phabricator instance.

[NFC][RISCV] Rewrite TableGen files using named arguments
ClosedPublic

Authored by wangpc on Jun 29 2023, 4:57 AM.

Diff Detail

Event Timeline

wangpc created this revision.Jun 29 2023, 4:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2023, 4:57 AM
wangpc requested review of this revision.Jun 29 2023, 4:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 29 2023, 4:57 AM
This revision is now accepted and ready to land.Jul 10 2023, 6:31 AM
MaskRay accepted this revision.Jul 10 2023, 10:38 AM

Have you tested that the generated .inc files do not change?

Have you tested that the generated .inc files do not change?

Juts confirmed that.
Theoretically, these changes change nothing but the way to pass arguments. The result Records won't be of any difference so these TableGen backends won't be influenced. :-)

MaskRay added a comment.EditedJul 11 2023, 9:57 AM

Have you tested that the generated .inc files do not change?

Juts confirmed that.
Theoretically, these changes change nothing but the way to pass arguments. The result Records won't be of any difference so these TableGen backends won't be influenced. :-)

Sounds great! Theoretically .inc files shouldn't change. Confirming this just gives more confidence that the feature is correctly implemented:)

This revision was landed with ongoing or failed builds.Jul 20 2023, 2:18 AM
This revision was automatically updated to reflect the committed changes.