Page MenuHomePhabricator

Paul-C-Anagnostopoulos (Paul C. Anagnostopoulos)
User

Projects

User does not belong to any projects.

User Details

User Since
Jul 27 2020, 8:22 AM (46 w, 3 d)

Recent Activity

Thu, Jun 10

Paul-C-Anagnostopoulos committed rG407c11b56337: [TableGen] Eliminate dead code in ParseForeachDeclaration [NFC] (authored by Paul-C-Anagnostopoulos).
[TableGen] Eliminate dead code in ParseForeachDeclaration [NFC]
Thu, Jun 10, 7:36 AM
Paul-C-Anagnostopoulos closed D103904: [TableGen] Eliminate dead code in ParseForeachDeclaration [NFC].
Thu, Jun 10, 7:36 AM · Restricted Project

Wed, Jun 9

Paul-C-Anagnostopoulos committed rGef8df920fbbc: [TableGen] Fix ProfileFoldOpInit so that parameters are named consistently [NFC] (authored by Paul-C-Anagnostopoulos).
[TableGen] Fix ProfileFoldOpInit so that parameters are named consistently [NFC]
Wed, Jun 9, 6:24 AM
Paul-C-Anagnostopoulos closed D103823: [TableGen] Fix ProfileFoldOpInit so that parameters are named consistently [NFC].
Wed, Jun 9, 6:24 AM · Restricted Project

Tue, Jun 8

Paul-C-Anagnostopoulos requested review of D103904: [TableGen] Eliminate dead code in ParseForeachDeclaration [NFC].
Tue, Jun 8, 8:55 AM · Restricted Project

Mon, Jun 7

Paul-C-Anagnostopoulos requested review of D103823: [TableGen] Fix ProfileFoldOpInit so that parameters are named consistently [NFC].
Mon, Jun 7, 9:01 AM · Restricted Project

Thu, May 20

Paul-C-Anagnostopoulos committed rGfa6e87cc5a21: [TableGen] [Clang] Clean up arm_mve.td file. (authored by Paul-C-Anagnostopoulos).
[TableGen] [Clang] Clean up arm_mve.td file.
Thu, May 20, 6:40 AM
Paul-C-Anagnostopoulos closed D102238: [TableGen] [Clang] Clean up arm_mve.td file.
Thu, May 20, 6:40 AM · Restricted Project

Wed, May 19

Paul-C-Anagnostopoulos added a comment to D102238: [TableGen] [Clang] Clean up arm_mve.td file.

Sorry, I removed it but didn't update this review. All set now.

Wed, May 19, 4:28 AM · Restricted Project

May 18 2021

Paul-C-Anagnostopoulos added a comment to D102238: [TableGen] [Clang] Clean up arm_mve.td file.

Could I get an LGTM on this? I have removed the spurious comment.

May 18 2021, 6:34 AM · Restricted Project

May 13 2021

Paul-C-Anagnostopoulos committed rGfe9101c3d8db: [TableGen] Make the NUL character invalid in .td files (authored by Paul-C-Anagnostopoulos).
[TableGen] Make the NUL character invalid in .td files
May 13 2021, 7:18 AM
Paul-C-Anagnostopoulos closed D102254: [TableGen] Make the NUL character invalid in .td files, version 2.
May 13 2021, 7:18 AM · Restricted Project

May 12 2021

Paul-C-Anagnostopoulos added inline comments to D102238: [TableGen] [Clang] Clean up arm_mve.td file.
May 12 2021, 7:05 AM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D102238: [TableGen] [Clang] Clean up arm_mve.td file.

One must amend the commit when one makes changes to the files.

May 12 2021, 6:57 AM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D102238: [TableGen] [Clang] Clean up arm_mve.td file.

The arm_*.inc files do not change with this revision.

May 12 2021, 6:55 AM · Restricted Project

May 11 2021

Paul-C-Anagnostopoulos added inline comments to D102238: [TableGen] [Clang] Clean up arm_mve.td file.
May 11 2021, 10:53 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D102254: [TableGen] Make the NUL character invalid in .td files, version 2.

I couldn't find anything in the actions to "restart review." Did I miss it?

May 11 2021, 10:14 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D102254: [TableGen] Make the NUL character invalid in .td files, version 2.
May 11 2021, 10:00 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to rG6ca2bdb03c0f: [TableGen] Make the NUL character invalid in .td files.

I'll start a new Phabrication for the change.

May 11 2021, 9:58 AM
Paul-C-Anagnostopoulos updated subscribers of rG6ca2bdb03c0f: [TableGen] Make the NUL character invalid in .td files.

I reverted this commit. There is at least one build that uses a 'sed' that interprets \x00 as "x00" and so does not substitute a NUL character.

May 11 2021, 7:48 AM
Paul-C-Anagnostopoulos committed rG46402eb103d0: Revert "[TableGen] Make the NUL character invalid in .td files" (authored by Paul-C-Anagnostopoulos).
Revert "[TableGen] Make the NUL character invalid in .td files"
May 11 2021, 7:44 AM
Paul-C-Anagnostopoulos requested review of D102238: [TableGen] [Clang] Clean up arm_mve.td file.
May 11 2021, 7:25 AM · Restricted Project
Paul-C-Anagnostopoulos committed rG6ca2bdb03c0f: [TableGen] Make the NUL character invalid in .td files (authored by Paul-C-Anagnostopoulos).
[TableGen] Make the NUL character invalid in .td files
May 11 2021, 6:21 AM
Paul-C-Anagnostopoulos closed D101923: [TableGen] Make the NUL character invalid in .td files.
May 11 2021, 6:21 AM · Restricted Project

May 10 2021

Paul-C-Anagnostopoulos updated the diff for D101923: [TableGen] Make the NUL character invalid in .td files.

I used David's trick to eliminate the NUL characters in the test file. They are now represented by at signs (@) and translated on the fly.

May 10 2021, 9:10 AM · Restricted Project
Paul-C-Anagnostopoulos accepted D102151: [TableGen] Remove redundant `Error:` in msg (NFC).

LGTM.

May 10 2021, 4:18 AM · Restricted Project

May 7 2021

Paul-C-Anagnostopoulos added a comment to D101923: [TableGen] Make the NUL character invalid in .td files.

Hang on, there is already a TableGen test that uses sed: intrin-properties.td. So obviously I have sed in the right place.

May 7 2021, 5:20 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D101923: [TableGen] Make the NUL character invalid in .td files.

No, I was confused, thinking that the modified file would go back through Lit. But of course it doesn't. I will set up something like you suggest. I'm sure there is a way to use an escape sequence to represent the NUL character in sed . . . yes, \000.

May 7 2021, 4:56 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D101923: [TableGen] Make the NUL character invalid in .td files.

There are test files that use sed to do replacements. I'll ask on llvm dev how to create a RUN: line that does the right thing. It has to replace @ with NUL and get rid of the sed command so it doesn't recurse forever. My Unix command knowledge is meager.

May 7 2021, 4:36 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D101923: [TableGen] Make the NUL character invalid in .td files.

Okay, sounds good. I'll see what I can find.

May 7 2021, 4:22 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D101923: [TableGen] Make the NUL character invalid in .td files.

There are four or five NULs in the test file, to check them in various positions. Would it be helpful to add a second nul-char.txt file that is a duplicate, except that it has an at sign (@) where every null is? I could refer to it with a comment in nul-char.td.

May 7 2021, 4:02 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to rG191ffda3f70b: [RISCV] Remove unused ComplexPatterns. NFC.

The TableGen frontend has no way of knowing whether a particular backend, will use a record, nor any way of knowing whether no backends at all will use it. I'm not sure how we could detect unused records.

May 7 2021, 5:17 AM

May 6 2021

Paul-C-Anagnostopoulos accepted D101994: [TableGen] Use range-based for loops (NFC).

LGTM. Just please verify that it passes all the TableGen tests.

May 6 2021, 9:16 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D101994: [TableGen] Use range-based for loops (NFC).

Nice cleanup! I presume this passes all the TableGen tests?

May 6 2021, 7:12 AM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D101923: [TableGen] Make the NUL character invalid in .td files.

I added a test. There are NULs in the .td file.

May 6 2021, 6:51 AM · Restricted Project
Paul-C-Anagnostopoulos committed rGd40a0b8af771: [TableGen] [Clang] Clean up Options.td and add asserts. (authored by Paul-C-Anagnostopoulos).
[TableGen] [Clang] Clean up Options.td and add asserts.
May 6 2021, 6:34 AM
Paul-C-Anagnostopoulos closed D101766: [TableGen] [Clang] Clean up Options.td and add asserts.
May 6 2021, 6:34 AM · Restricted Project

May 5 2021

Paul-C-Anagnostopoulos added inline comments to D101923: [TableGen] Make the NUL character invalid in .td files.
May 5 2021, 1:30 PM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D101766: [TableGen] [Clang] Clean up Options.td and add asserts.

Restored whitespace as requested by Jan.

May 5 2021, 10:12 AM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D101923: [TableGen] Make the NUL character invalid in .td files.

Now the //// comments should be gone.

May 5 2021, 10:06 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D101923: [TableGen] Make the NUL character invalid in .td files.

Hmm. I swore I deleted all the //// lines. Hang on . . .

May 5 2021, 10:04 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D101923: [TableGen] Make the NUL character invalid in .td files.
May 5 2021, 10:04 AM · Restricted Project

May 4 2021

Paul-C-Anagnostopoulos added inline comments to D101766: [TableGen] [Clang] Clean up Options.td and add asserts.
May 4 2021, 5:47 AM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D101766: [TableGen] [Clang] Clean up Options.td and add asserts.
May 4 2021, 4:40 AM · Restricted Project

May 3 2021

Paul-C-Anagnostopoulos requested review of D101766: [TableGen] [Clang] Clean up Options.td and add asserts.
May 3 2021, 10:14 AM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D101626: [TableGen] Fix two bugs in 'defm' when a complex 'assert' is involved.
May 3 2021, 4:20 AM · Restricted Project

Apr 30 2021

Paul-C-Anagnostopoulos committed rG985ab6e1fa57: [TableGen] Fix two bugs in 'defm' when complex 'assert' is involved. (authored by Paul-C-Anagnostopoulos).
[TableGen] Fix two bugs in 'defm' when complex 'assert' is involved.
Apr 30 2021, 8:33 AM
Paul-C-Anagnostopoulos closed D101626: [TableGen] Fix two bugs in 'defm' when a complex 'assert' is involved.
Apr 30 2021, 8:33 AM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D101626: [TableGen] Fix two bugs in 'defm' when a complex 'assert' is involved.
Apr 30 2021, 7:02 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D101626: [TableGen] Fix two bugs in 'defm' when a complex 'assert' is involved.
Apr 30 2021, 6:38 AM · Restricted Project

Apr 28 2021

Paul-C-Anagnostopoulos committed rG952c6ddd8b32: [TableGen] Add the !find bang operator (authored by Paul-C-Anagnostopoulos).
[TableGen] Add the !find bang operator
Apr 28 2021, 6:54 AM
Paul-C-Anagnostopoulos closed D101318: [TableGen] Add the !find bang operator.
Apr 28 2021, 6:54 AM · Restricted Project

Apr 27 2021

Paul-C-Anagnostopoulos added a comment to D101318: [TableGen] Add the !find bang operator.

I will push this on Wednesday.

Apr 27 2021, 10:50 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D101251: [TableGen] Generate LegalizerInfo.

@paperchalice: I don't understand the purpose of this revision. Could you explain in more detail?

Apr 27 2021, 9:02 AM · Restricted Project

Apr 26 2021

Paul-C-Anagnostopoulos added a comment to D101318: [TableGen] Add the !find bang operator.

It makes good sense to spend some time now on additional TableGen file cleanup. There is one file with TODOs for assert, so I will start there.

Apr 26 2021, 4:06 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D101318: [TableGen] Add the !find bang operator.

I added !find() to complement !substr(), so that TableGen would have the two most common string functions. I believe !find will be helpful with 'assert' as people begin adding assertions to TableGen files.

Apr 26 2021, 2:08 PM · Restricted Project
Paul-C-Anagnostopoulos requested review of D101318: [TableGen] Add the !find bang operator.
Apr 26 2021, 12:18 PM · Restricted Project
Paul-C-Anagnostopoulos committed rGff0ddd5ce476: [TableGen] Remove a TODO comment that is no longer relevant [NFC] (authored by Paul-C-Anagnostopoulos).
[TableGen] Remove a TODO comment that is no longer relevant [NFC]
Apr 26 2021, 7:04 AM
Paul-C-Anagnostopoulos committed rG2d4c4d3c5436: [TableGen] Change assertion information from a tuple to a struct [NFC] (authored by Paul-C-Anagnostopoulos).
[TableGen] Change assertion information from a tuple to a struct [NFC]
Apr 26 2021, 6:58 AM
Paul-C-Anagnostopoulos closed D100854: [TableGen] Change assertion information from a tuple to a struct [NFC].
Apr 26 2021, 6:58 AM · Restricted Project

Apr 23 2021

Paul-C-Anagnostopoulos updated the diff for D100854: [TableGen] Change assertion information from a tuple to a struct [NFC].

Incorporate latest comments from @dblaikie and @craig.topper.

Apr 23 2021, 9:46 AM · Restricted Project
Paul-C-Anagnostopoulos committed rGd9187f50b98f: [TableGen] [docs] Improve BNF for the 'multiclass' statement [NFC] (authored by Paul-C-Anagnostopoulos).
[TableGen] [docs] Improve BNF for the 'multiclass' statement [NFC]
Apr 23 2021, 9:06 AM
Paul-C-Anagnostopoulos committed rG9d609adcb0b5: [TableGen] Correct some comments in the TableGen parser [NFC] (authored by Paul-C-Anagnostopoulos).
[TableGen] Correct some comments in the TableGen parser [NFC]
Apr 23 2021, 6:54 AM
Paul-C-Anagnostopoulos closed D101088: [TableGen] Correct some comments in the TableGen parser [NFC].
Apr 23 2021, 6:54 AM · Restricted Project
Paul-C-Anagnostopoulos committed rG6a067cdb06a0: [TableGen] [docs] Improve description of NAME in Programmer's Reference (authored by Paul-C-Anagnostopoulos).
[TableGen] [docs] Improve description of NAME in Programmer's Reference
Apr 23 2021, 6:50 AM
Paul-C-Anagnostopoulos closed D100867: [TableGen] [docs] Improve description of NAME in Programmer's Reference.
Apr 23 2021, 6:49 AM · Restricted Project

Apr 22 2021

Paul-C-Anagnostopoulos added inline comments to D100854: [TableGen] Change assertion information from a tuple to a struct [NFC].
Apr 22 2021, 11:53 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D101088: [TableGen] Correct some comments in the TableGen parser [NFC].

Ah, so a trivial change like this doesn't need review. Thanks!

Apr 22 2021, 11:15 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D101088: [TableGen] Correct some comments in the TableGen parser [NFC].
Apr 22 2021, 10:29 AM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D100854: [TableGen] Change assertion information from a tuple to a struct [NFC].

I have incorporated the lint changes and David's suggestions.

Apr 22 2021, 10:01 AM · Restricted Project
Paul-C-Anagnostopoulos updated the diff for D100867: [TableGen] [docs] Improve description of NAME in Programmer's Reference.

I added a note about the term "parent class." It proved futile to try to remove the word "parent" in certain sentences. Many pertain to both classes and records. And those that don't just seemed to become inconsistent when I tried to remove the word.

Apr 22 2021, 6:39 AM · Restricted Project

Apr 21 2021

Paul-C-Anagnostopoulos added a comment to D100867: [TableGen] [docs] Improve description of NAME in Programmer's Reference.

I'm going to stick with "parent class," but if there are any sentences that talk only about records, I will try to use just "class." I will add a note at the appropriate spot explaining this.

Apr 21 2021, 6:11 AM · Restricted Project

Apr 20 2021

Paul-C-Anagnostopoulos added a comment to D100867: [TableGen] [docs] Improve description of NAME in Programmer's Reference.

The more I think about it, the more I like "parent class" rather than "base class." It's the only term that seems like it could apply to a record's class. Let me look at the uses and see if some or most can just use the term "class."

Apr 20 2021, 7:22 PM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D100867: [TableGen] [docs] Improve description of NAME in Programmer's Reference.
Apr 20 2021, 7:17 PM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D100867: [TableGen] [docs] Improve description of NAME in Programmer's Reference.
Apr 20 2021, 4:53 PM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D100867: [TableGen] [docs] Improve description of NAME in Programmer's Reference.
Apr 20 2021, 3:40 PM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D100854: [TableGen] Change assertion information from a tuple to a struct [NFC].
Apr 20 2021, 3:37 PM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D100854: [TableGen] Change assertion information from a tuple to a struct [NFC].

Thanks, @dblaikie. I will incorporated your suggestions and the linties.

Apr 20 2021, 10:30 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D100867: [TableGen] [docs] Improve description of NAME in Programmer's Reference.
Apr 20 2021, 10:09 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D100854: [TableGen] Change assertion information from a tuple to a struct [NFC].
Apr 20 2021, 7:26 AM · Restricted Project

Apr 19 2021

Paul-C-Anagnostopoulos committed rGa5aaec8f4e89: [TableGen] Add support for the 'assert' statement in multiclasses (authored by Paul-C-Anagnostopoulos).
[TableGen] Add support for the 'assert' statement in multiclasses
Apr 19 2021, 6:02 AM
Paul-C-Anagnostopoulos closed D99751: Add the TableGen assert statement, step 3.
Apr 19 2021, 6:02 AM · Restricted Project

Apr 17 2021

Paul-C-Anagnostopoulos added a comment to D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures.

For my future reference: What is the sequence you go through to ensure that no target output files change? Do you just build with the current system, then build with the revision and check that no output file dates changed?

Apr 17 2021, 10:43 AM · Restricted Project
Paul-C-Anagnostopoulos added inline comments to D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures.
Apr 17 2021, 10:40 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D100691: [TableGen] Store predicates in PatternToMatch as ListInit *. Add string for HwModeFeatures.

I presume this passes all the TableGen tests.

Apr 17 2021, 8:07 AM · Restricted Project

Apr 16 2021

Paul-C-Anagnostopoulos committed rG6445d5ba8496: [TableGen] Allow mnemonics aliases with uppercase (authored by paperchalice).
[TableGen] Allow mnemonics aliases with uppercase
Apr 16 2021, 6:59 AM
Paul-C-Anagnostopoulos closed D96691: [TableGen] Allow mnemonics aliases with uppercase.
Apr 16 2021, 6:58 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D96691: [TableGen] Allow mnemonics aliases with uppercase.

I am pushing this revision today.

Apr 16 2021, 6:40 AM · Restricted Project

Apr 15 2021

Paul-C-Anagnostopoulos added a comment to D99751: Add the TableGen assert statement, step 3.

Thanks! I will start a thread on llvm dev about how the union issue.

Apr 15 2021, 9:16 AM · Restricted Project
Paul-C-Anagnostopoulos committed rG9345f9fa5d64: [TableGen] [docs] Correct a reference in the TableGen Overview document (authored by Paul-C-Anagnostopoulos).
[TableGen] [docs] Correct a reference in the TableGen Overview document
Apr 15 2021, 6:27 AM
Paul-C-Anagnostopoulos closed D100382: [TableGen] [docs] Correct a reference in the TableGen Overview.
Apr 15 2021, 6:27 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D99751: Add the TableGen assert statement, step 3.

I like your improvements, I just want to do the first one last. It's easier for me to get all the assert-related code in and working, then go back and replace the tuple with a struct when all the relevant code is in one branch. I promise to do it and not just forget about it. It's next on my to-do list.

Apr 15 2021, 5:49 AM · Restricted Project

Apr 14 2021

Paul-C-Anagnostopoulos added a comment to D99751: Add the TableGen assert statement, step 3.

In order to use a union in the RecordsEntry struct, I will have to add an enumerated value that specifies which kind of pointer is in the union. Is that worth the bother? Especially since I believe I'll have to write a special destructor.

Apr 14 2021, 8:04 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D99751: Add the TableGen assert statement, step 3.

Could I do the union as a prep patch, but please delay the change to a struct for a subsequent patch? This code is an extension to the previous steps that use a tuple. It's easier to think about the change to a struct as a separate patch.

Apr 14 2021, 7:01 AM · Restricted Project

Apr 13 2021

Paul-C-Anagnostopoulos added a comment to D99751: Add the TableGen assert statement, step 3.

Could I get an LGTM on this revision?

Apr 13 2021, 8:38 AM · Restricted Project
Paul-C-Anagnostopoulos requested review of D100382: [TableGen] [docs] Correct a reference in the TableGen Overview.
Apr 13 2021, 6:40 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D100253: [TableGen] Resolve concrete but not complete field access initializers.

Go for it!

Apr 13 2021, 6:29 AM · Restricted Project

Apr 12 2021

Paul-C-Anagnostopoulos accepted D100253: [TableGen] Resolve concrete but not complete field access initializers.
Apr 12 2021, 6:47 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D100253: [TableGen] Resolve concrete but not complete field access initializers.

Oh, and LGTM.

Apr 12 2021, 6:47 AM · Restricted Project
Paul-C-Anagnostopoulos added a comment to D100253: [TableGen] Resolve concrete but not complete field access initializers.

I just pushed my bug fix. Let's wait a day until I know it doesn't bust the build, then push this one.

Apr 12 2021, 6:47 AM · Restricted Project