Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

[RISCV] Use binary search on the extension tables in RISCVISAInfo.cpp. NFC
ClosedPublic
Actions

Authored by craig.topper on Jun 22 2023, 4:45 PM.

Details

Reviewers

jrtc27
asb
reames
MaskRay

Commits

rGf2d16b368fcd: [RISCV] Use binary search on the extension tables in RISCVISAInfo.cpp. NFC

Summary

The tables are now sorted by extension name so we can use that to
avoid a linear search.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

craig.topper created this revision.Jun 22 2023, 4:45 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2023, 4:45 PM

Herald added subscribers: jobnoorman, luke, VincentWu and 26 others. · View Herald Transcript

craig.topper requested review of this revision.Jun 22 2023, 4:45 PM

Herald added a project: Restricted Project. · View Herald TranscriptJun 22 2023, 4:45 PM

Herald added subscribers: wangpc, eopXD, MaskRay. · View Herald Transcript

Harbormaster completed remote builds in B240659: Diff 533816.Jun 22 2023, 5:42 PM

LGTM

This revision is now accepted and ready to land.Jun 23 2023, 6:10 AM

@asb I think you committed this as part of D151663?

Consider linking to D153170 in the summary.

Closed by commit rGf2d16b368fcd: [RISCV] Use binary search on the extension tables in RISCVISAInfo.cpp. NFC (authored by craig.topper). · Explain WhyJun 23 2023, 5:23 PM

This revision was automatically updated to reflect the committed changes.

craig.topper added a commit: rGf2d16b368fcd: [RISCV] Use binary search on the extension tables in RISCVISAInfo.cpp. NFC.

craig.topper mentioned this in rG076759f068c8: Revert "[RISCV] Implement support for bf16 truncate/extend on hard FP targets".

craig.topper mentioned this in rG929124993a58: Recommit "[RISCV] Implement support for bf16 truncate/extend on hard FP targets".

In D153598#4444640, @craig.topper wrote:

@asb I think you committed this as part of D151663?

Sorry, accidentally committed a dirty tree. Thanks for reverting and cleaning up.

Revision Contents
Changeset List

Path

Size

llvm/

lib/

Support/

RISCVISAInfo.cpp

69 lines

Diff 534132

View Options

llvm/lib/Support/RISCVISAInfo.cpp