This is an archive of the discontinued LLVM Phabricator instance.

Differential D152186

[Clang] Add release note for 877210faa447
ClosedPublic

Authored by nathanchance on Jun 5 2023, 11:46 AM.

Details

Reviewers
erichkeane
nickdesaulniers
Commits
rGdeecf89a1361: [Clang] Add release note for 877210faa447

Diff Detail

Event Timeline

nathanchance created this revision.Jun 5 2023, 11:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 11:46 AM
nathanchance requested review of this revision.Jun 5 2023, 11:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 5 2023, 11:46 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
nickdesaulniers accepted this revision.Jun 5 2023, 12:09 PM

Thanks for the patch!

This revision is now accepted and ready to land.Jun 5 2023, 12:09 PM
erichkeane accepted this revision.Jun 5 2023, 12:10 PM

2 nits, otherwise LGTM! Thanks!

clang/docs/ReleaseNotes.rst
333
334
This revision was landed with ongoing or failed builds.Jun 5 2023, 12:15 PM
Closed by commit rGdeecf89a1361: [Clang] Add release note for 877210faa447 (authored by nathanchance). · Explain Why
This revision was automatically updated to reflect the committed changes.
nathanchance added a commit: rGdeecf89a1361: [Clang] Add release note for 877210faa447.
nathanchance added a comment.Jun 5 2023, 12:15 PM

Thanks, I landed it with those nits addressed.

Harbormaster completed remote builds in B236701: Diff 528534.Jun 5 2023, 3:26 PM

Revision Contents

PathSize
clang/
docs/
2 lines

Diff 528534

clang/docs/ReleaseNotes.rst

Show First 20 Lines • Show All 324 Lines • ▼ Show 20 Lines- Clang now correctly diagnoses when the argument to ``alignas`` or ``_Alignas``
is an incomplete type. is an incomplete type.
(`#55175: <https://github.com/llvm/llvm-project/issues/55175>`_, and fixes an (`#55175: <https://github.com/llvm/llvm-project/issues/55175>`_, and fixes an
incorrect mention of ``alignof`` in a diagnostic about ``alignas``). incorrect mention of ``alignof`` in a diagnostic about ``alignas``).
- Clang will now show a margin with line numbers to the left of each line - Clang will now show a margin with line numbers to the left of each line
of code it prints for diagnostics. This can be disabled using of code it prints for diagnostics. This can be disabled using
``-fno-diagnostics-show-line-numbers``. At the same time, the maximum ``-fno-diagnostics-show-line-numbers``. At the same time, the maximum
number of code lines it prints has been increased from 1 to 16. This number of code lines it prints has been increased from 1 to 16. This
can be controlled using ``-fcaret-diagnostics-max-lines=``. can be controlled using ``-fcaret-diagnostics-max-lines=``.
- Clang no longer emits ``-Wunused-variable`` for variables declared with
erichkeaneUnsubmitted
Not Done
ReplyInline Actions
can be controlled using ``-fcaret-diagnostics-max-lines=``.
- - Clang no longer emits ``-Wunused-variable`` for variables declared with
+ - Clang no longer emits ``-Wunused-variable`` warnings for variables declared with
``__attribute__((cleanup(...)))`` to match GCC.
erichkeane:
``__attribute__((cleanup(...)))`` to match GCC.
erichkeaneUnsubmitted
Not Done
ReplyInline Actions
- Clang no longer emits ``-Wunused-variable`` for variables declared with
- ``__attribute__((cleanup(...)))`` to match GCC.
+ ``__attribute__((cleanup(...)))`` to match GCC's behavior.
Bug Fixes in This Version
erichkeane:
Bug Fixes in This Version Bug Fixes in This Version
------------------------- -------------------------
- Fix segfault while running clang-rename on a non existing file. - Fix segfault while running clang-rename on a non existing file.
(`#36471 <https://github.com/llvm/llvm-project/issues/36471>`_) (`#36471 <https://github.com/llvm/llvm-project/issues/36471>`_)
- Fix crash when diagnosing incorrect usage of ``_Nullable`` involving alias - Fix crash when diagnosing incorrect usage of ``_Nullable`` involving alias
templates. templates.
▲ Show 20 Lines • Show All 393 Lines • Show Last 20 Lines