This is an archive of the discontinued LLVM Phabricator instance.

Differential D151526

coach UpdateTestChecks to filter out certain symbol aliases for m68k
ClosedPublic

Authored by 0x59616e on May 25 2023, 7:32 PM.

Details

Reviewers
jrtc27
RKSimon
myhsu
Commits
rG2f62803ea458: coach UpdateTestChecks to filter out certain symbol aliases for m68k
Summary

This patch coaches UpdateTestChecks to filter out these symbol aliases in llc test for m68k

  • .L<function name>$local:
  • .type .L<function name>$local,@function

Diff Detail

Event Timeline

0x59616e created this revision.May 25 2023, 7:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 7:32 PM
Herald added a subscriber: arichardson. · View Herald Transcript
0x59616e requested review of this revision.May 25 2023, 7:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 25 2023, 7:32 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
0x59616e added a child revision: D144941: [m68k] Add TLS Support.May 25 2023, 7:32 PM
Harbormaster completed remote builds in B234743: Diff 525914.May 25 2023, 7:32 PM
0x59616e planned changes to this revision.May 25 2023, 7:36 PM
0x59616e updated this revision to Diff 525919.May 25 2023, 7:46 PM

rebase

Harbormaster completed remote builds in B234747: Diff 525919.May 25 2023, 8:24 PM
myhsu accepted this revision.May 25 2023, 9:11 PM

nit: This is not part of LIT but UTC (update test check), please update the title (and don't leave the commit message empty).
Also I believe those are not debug directives but symbol aliases: http://maskray.me/blog/2021-05-09-fno-semantic-interposition

Otherwise the patch looks reasonable to me, thanks!

This revision is now accepted and ready to land.May 25 2023, 9:11 PM
0x59616e retitled this revision from [lit] coach lit to filter out certain m68k debug directive to coach UpdateTestChecks to filter out certain symbol aliases for m68k.May 25 2023, 9:17 PM
0x59616e edited the summary of this revision. (Show Details)
Herald added subscribers: luismarques, jeroen.dobbelaere. · View Herald TranscriptMay 25 2023, 9:17 PM
0x59616e edited the summary of this revision. (Show Details)May 25 2023, 9:19 PM
glaubitz added a subscriber: glaubitz.May 27 2023, 4:27 PM
Closed by commit rG2f62803ea458: coach UpdateTestChecks to filter out certain symbol aliases for m68k (authored by 0x59616e). · Explain WhyJun 3 2023, 4:10 AM
This revision was automatically updated to reflect the committed changes.
0x59616e added a commit: rG2f62803ea458: coach UpdateTestChecks to filter out certain symbol aliases for m68k.

Revision Contents

PathSize
llvm/
utils/
UpdateTestChecks/
9 lines

Diff 528090

llvm/utils/UpdateTestChecks/asm.py

Show First 20 Lines • Show All 65 Lines • ▼ Show 20 LinesASM_FUNCTION_HEXAGON_RE = re.compile(
r"(?P<body>.*?)\n" # (body of the function) r"(?P<body>.*?)\n" # (body of the function)
# This list is incomplete # This list is incomplete
r".Lfunc_end[0-9]+:\n", r".Lfunc_end[0-9]+:\n",
flags=(re.M | re.S), flags=(re.M | re.S),
) )
ASM_FUNCTION_M68K_RE = re.compile( ASM_FUNCTION_M68K_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]*;[ \t]*@"?(?P=func)"?\n' r'^_?(?P<func>[^:]+):[ \t]*;[ \t]*@"?(?P=func)"?\n'
r"(?P<body>.*?)\s*" # (body of the function) r'(?:\.L(?P=func)\$local:\n)?' # drop .L<func>$local:
r".Lfunc_end[0-9]+:\n", r'(?:[ \t]+\.type[ \t]+\.L(?P=func)\$local,@function\n)?' # drop .type .L<func>$local,@function
flags=(re.M | re.S), r'(?P<body>.*?)\s*' # (body of the function)
) r'.Lfunc_end[0-9]+:\n',
flags=(re.M | re.S))
ASM_FUNCTION_MIPS_RE = re.compile( ASM_FUNCTION_MIPS_RE = re.compile(
r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@"?(?P=func)"?\n[^:]*?' # f: (name of func) r'^_?(?P<func>[^:]+):[ \t]*#+[ \t]*@"?(?P=func)"?\n[^:]*?' # f: (name of func)
r"(?:\s*\.?Ltmp[^:\n]*:\n)?[^:]*?" # optional .Ltmp<N> for EH r"(?:\s*\.?Ltmp[^:\n]*:\n)?[^:]*?" # optional .Ltmp<N> for EH
r"(?:^[ \t]+\.(frame|f?mask|set).*?\n)+" # Mips+LLVM standard asm prologue r"(?:^[ \t]+\.(frame|f?mask|set).*?\n)+" # Mips+LLVM standard asm prologue
r"(?P<body>.*?)\n" # (body of the function) r"(?P<body>.*?)\n" # (body of the function)
# Mips+LLVM standard asm epilogue # Mips+LLVM standard asm epilogue
r"(?:(^[ \t]+\.set[^\n]*?\n)*^[ \t]+\.end.*?\n)" r"(?:(^[ \t]+\.set[^\n]*?\n)*^[ \t]+\.end.*?\n)"
▲ Show 20 Lines • Show All 512 Lines • Show Last 20 Lines