- User Since
- Nov 15 2021, 11:20 PM (26 w, 2 d)
Fix failed test
Didn't notice some test were failed.
Mon, May 16
Sun, May 15
That's expected. I'll open an issue for it later this day.
@myhsu this file has dependency on MCFixedLenDisassembler.h, but I'm not quite sure whether we should take care of it, given that I did not encounter any failure during building and testing. What's your opinion ?
update diff trying to fix buildbot failure
Sat, May 14
- define our own castFailed in the hope of fixing the build failure of clang.
- add static_assert for type check
It seems that people are not always using a plain pointer in PointerUnion. Sometimes they seem to use a custom smart pointer ?
- public inheritance for ConstStrippingForwardingCast
- Add test case for const
- Add some comments.
I used arc incorrectly. Re-update the diff.
Thanks for feedback ;)
I can only come up with this :
Didn't notice the build failure. Remove the CastInfoPointerUnionImpl and revert
back to the original implementation.
Given that I'm still young to C++ and llvm, every suggestion, even the
one you feel it's trivial, are very welcomed ;)
Thanks ! Appreciate your help ;)
Wed, May 11
Mon, May 9
The comment is updated :
Thu, May 5
fix the include guard
I've commited a diff in the hope of fixing this problem:
change the header guard
Wed, May 4
Tue, May 3
Mon, May 2
- use llvm::alignTo
- construct APInt directly with constructor instead of assignment copy constructor
Mon, Apr 25
ping. Any more suggestions ?
Apr 17 2022
continue addressing formating issues
Revert the TODO suggested my myhsu
address format issue
Apr 10 2022
Apr 9 2022
I could not remember whether I've modified this patch recently.
I know what is going on.
I've noticed the clang-format problem. The weird thing is, It happened after I rename this file, before I change anything in it. That makes me confusing. It should have not happened because I only change the file name.
Rename the class name.
Apr 5 2022
Apr 3 2022
Should we rename after this patch ? or before this patch ?
Mar 31 2022
Mar 30 2022
move test into another file
address some feedbacks
Mar 25 2022
Remove tablegen variable isVarLenInst. It's useless
fix a minor problem
Mar 24 2022
Mar 21 2022
Mar 15 2022
Mar 10 2022
Mar 3 2022
Fix a minor problem in the test