This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] Renaming the STEA field `dimLevelType` to `lvlTypes`
ClosedPublic

Authored by wrengr on May 10 2023, 4:43 PM.

Details

Summary

This commit is part of the migration of towards the new STEA syntax/design. In particular, this commit includes the following changes:

  • Renaming compiler-internal functions/methods:
    • SparseTensorEncodingAttr::{getDimLevelType => getLvlTypes}
    • Merger::{getDimLevelType => getLvlType} (for consistency)
    • sparse_tensor::{getDimLevelType => buildLevelType} (to help reduce confusion vs actual getter methods)
  • Renaming external facets to match:
    • the STEA parser and printer
    • the C and Python bindings
    • PyTACO

However, the actual renaming of the DimLevelType itself (along with all the "dlt" names) will be handled in a separate commit.

Diff Detail

Event Timeline

wrengr created this revision.May 10 2023, 4:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 10 2023, 4:43 PM
wrengr requested review of this revision.May 10 2023, 4:43 PM
wrengr updated this revision to Diff 521159.May 10 2023, 4:46 PM

git-clang-format

aartbik accepted this revision.May 10 2023, 4:53 PM
This revision is now accepted and ready to land.May 10 2023, 4:53 PM
wrengr edited the summary of this revision. (Show Details)May 11 2023, 3:48 PM
wrengr updated this revision to Diff 521483.May 11 2023, 3:48 PM
wrengr edited the summary of this revision. (Show Details)

Updating the parser, printer, CAPI, and Python bindings

wrengr updated this revision to Diff 521484.May 11 2023, 3:49 PM

git-clang-format

wrengr edited the summary of this revision. (Show Details)May 11 2023, 3:50 PM

Still LGTM although
(1) please update the summary to reflect the wider scope of this change
(2) I think you need a follow up in e.g. SparseTensorOps.td to update the exampes

This revision was landed with ongoing or failed builds.May 17 2023, 2:24 PM
This revision was automatically updated to reflect the committed changes.

Note: D150409 detected a failure to rename things in "test/Dialect/SparseTensor/GPU/gpu_matvec_lib.mlir" since the rebasing. However, since this differential already landed, I've made the change in D150409

Actually it looks like a bunch of GPU tests weren't caught when rebasing. I'm working on a patch to fix those now.

D150822 should fix all the failing GPU tests

And D150830 should fix what D150822 missed