Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D150082

[mlir] Move value name shadowing functionality into OpAsmOpInterface
Needs ReviewPublic
Actions

Authored by rkayaith on May 7 2023, 6:48 PM.

Details

Reviewers
rriddle
nicolasvasilache
Summary

The OpAsmPrinter::shadowRegionArgs API is problematic as it allows
value ids to be changed by custom op printers, making it impossible to
know the ID of a particular value without printing ops. Moving the
shadowing functionality to OpAsmOpInterface allows the final value IDs
to be determined during AsmState construction.

depends on D150080

Diff Detail

Event Timeline

rkayaith created this revision.May 7 2023, 6:48 PM
Herald added a reviewer: rriddle. · View Herald TranscriptMay 7 2023, 6:48 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: bviyer, Moerafaat, zero9178 and 21 others. · View Herald Transcript
Harbormaster completed remote builds in B230531: Diff 520236.May 7 2023, 7:15 PM
rkayaith published this revision for review.May 7 2023, 7:47 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMay 7 2023, 7:47 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rkayaith added a comment.May 18 2023, 4:08 PM

friendly ping

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
IR/
27 lines
13 lines
lib/
IR/
75 lines
test/
lib/
Dialect/
Test/
6 lines
4 lines

Diff 520236

View Options

mlir/include/mlir/IR/OpAsmInterface.td

Loading...
View Options

mlir/include/mlir/IR/OpImplementation.h

Loading...
View Options

mlir/lib/IR/AsmPrinter.cpp

Loading...
View Options

mlir/test/lib/Dialect/Test/TestDialect.cpp

Loading...
View Options

mlir/test/lib/Dialect/Test/TestOps.td

Loading...