Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D150080

[mlir][TestDialect] Fix invalid custom op printers
ClosedPublic
Actions

Authored by rkayaith on May 7 2023, 5:55 PM.

Details

Reviewers
rriddle
nicolasvasilache
Commits
rGb89b3cdb612f: [mlir][TestDialect] Fix invalid custom op printers
Summary

This fixes a few custom printers which were printing IR that couldn't be
round-tripped.

Diff Detail

Event Timeline

rkayaith created this revision.May 7 2023, 5:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 7 2023, 5:55 PM
Herald added subscribers: bviyer, Moerafaat, zero9178 and 21 others. · View Herald Transcript
Harbormaster completed remote builds in B230526: Diff 520230.May 7 2023, 6:09 PM
rkayaith added a child revision: D150082: [mlir] Move value name shadowing functionality into OpAsmOpInterface.May 7 2023, 6:48 PM
rkayaith published this revision for review.May 7 2023, 7:47 PM
rkayaith added a reviewer: rriddle.
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMay 7 2023, 7:47 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
rriddle accepted this revision.Jun 9 2023, 11:15 AM
This revision is now accepted and ready to land.Jun 9 2023, 11:15 AM
Closed by commit rGb89b3cdb612f: [mlir][TestDialect] Fix invalid custom op printers (authored by rkayaith). · Explain WhyJul 4 2023, 8:29 PM
This revision was automatically updated to reflect the committed changes.
rkayaith added a commit: rGb89b3cdb612f: [mlir][TestDialect] Fix invalid custom op printers.

Revision Contents
Changeset List

PathSize
mlir/
test/
IR/
13 lines
6 lines
lib/
Dialect/
Test/
17 lines

Diff 537206

View Options

mlir/test/IR/parser.mlir

Loading...
View Options

mlir/test/IR/pretty-region-args.mlir

Loading...
View Options

mlir/test/lib/Dialect/Test/TestDialect.cpp

Loading...