Page MenuHomePhabricator

rkayaith (Rahul Kayaith)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 17 2021, 8:23 PM (59 w, 5 d)

Recent Activity

Thu, Nov 10

rkayaith added inline comments to D137731: [mlir][Pass] Make PassManager default to op-agnostic.
Thu, Nov 10, 8:57 AM · Restricted Project, Restricted Project, Restricted Project
rkayaith updated the diff for D137731: [mlir][Pass] Make PassManager default to op-agnostic.

add PassManagerOn class

Thu, Nov 10, 8:54 AM · Restricted Project, Restricted Project, Restricted Project

Nov 9 2022

rkayaith published D137731: [mlir][Pass] Make PassManager default to op-agnostic for review.
Nov 9 2022, 2:41 PM · Restricted Project, Restricted Project, Restricted Project

Nov 8 2022

rkayaith committed rGb0bbc9b5951e: [mlir][NVGPU] Fix -Wunsequenced warning (authored by rkayaith).
[mlir][NVGPU] Fix -Wunsequenced warning
Nov 8 2022, 12:48 PM · Restricted Project, Restricted Project
rkayaith committed rG40e7741d2db0: [mlir-opt] Add '-p' as an alias for '-pass-pipeline' (authored by rkayaith).
[mlir-opt] Add '-p' as an alias for '-pass-pipeline'
Nov 8 2022, 12:19 PM · Restricted Project, Restricted Project
rkayaith closed D137347: [mlir-opt] Add '-p' as an alias for '-pass-pipeline'.
Nov 8 2022, 12:19 PM · Restricted Project, Restricted Project
rkayaith committed rGe4889c0a046e: [mlir][spirv] Change translation to use spirv.module (authored by rkayaith).
[mlir][spirv] Change translation to use spirv.module
Nov 8 2022, 11:47 AM · Restricted Project, Restricted Project
rkayaith closed D135819: [mlir][spirv] Change translation to use spirv.module.
Nov 8 2022, 11:47 AM · Restricted Project, Restricted Project

Nov 4 2022

rkayaith committed rGdd1b1d445032: [mlir][python] Allow adding to existing pass manager (authored by rkayaith).
[mlir][python] Allow adding to existing pass manager
Nov 4 2022, 9:04 AM · Restricted Project, Restricted Project
rkayaith closed D137344: [mlir][python] Allow adding to existing pass manager.
Nov 4 2022, 9:04 AM · Restricted Project, Restricted Project

Nov 3 2022

rkayaith published D135819: [mlir][spirv] Change translation to use spirv.module for review.
Nov 3 2022, 7:22 PM · Restricted Project, Restricted Project
rkayaith added a comment to D137347: [mlir-opt] Add '-p' as an alias for '-pass-pipeline'.

The alias name is now an argument to the PassPipelineCLParser constructor so users can configure it, and it's now opt-in so this no longer affects other PassPipelineCLParser users

Nov 3 2022, 2:57 PM · Restricted Project, Restricted Project
rkayaith updated the diff for D137347: [mlir-opt] Add '-p' as an alias for '-pass-pipeline'.
  • slightly different approach
Nov 3 2022, 2:54 PM · Restricted Project, Restricted Project
rkayaith added a comment to D137347: [mlir-opt] Add '-p' as an alias for '-pass-pipeline'.

I'm not sure about this: isn't there a high risk of conflicts with another CL option named -p?

Nov 3 2022, 12:35 PM · Restricted Project, Restricted Project
rkayaith published D137347: [mlir-opt] Add '-p' as an alias for '-pass-pipeline' for review.
Nov 3 2022, 12:26 PM · Restricted Project, Restricted Project
rkayaith requested review of D137344: [mlir][python] Allow adding to existing pass manager.
Nov 3 2022, 10:44 AM · Restricted Project, Restricted Project
rkayaith committed rGd97e8cd48239: [mlir][python] Include anchor op in PassManager constructor (authored by rkayaith).
[mlir][python] Include anchor op in PassManager constructor
Nov 3 2022, 8:52 AM · Restricted Project, Restricted Project
rkayaith closed D136406: [mlir][python] Include anchor op in PassManager constructor.
Nov 3 2022, 8:52 AM · Restricted Project, Restricted Project
rkayaith committed rG66645a03fc8a: [mlir][python] Include anchor op in PassManager.parse (authored by rkayaith).
[mlir][python] Include anchor op in PassManager.parse
Nov 3 2022, 8:50 AM · Restricted Project, Restricted Project
rkayaith closed D136405: [mlir][python] Include anchor op in PassManager.parse.
Nov 3 2022, 8:50 AM · Restricted Project, Restricted Project
rkayaith committed rG215eba4e1ea2: [mlir][CAPI] Include anchor op in mlirParsePassPipeline (authored by rkayaith).
[mlir][CAPI] Include anchor op in mlirParsePassPipeline
Nov 3 2022, 8:48 AM · Restricted Project, Restricted Project
rkayaith closed D136403: [mlir][CAPI] Include anchor op in mlirParsePassPipeline.
Nov 3 2022, 8:48 AM · Restricted Project, Restricted Project
rkayaith committed rGd511a5d47166: [mlir] Include anchor op in reproducer pipeline string (authored by rkayaith).
[mlir] Include anchor op in reproducer pipeline string
Nov 3 2022, 8:45 AM · Restricted Project, Restricted Project
rkayaith closed D134623: [mlir] Include anchor op in reproducer pipeline string.
Nov 3 2022, 8:45 AM · Restricted Project, Restricted Project
rkayaith committed rG13bd41096286: [mlir][Pass] Include anchor op in -pass-pipeline (authored by rkayaith).
[mlir][Pass] Include anchor op in -pass-pipeline
Nov 3 2022, 8:37 AM · Restricted Project, Restricted Project, Restricted Project
rkayaith closed D134900: [mlir][Pass] Include anchor op in -pass-pipeline.
Nov 3 2022, 8:36 AM · Restricted Project, Restricted Project, Restricted Project

Nov 2 2022

rkayaith added inline comments to D135745: [mlir][Pass] Disallow mixing -pass-pipeline with other pass options.
Nov 2 2022, 12:16 PM · Restricted Project, Restricted Project
rkayaith committed rG69112d0d2dc1: [mlir][arith] Use declarative asm format for fastmath flags (authored by rkayaith).
[mlir][arith] Use declarative asm format for fastmath flags
Nov 2 2022, 9:52 AM · Restricted Project, Restricted Project
rkayaith closed D137087: [mlir][arith] Use declarative asm format for fastmath flags.
Nov 2 2022, 9:51 AM · Restricted Project, Restricted Project
rkayaith added a reviewer for D137087: [mlir][arith] Use declarative asm format for fastmath flags: vzakhari.
Nov 2 2022, 9:23 AM · Restricted Project, Restricted Project
rkayaith committed rG0c36a1569a06: [mlir][Pass] Disallow mixing -pass-pipeline with other pass options (authored by rkayaith).
[mlir][Pass] Disallow mixing -pass-pipeline with other pass options
Nov 2 2022, 9:17 AM · Restricted Project, Restricted Project
rkayaith closed D135745: [mlir][Pass] Disallow mixing -pass-pipeline with other pass options.
Nov 2 2022, 9:17 AM · Restricted Project, Restricted Project
rkayaith committed rG1c0f541a4d1d: [mlir] Don't mix -pass-pipeline with other pass options (authored by rkayaith).
[mlir] Don't mix -pass-pipeline with other pass options
Nov 2 2022, 9:14 AM · Restricted Project, Restricted Project
rkayaith closed D135746: [mlir] Don't mix -pass-pipeline with other pass options.
Nov 2 2022, 9:14 AM · Restricted Project, Restricted Project

Nov 1 2022

rkayaith added reviewers for D137118: [YAML] Trim trailing whitespace from plain scalars: scott.linder, HassanElDesouky.

Adding reviewers based on recent commits

Nov 1 2022, 8:01 AM · Restricted Project, Restricted Project
rkayaith updated the diff for D137118: [YAML] Trim trailing whitespace from plain scalars.

update summary

Nov 1 2022, 7:56 AM · Restricted Project, Restricted Project

Oct 31 2022

rkayaith published D137118: [YAML] Trim trailing whitespace from plain scalars for review.
Oct 31 2022, 7:14 PM · Restricted Project, Restricted Project
rkayaith requested review of D137087: [mlir][arith] Use declarative asm format for fastmath flags.
Oct 31 2022, 9:58 AM · Restricted Project, Restricted Project
rkayaith committed rGe44a3c3d7f7d: [mlir][doc] Update op optional-group asm format doc (authored by rkayaith).
[mlir][doc] Update op optional-group asm format doc
Oct 31 2022, 7:35 AM · Restricted Project, Restricted Project
rkayaith closed D136987: [mlir][doc] Update op optional-group asm format doc.
Oct 31 2022, 7:35 AM · Restricted Project, Restricted Project

Oct 28 2022

rkayaith published D136987: [mlir][doc] Update op optional-group asm format doc for review.
Oct 28 2022, 2:34 PM · Restricted Project, Restricted Project

Oct 27 2022

rkayaith added inline comments to D126305: [mlir][arith] Initial support for fastmath flag attributes in the Arithmetic dialect (v2).
Oct 27 2022, 3:53 PM · Restricted Project, Restricted Project
rkayaith committed rGf9f708ef4123: [mlir][CAPI] Allow specifying pass manager anchor (authored by rkayaith).
[mlir][CAPI] Allow specifying pass manager anchor
Oct 27 2022, 10:32 AM · Restricted Project, Restricted Project
rkayaith closed D136404: [mlir][CAPI] Allow specifying pass manager anchor.
Oct 27 2022, 10:32 AM · Restricted Project, Restricted Project
rkayaith committed rGb3c5f6b15b1e: [mlir][python] Include pipeline parse errors in exception message (authored by rkayaith).
[mlir][python] Include pipeline parse errors in exception message
Oct 27 2022, 10:05 AM · Restricted Project, Restricted Project
rkayaith closed D136402: [mlir][python] Include pipeline parse errors in exception message.
Oct 27 2022, 10:05 AM · Restricted Project, Restricted Project
rkayaith added a comment to D135745: [mlir][Pass] Disallow mixing -pass-pipeline with other pass options.

@rriddle could you take another look at this? it's the last patch in the stack that needs review

Oct 27 2022, 9:57 AM · Restricted Project, Restricted Project
rkayaith updated the diff for D134900: [mlir][Pass] Include anchor op in -pass-pipeline.

rebase

Oct 27 2022, 9:55 AM · Restricted Project, Restricted Project, Restricted Project
rkayaith updated the diff for D135746: [mlir] Don't mix -pass-pipeline with other pass options.

rebase

Oct 27 2022, 9:52 AM · Restricted Project, Restricted Project

Oct 26 2022

rkayaith added a comment to D134237: [mlir-translate] Support parsing operations other than 'builtin.module' as top-level.

The bot is broken, are you on it already? https://lab.llvm.org/buildbot/#/builders/61/builds/34355

Oct 26 2022, 3:45 PM · Restricted Project, Restricted Project
rkayaith added inline comments to D126305: [mlir][arith] Initial support for fastmath flag attributes in the Arithmetic dialect (v2).
Oct 26 2022, 2:03 PM · Restricted Project, Restricted Project
rkayaith updated the diff for D136406: [mlir][python] Include anchor op in PassManager constructor.

rebase

Oct 26 2022, 1:53 PM · Restricted Project, Restricted Project
rkayaith updated the diff for D136405: [mlir][python] Include anchor op in PassManager.parse.

rebase

Oct 26 2022, 1:52 PM · Restricted Project, Restricted Project
rkayaith updated the diff for D136404: [mlir][CAPI] Allow specifying pass manager anchor.

create new function, mlirPassManagerCreateOnOperation, instead of changing the existing one

Oct 26 2022, 1:49 PM · Restricted Project, Restricted Project
rkayaith updated the diff for D136403: [mlir][CAPI] Include anchor op in mlirParsePassPipeline.

add test for error capture

Oct 26 2022, 1:09 PM · Restricted Project, Restricted Project
rkayaith updated the diff for D136402: [mlir][python] Include pipeline parse errors in exception message.

add capi test for error capture, rebase

Oct 26 2022, 1:07 PM · Restricted Project, Restricted Project

Oct 24 2022

rkayaith added a comment to D136404: [mlir][CAPI] Allow specifying pass manager anchor.

I could rename it to something like mlirPassManagerCreateWithAnchor but it's a bit unfortunate, mlirPassManagerCreate feels like the "right" name. Or maybe there should be both: mlirPassManagerCreate which uses the default anchor (builtin.module for now, but should probably be changed to any) and mlirPassManagerCreateWithAnchor with the anchor argument?

Oct 24 2022, 9:14 PM · Restricted Project, Restricted Project
rkayaith added inline comments to D136403: [mlir][CAPI] Include anchor op in mlirParsePassPipeline.
Oct 24 2022, 6:04 PM · Restricted Project, Restricted Project
rkayaith published D136406: [mlir][python] Include anchor op in PassManager constructor for review.
Oct 24 2022, 11:51 AM · Restricted Project, Restricted Project
rkayaith published D136405: [mlir][python] Include anchor op in PassManager.parse for review.
Oct 24 2022, 11:50 AM · Restricted Project, Restricted Project
rkayaith added reviewers for D136404: [mlir][CAPI] Allow specifying pass manager anchor: stellaraccident, ftynse.
Oct 24 2022, 11:49 AM · Restricted Project, Restricted Project
rkayaith added reviewers for D136403: [mlir][CAPI] Include anchor op in mlirParsePassPipeline: stellaraccident, ftynse.
Oct 24 2022, 11:47 AM · Restricted Project, Restricted Project
rkayaith added reviewers for D136402: [mlir][python] Include pipeline parse errors in exception message: stellaraccident, ftynse.
Oct 24 2022, 11:45 AM · Restricted Project, Restricted Project
rkayaith committed rGd30727fb6c15: [mlir][Translation] Make commandline option registration optional (authored by rkayaith).
[mlir][Translation] Make commandline option registration optional
Oct 24 2022, 11:40 AM · Restricted Project, Restricted Project
rkayaith closed D136561: [mlir][Translation] Make commandline option registration optional.
Oct 24 2022, 11:40 AM · Restricted Project, Restricted Project
rkayaith updated the diff for D136561: [mlir][Translation] Make commandline option registration optional.

rebase, avoid construction options

Oct 24 2022, 10:19 AM · Restricted Project, Restricted Project
rkayaith added inline comments to D136561: [mlir][Translation] Make commandline option registration optional.
Oct 24 2022, 9:30 AM · Restricted Project, Restricted Project

Oct 23 2022

rkayaith added inline comments to D134237: [mlir-translate] Support parsing operations other than 'builtin.module' as top-level.
Oct 23 2022, 12:44 PM · Restricted Project, Restricted Project
rkayaith requested review of D136561: [mlir][Translation] Make commandline option registration optional.
Oct 23 2022, 12:43 PM · Restricted Project, Restricted Project

Oct 21 2022

rkayaith committed rGed90f8026e45: [mlir-translate] Support parsing operations other than 'builtin.module' as top… (authored by rkayaith).
[mlir-translate] Support parsing operations other than 'builtin.module' as top…
Oct 21 2022, 12:54 PM · Restricted Project, Restricted Project
rkayaith closed D134237: [mlir-translate] Support parsing operations other than 'builtin.module' as top-level.
Oct 21 2022, 12:54 PM · Restricted Project, Restricted Project
rkayaith committed rG86723787474e: [mlir] Add conversion function from OwningOpRef<T> to OwningOpRef<Operation *> (authored by rkayaith).
[mlir] Add conversion function from OwningOpRef<T> to OwningOpRef<Operation *>
Oct 21 2022, 12:52 PM · Restricted Project, Restricted Project
rkayaith closed D136480: [mlir] Add conversion function from OwningOpRef<T> to OwningOpRef<Operation *>.
Oct 21 2022, 12:52 PM · Restricted Project, Restricted Project
rkayaith updated the diff for D134237: [mlir-translate] Support parsing operations other than 'builtin.module' as top-level.

update description, use OwningOpRef conversion, address comment

Oct 21 2022, 12:34 PM · Restricted Project, Restricted Project
rkayaith requested review of D136480: [mlir] Add conversion function from OwningOpRef<T> to OwningOpRef<Operation *>.
Oct 21 2022, 11:53 AM · Restricted Project, Restricted Project
rkayaith committed rG037804ddb396: [mlir][Pass] Fix parsePassPipeline error stream (authored by rkayaith).
[mlir][Pass] Fix parsePassPipeline error stream
Oct 21 2022, 11:26 AM · Restricted Project, Restricted Project
rkayaith closed D136414: [mlir][Pass] Fix parsePassPipeline error stream.
Oct 21 2022, 11:26 AM · Restricted Project, Restricted Project

Oct 20 2022

rkayaith requested review of D136414: [mlir][Pass] Fix parsePassPipeline error stream.
Oct 20 2022, 7:53 PM · Restricted Project, Restricted Project
rkayaith added inline comments to D134237: [mlir-translate] Support parsing operations other than 'builtin.module' as top-level.
Oct 20 2022, 7:36 PM · Restricted Project, Restricted Project
rkayaith published D136404: [mlir][CAPI] Allow specifying pass manager anchor for review.
Oct 20 2022, 6:51 PM · Restricted Project, Restricted Project
rkayaith published D136403: [mlir][CAPI] Include anchor op in mlirParsePassPipeline for review.
Oct 20 2022, 6:49 PM · Restricted Project, Restricted Project
rkayaith published D136402: [mlir][python] Include pipeline parse errors in exception message for review.
Oct 20 2022, 6:42 PM · Restricted Project, Restricted Project
rkayaith committed rGcad61e49b28b: [mlir-opt] Add a '-dump-pass-pipeline' option (authored by rkayaith).
[mlir-opt] Add a '-dump-pass-pipeline' option
Oct 20 2022, 4:20 PM · Restricted Project, Restricted Project
rkayaith closed D135747: [mlir-opt] Add a '-dump-pass-pipeline' option.
Oct 20 2022, 4:20 PM · Restricted Project, Restricted Project
rkayaith committed rGe874bbc2925c: [mlir] Include anchor op when printing pass managers (authored by rkayaith).
[mlir] Include anchor op when printing pass managers
Oct 20 2022, 4:18 PM · Restricted Project, Restricted Project
rkayaith closed D134622: [mlir] Include anchor op when printing pass managers.
Oct 20 2022, 4:17 PM · Restricted Project, Restricted Project

Oct 19 2022

rkayaith added inline comments to D134622: [mlir] Include anchor op when printing pass managers.
Oct 19 2022, 7:13 PM · Restricted Project, Restricted Project
rkayaith added inline comments to D134622: [mlir] Include anchor op when printing pass managers.
Oct 19 2022, 6:24 PM · Restricted Project, Restricted Project

Oct 18 2022

rkayaith updated the diff for D134900: [mlir][Pass] Include anchor op in -pass-pipeline.

move mechanical test updates into a separate diff

Oct 18 2022, 2:21 PM · Restricted Project, Restricted Project, Restricted Project
rkayaith updated the diff for D134622: [mlir] Include anchor op when printing pass managers.

rebase to try and fix patch application in stack

Oct 18 2022, 12:29 PM · Restricted Project, Restricted Project

Oct 17 2022

rkayaith added inline comments to D134622: [mlir] Include anchor op when printing pass managers.
Oct 17 2022, 12:28 PM · Restricted Project, Restricted Project
rkayaith added a comment to D135745: [mlir][Pass] Disallow mixing -pass-pipeline with other pass options.

friendly ping

Oct 17 2022, 12:26 PM · Restricted Project, Restricted Project

Oct 16 2022

rkayaith committed rG7f2d9c21b49c: [mlir][ods] Support default-valued attributes in optional groups (authored by rkayaith).
[mlir][ods] Support default-valued attributes in optional groups
Oct 16 2022, 3:02 PM · Restricted Project, Restricted Project
rkayaith closed D134993: [mlir][ods] Support default-valued attributes in optional groups.
Oct 16 2022, 3:01 PM · Restricted Project, Restricted Project

Oct 14 2022

rkayaith added inline comments to D134993: [mlir][ods] Support default-valued attributes in optional groups.
Oct 14 2022, 2:58 PM · Restricted Project, Restricted Project
rkayaith updated the diff for D134993: [mlir][ods] Support default-valued attributes in optional groups.

fix default-valued symbol and enum attrs, use DefaultValuedStrAttr

Oct 14 2022, 2:57 PM · Restricted Project, Restricted Project
rkayaith added inline comments to D134993: [mlir][ods] Support default-valued attributes in optional groups.
Oct 14 2022, 12:00 PM · Restricted Project, Restricted Project
rkayaith updated the diff for D134993: [mlir][ods] Support default-valued attributes in optional groups.

preserve genCtx logic

Oct 14 2022, 11:56 AM · Restricted Project, Restricted Project

Oct 12 2022

rkayaith added inline comments to D134237: [mlir-translate] Support parsing operations other than 'builtin.module' as top-level.
Oct 12 2022, 3:24 PM · Restricted Project, Restricted Project
rkayaith updated the diff for D134237: [mlir-translate] Support parsing operations other than 'builtin.module' as top-level.

add a TranslateFromMLIRRegistration constructor that handles casting to concrete op type

Oct 12 2022, 3:24 PM · Restricted Project, Restricted Project