This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Move value name shadowing functionality into OpAsmOpInterface
Needs ReviewPublic

Authored by rkayaith on May 7 2023, 6:48 PM.



The OpAsmPrinter::shadowRegionArgs API is problematic as it allows
value ids to be changed by custom op printers, making it impossible to
know the ID of a particular value without printing ops. Moving the
shadowing functionality to OpAsmOpInterface allows the final value IDs
to be determined during AsmState construction.

depends on D150080

Diff Detail

Event Timeline

rkayaith created this revision.May 7 2023, 6:48 PM
Herald added a project: Restricted Project. · View Herald Transcript
rkayaith published this revision for review.May 7 2023, 7:47 PM

friendly ping