This is an archive of the discontinued LLVM Phabricator instance.

[clang][Sema][NFC] Move `EnterExpressionEvaluationContext` to its own file
ClosedPublic

Authored by davidstone on May 3 2023, 4:09 PM.

Details

Summary

Sema.h is huge. This makes a small reduction to it by moving EnterExpressionEvaluationContext into a new header, since it is an independent component.

Diff Detail

Event Timeline

davidstone created this revision.May 3 2023, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2023, 4:09 PM
davidstone requested review of this revision.May 3 2023, 4:09 PM
Herald added a project: Restricted Project. · View Herald TranscriptMay 3 2023, 4:09 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Sema.h is huge.

Understatement of the year. :-D

Thank you for working on this, I think it's a nice little cleanup. Just some minor nits.

clang/include/clang/Sema/EnterExpressionEvaluationContext.h
2

Comments here aren't in sync with reality.

70

Please add the newline to the end of the file.

davidstone updated this revision to Diff 519514.May 4 2023, 8:54 AM

Address review comments

aaron.ballman accepted this revision.May 4 2023, 9:37 AM

LGTM! Do you need me to commit this on your behalf? If so, what name and email address would you like me to use for patch attribution?

This revision is now accepted and ready to land.May 4 2023, 9:37 AM

LGTM! Do you need me to commit this on your behalf? If so, what name and email address would you like me to use for patch attribution?

Yes please. David Stone, davidfromonline@gmail.com

This revision was landed with ongoing or failed builds.May 4 2023, 10:08 AM
This revision was automatically updated to reflect the committed changes.