In D99134#3331259, @rsmith wrote:

Looks good. Do you need someone to land this for you?

Add unit test requested by Richard Smith

Is there anything else I need to do to help move this forward?

Ping

Take into account Richard's comments

In D69764#2058590, @rsmith wrote:

I think that if we are reordering const, we should be reordering all decl-specifiers -- I'd like to see int static constexpr unsigned const long inline reordered to something like static constexpr inline const unsigned long int too. Applying this only to const seems incomplete to me.

In D82880#2651219, @aaron.ballman wrote:

Do you need me to commit on your behalf? If so, which email address would you like me to use for attribution?

Reformatted

I believe this addresses the review comments.

The previous commit is https://github.com/llvm/llvm-project/commit/a86bc00, and I don't understand enough of what the other code is doing to know if anything else needs to be fixed. I'd also like to add in a test to ensure this doesn't regress in the future, but I'm not sure of what the best place to put the test is. From https://bugs.llvm.org/show_bug.cgi?id=48250

It looks like this change was originally added 9 years ago with a commit message of

I noticed the missing return because there is a warning (not as error) that caught it, I think the warning about falling off the end of a non-void-returning function.