Page MenuHomePhabricator

davidstone (David Stone)
User

Projects

User does not belong to any projects.

User Details

User Since
May 20 2020, 11:08 PM (105 w, 2 d)

Recent Activity

Feb 17 2022

davidstone added a comment to D99134: Lambdas are not necessarily locals. This resolves DR48250..

Looks good. Do you need someone to land this for you?

Feb 17 2022, 9:09 PM · Restricted Project
davidstone updated the diff for D99134: Lambdas are not necessarily locals. This resolves DR48250..

Add unit test requested by Richard Smith

Feb 17 2022, 10:18 AM · Restricted Project

Feb 10 2022

davidstone added reviewers for D99134: Lambdas are not necessarily locals. This resolves DR48250.: aaron.ballman, erichkeane.
Feb 10 2022, 8:07 AM · Restricted Project

Jan 18 2022

davidstone added a comment to D99134: Lambdas are not necessarily locals. This resolves DR48250..

Is there anything else I need to do to help move this forward?

Jan 18 2022, 8:23 AM · Restricted Project

Dec 16 2021

davidstone added a comment to D99134: Lambdas are not necessarily locals. This resolves DR48250..

Ping

Dec 16 2021, 8:09 AM · Restricted Project

Nov 8 2021

davidstone updated the diff for D99134: Lambdas are not necessarily locals. This resolves DR48250..

Take into account Richard's comments

Nov 8 2021, 8:20 AM · Restricted Project

Jun 2 2021

davidstone added a comment to D69764: [clang-format] Add Left/Right Const fixer capability.

I think that if we are reordering const, we should be reordering all decl-specifiers -- I'd like to see int static constexpr unsigned const long inline reordered to something like static constexpr inline const unsigned long int too. Applying this only to const seems incomplete to me.

Jun 2 2021, 3:17 PM · Restricted Project, Restricted Project

Mar 25 2021

davidstone added a comment to D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter.

Do you need me to commit on your behalf? If so, which email address would you like me to use for attribution?

Mar 25 2021, 1:51 PM · Restricted Project
davidstone updated the diff for D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter.

Reformatted

Mar 25 2021, 11:26 AM · Restricted Project

Mar 24 2021

davidstone added a comment to D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter.

I believe this addresses the review comments.

Mar 24 2021, 2:48 PM · Restricted Project
davidstone retitled D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter from Fix PR35677: UB on __int128_t or __uint128_t template parameters. to [clang] Handle 128-bits IntegerLiterals in StmtPrinter.
Mar 24 2021, 2:47 PM · Restricted Project
davidstone updated the diff for D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter.
Mar 24 2021, 2:45 PM · Restricted Project

Mar 22 2021

davidstone added a comment to D99134: Lambdas are not necessarily locals. This resolves DR48250..

The previous commit is https://github.com/llvm/llvm-project/commit/a86bc00, and I don't understand enough of what the other code is doing to know if anything else needs to be fixed. I'd also like to add in a test to ensure this doesn't regress in the future, but I'm not sure of what the best place to put the test is. From https://bugs.llvm.org/show_bug.cgi?id=48250

Mar 22 2021, 8:02 PM · Restricted Project
davidstone added a comment to D99134: Lambdas are not necessarily locals. This resolves DR48250..

It looks like this change was originally added 9 years ago with a commit message of

Mar 22 2021, 7:50 PM · Restricted Project
davidstone added a reviewer for D99134: Lambdas are not necessarily locals. This resolves DR48250.: rsmith.
Mar 22 2021, 7:41 PM · Restricted Project
davidstone requested review of D99134: Lambdas are not necessarily locals. This resolves DR48250..
Mar 22 2021, 7:37 PM · Restricted Project

Dec 2 2020

davidstone added inline comments to D88220: [C++20] P1825R0: More implicit moves.
Dec 2 2020, 4:46 PM · Restricted Project

Jul 13 2020

davidstone added inline comments to D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter.
Jul 13 2020, 10:33 AM · Restricted Project

Jul 1 2020

davidstone added inline comments to D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter.
Jul 1 2020, 8:37 AM · Restricted Project

Jun 30 2020

davidstone added a reviewer for D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter: klimek.
Jun 30 2020, 4:18 PM · Restricted Project
davidstone created D82880: [clang] Handle 128-bits IntegerLiterals in StmtPrinter.
Jun 30 2020, 8:06 AM · Restricted Project

May 24 2020

davidstone added a comment to D78938: Make LLVM build in C++20 mode.

I noticed the missing return because there is a warning (not as error) that caught it, I think the warning about falling off the end of a non-void-returning function.

May 24 2020, 3:59 PM · Restricted Project, Restricted Project

May 20 2020

davidstone added inline comments to D78938: Make LLVM build in C++20 mode.
May 20 2020, 11:25 PM · Restricted Project, Restricted Project