These functions where missing support but are used enough that it
makes sense to track them.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
Nice! LGTM with one minor
llvm/lib/Target/X86/X86ISelLowering.cpp | ||
---|---|---|
38573 | (style) Don't use auto |
Comment Actions
Shouldn't this be a DAGCombine instead? It seems pointless to make computeKnownBits() recurse past an instruction that can only return either unknown or constant. If it returns constant, we want to just replace the instruction, and otherwise we get zero information.
Comment Actions
At least part of this is only matching cases because it has access to the DemandedElts mask
Comment Actions
Hm, through which pathway does this actually end up folding in the non-trivial DemandedElts case? I'd have guessed SimplifyDemandedBits, but it doesn't seem to have a generic constant known bits to constant combine.
Comment Actions
@goldstein.w.n In case you missed it, this has somehow exposed a miscompile: https://github.com/llvm/llvm-project/issues/67287
(style) Don't use auto