This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Rename some tablegen variables to improve code clarity in the vector load/store instruction definitions
ClosedPublic

Authored by nitinjohnraj on Apr 19 2023, 5:03 PM.

Details

Summary

Nondescript names (eg: suffix, n, o) and ambiguous names (eg: eew, lmul in the presence of both data and index EEWs and LMULs) are replaced.

Diff Detail

Event Timeline

nitinjohnraj created this revision.Apr 19 2023, 5:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptApr 19 2023, 5:03 PM
nitinjohnraj requested review of this revision.Apr 19 2023, 5:03 PM
nitinjohnraj added inline comments.Apr 19 2023, 5:06 PM
llvm/lib/Target/RISCV/RISCVInstrInfoV.td
117–118

Should this string be emul instead of lmul?

122–124

Should this string be emul instead of lmul?

130

Should this string be emul instead of lmul?

150–151

Should this string be emul instead of lmul?

154–156

Should this string be emul instead of lmul?

159–160

Should this string be emul instead of lmul?

164–165

Should this string be emul instead of lmul?

168–170

Should this string be emul instead of lmul?

174–176

Should this string be emul instead of lmul?

178–181

Should this string be emul instead of lmul?

nitinjohnraj marked 10 inline comments as not done.Apr 19 2023, 5:07 PM

Please write a description. It will end up the commit log.

llvm/lib/Target/RISCV/RISCVInstrInfoV.td
117–118

Yes

122–124

Yes

130

Yes

150–151

Yes

154–156

Yes

159–160

Yes

164–165

Yes

168–170

Yes

174–176

Yes

178–181

Yes

llvm/lib/Target/RISCV/RISCVInstrInfoVPseudos.td
1733

Use EMUL instead LMUL in this class.

1734

Rename octuple_lmul and octuple_emul to clarify one belongs to data and one belongs to index.

1808

Use EMUL instead of LMUL. Rename the octuple variables

3759

Same here

3830

And here

nitinjohnraj retitled this revision from [RISCV] Rename some variables to improve code clarity to [RISCV] Rename some tablegen variables to improve code clarity in the vector load/store instruction definitions.Apr 21 2023, 2:25 PM
nitinjohnraj edited the summary of this revision. (Show Details)
nitinjohnraj edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Apr 21 2023, 2:46 PM
nitinjohnraj marked 2 inline comments as done.

Addressed comments

nitinjohnraj marked 13 inline comments as done.Apr 21 2023, 3:45 PM

Is this patch still open?

evandro removed a subscriber: evandro.Jun 27 2023, 9:41 AM

These changes have been committed.