This is an archive of the discontinued LLVM Phabricator instance.

[clang-repl] Do not assert if we have weak references left.

Authored by v.g.vassilev on Apr 15 2023, 9:49 AM.



Non-incremental Clang can also exit with the WeakRefReferences not empty upon such example. This patch makes clang-repl consistent to what Clang does.

Diff Detail

Event Timeline

v.g.vassilev created this revision.Apr 15 2023, 9:49 AM
Herald added a project: Restricted Project. · View Herald TranscriptApr 15 2023, 9:49 AM
junaire accepted this revision.Apr 17 2023, 4:33 AM

This patch fixes issues that have not been found in the past. This unblocks D141215 and D146809. Since it's only relevant to the clang-repl, I believe this is safe to just land it. (I added these assertions in ) However, it will be nice if other reviewers, maybe @rjmccall could take a look at this as well.

This revision is now accepted and ready to land.Apr 17 2023, 4:33 AM

Provide a better test case.

Herald added a project: Restricted Project. · View Herald TranscriptMay 8 2023, 2:13 AM