Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

People junaire

junaire (Jun Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 25 2021, 4:22 AM (96 w, 5 d)

Recent Activity
View All

Aug 5 2023

junaire added a comment to D156858: Add Documentation for Execution Results Handling in Clang-REPL.

I want to clarify: We offer two features: 1. capture the execution results and bring it back to the compiled program. 2. dump the captured value (value printing/automatic printf) and all the parsing, ast transform and balabala, these are all implementation details. The doc looks fine but may need a bit of restructuring. I'd suggest you split them into:

  1. what do we offer? what are the new features? why are they important? The two I mentioned above
  2. how these are implemented? what does the underhood look like? annotation token, code synthesis, etc...
  3. further information, RFC and etc...
Aug 5 2023, 8:25 AM · Restricted Project, Restricted Project

Jun 22 2023

junaire committed rGce378fcb9e1c: [libc][NFC] Simplify return value logic in set_thread_ptr() (authored by junaire).
[libc][NFC] Simplify return value logic in set_thread_ptr()
Jun 22 2023, 9:48 AM · Restricted Project, Restricted Project
junaire closed D153572: [libc][NFC] Simplify return value logic in set_thread_ptr().
Jun 22 2023, 9:48 AM · Restricted Project, Restricted Project
junaire added reviewers for D153572: [libc][NFC] Simplify return value logic in set_thread_ptr(): jhuber6, sivachandra, michaelrj.
Jun 22 2023, 9:43 AM · Restricted Project, Restricted Project
junaire requested review of D153572: [libc][NFC] Simplify return value logic in set_thread_ptr().
Jun 22 2023, 9:42 AM · Restricted Project, Restricted Project

May 30 2023

junaire added inline comments to D146809: [clang-repl] Implement pretty printing of custom types..
May 30 2023, 3:48 AM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Add LLVM preamble

May 30 2023, 3:19 AM · Restricted Project, Restricted Project

May 28 2023

junaire updated the summary of D146809: [clang-repl] Implement pretty printing of custom types..
May 28 2023, 11:10 PM · Restricted Project, Restricted Project
junaire added inline comments to D146809: [clang-repl] Implement pretty printing of custom types..
May 28 2023, 11:02 PM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Make CreateUniqName a static helper

May 28 2023, 11:00 PM · Restricted Project, Restricted Project
junaire accepted D151620: [clang-repl] Fix REPL_EXTERNAL_VISIBILITY and building libclang-cpp.dll for MinGW configurations.

Thanks.

May 28 2023, 1:09 AM · Restricted Project, Restricted Project

May 27 2023

junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Rebase

May 27 2023, 5:15 AM · Restricted Project, Restricted Project

May 24 2023

junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Remove Interpereter::getParser + More clean up

May 24 2023, 8:35 PM · Restricted Project, Restricted Project
junaire added inline comments to D146809: [clang-repl] Implement pretty printing of custom types..
May 24 2023, 8:24 PM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Address comments.

May 24 2023, 8:22 PM · Restricted Project, Restricted Project

May 23 2023

junaire updated the diff for D148210: [InstCombine] Reassociate (C * X) * Y in foldICmpMulConstant.

Been busy working on other topics so just address some nit issues to indicate the patch isn't dead yet

May 23 2023, 9:12 AM · Restricted Project, Restricted Project
junaire added a comment to rGd71a4e02277a: Reland [clang-repl] Introduce Value to capture expression results.
In rGd71a4e02277a64a9dece591cdf2b34f15c3b19a0#1207863, @thakis wrote:

http://45.33.8.238/macm1/61229/summary.html is the first build with the reland and that's passing. The build after that is also green, and there are no builds after that yet. Let's see how it goes, but the last time, the bot started failing as soon as the change went in, so it's possible it just works now. Well, good that the change is relanded :)

May 23 2023, 5:16 AM · Restricted Project, Restricted Project
junaire added a comment to rGd71a4e02277a: Reland [clang-repl] Introduce Value to capture expression results.
In rGd71a4e02277a64a9dece591cdf2b34f15c3b19a0#1207689, @thakis wrote:

Sorry for the slow reply.

May 23 2023, 4:37 AM · Restricted Project, Restricted Project
junaire added a reverting change for rG094ab4781262: Revert "Reland [clang-repl] Introduce Value to capture expression results": rG5111286f06e1: Reland "Reland [clang-repl] Introduce Value to capture expression results".
May 23 2023, 4:34 AM · Restricted Project, Restricted Project
junaire committed rG5111286f06e1: Reland "Reland [clang-repl] Introduce Value to capture expression results" (authored by junaire).
Reland "Reland [clang-repl] Introduce Value to capture expression results"
May 23 2023, 4:34 AM · Restricted Project, Restricted Project
junaire abandoned D150937: [clang-repl] Disable all tests on unsupported platforms.

This isn't an ideal solution after an off-list discussion.

May 23 2023, 3:06 AM · Restricted Project, Restricted Project

May 21 2023

junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

.

May 21 2023, 5:15 AM · Restricted Project, Restricted Project
junaire added a comment to rGd71a4e02277a: Reland [clang-repl] Introduce Value to capture expression results.
In rGd71a4e02277a64a9dece591cdf2b34f15c3b19a0#1206744, @thakis wrote:

This breaks check-clang on macOS by making a test unexpectedly pass: http://45.33.8.238/macm1/61024/step_7.txt

Please take a look and revert for now if it takes a while to fix.

Also, please include a "Differential Revision:" line in your commit messages pointing at the review URL. (See git log for many examples.)

May 21 2023, 4:56 AM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

add caas namespace

May 21 2023, 4:22 AM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

.

May 21 2023, 3:13 AM · Restricted Project, Restricted Project
junaire added a comment to D146809: [clang-repl] Implement pretty printing of custom types..

Invite more people to the party :)

May 21 2023, 1:11 AM · Restricted Project, Restricted Project
junaire added reviewers for D146809: [clang-repl] Implement pretty printing of custom types.: aaron.ballman, rsmith.
May 21 2023, 1:11 AM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

.

May 21 2023, 1:10 AM · Restricted Project, Restricted Project

May 19 2023

junaire added a comment to rGd71a4e02277a: Reland [clang-repl] Introduce Value to capture expression results.

I reverted it to bring the bots back to green (https://github.com/llvm/llvm-project/commit/094ab4781262b6cb49d57b0ecdf84b047c879295)

May 19 2023, 6:19 AM · Restricted Project, Restricted Project
junaire added a reverting change for rGd71a4e02277a: Reland [clang-repl] Introduce Value to capture expression results: rG094ab4781262: Revert "Reland [clang-repl] Introduce Value to capture expression results".
May 19 2023, 6:18 AM · Restricted Project, Restricted Project
junaire committed rG094ab4781262: Revert "Reland [clang-repl] Introduce Value to capture expression results" (authored by junaire).
Revert "Reland [clang-repl] Introduce Value to capture expression results"
May 19 2023, 6:18 AM · Restricted Project, Restricted Project
junaire added a comment to rGd71a4e02277a: Reland [clang-repl] Introduce Value to capture expression results.
In rGd71a4e02277a64a9dece591cdf2b34f15c3b19a0#1206744, @thakis wrote:

This breaks check-clang on macOS by making a test unexpectedly pass: http://45.33.8.238/macm1/61024/step_7.txt

Please take a look and revert for now if it takes a while to fix.

Also, please include a "Differential Revision:" line in your commit messages pointing at the review URL. (See git log for many examples.)

May 19 2023, 5:30 AM · Restricted Project, Restricted Project
junaire updated the diff for D150937: [clang-repl] Disable all tests on unsupported platforms.

.

May 19 2023, 2:11 AM · Restricted Project, Restricted Project
junaire updated the summary of D150937: [clang-repl] Disable all tests on unsupported platforms.
May 19 2023, 12:33 AM · Restricted Project, Restricted Project
junaire added a reviewer for D150937: [clang-repl] Disable all tests on unsupported platforms: v.g.vassilev.
May 19 2023, 12:30 AM · Restricted Project, Restricted Project
junaire requested review of D150937: [clang-repl] Disable all tests on unsupported platforms.
May 19 2023, 12:30 AM · Restricted Project, Restricted Project

May 18 2023

junaire added a reverting change for rG7158fd381a0b: Revert "[clang-repl] Introduce Value to capture expression results": rGd71a4e02277a: Reland [clang-repl] Introduce Value to capture expression results.
May 18 2023, 10:41 PM · Restricted Project, Restricted Project
junaire committed rGd71a4e02277a: Reland [clang-repl] Introduce Value to capture expression results (authored by junaire).
Reland [clang-repl] Introduce Value to capture expression results
May 18 2023, 10:41 PM · Restricted Project, Restricted Project

May 16 2023

junaire added a reverting change for rGa423b7f1d7ca: [clang-repl] Introduce Value to capture expression results: rG7158fd381a0b: Revert "[clang-repl] Introduce Value to capture expression results".
May 16 2023, 6:23 AM · Restricted Project, Restricted Project
junaire committed rG7158fd381a0b: Revert "[clang-repl] Introduce Value to capture expression results" (authored by junaire).
Revert "[clang-repl] Introduce Value to capture expression results"
May 16 2023, 6:23 AM · Restricted Project, Restricted Project
junaire closed D141215: [clang-repl] Introduce Value to capture expression results.
May 16 2023, 5:25 AM · Restricted Project, Restricted Project
junaire added a comment to D141215: [clang-repl] Introduce Value to capture expression results.

Because I have edited the commit messages several times so I forgot to include the revision link. Sorry. I have landed it as https://reviews.llvm.org/rGa423b7f1d7ca8b263af85944f57a69aa08fc942c

May 16 2023, 5:25 AM · Restricted Project, Restricted Project
junaire committed rGa423b7f1d7ca: [clang-repl] Introduce Value to capture expression results (authored by junaire).
[clang-repl] Introduce Value to capture expression results
May 16 2023, 5:11 AM · Restricted Project, Restricted Project
junaire committed rG247fa04116a6: [clang] Add a new annotation token: annot_repl_input_end (authored by junaire).
[clang] Add a new annotation token: annot_repl_input_end
May 16 2023, 5:11 AM · Restricted Project, Restricted Project
junaire closed D148997: [clang] Add a new annotation token: annot_repl_input_end.
May 16 2023, 5:11 AM · Restricted Project, Restricted Project
junaire updated the diff for D141215: [clang-repl] Introduce Value to capture expression results.

remove whitespace

May 16 2023, 4:50 AM · Restricted Project, Restricted Project
junaire committed rGa47b56f4ef83: [Instsimplfy] X == Y ? 0 : X - Y --> X - Y (authored by junaire).
[Instsimplfy] X == Y ? 0 : X - Y --> X - Y
May 16 2023, 4:17 AM · Restricted Project, Restricted Project
junaire committed rGba3dbcc779af: Add baseline tests for PR62238 (authored by junaire).
Add baseline tests for PR62238
May 16 2023, 4:17 AM · Restricted Project, Restricted Project
junaire closed D150378: [Instsimplfy] X == Y ? 0 : X - Y --> X - Y.
May 16 2023, 4:16 AM · Restricted Project, Restricted Project
junaire closed D150377: Add baseline tests for PR62238.
May 16 2023, 4:16 AM · Restricted Project, Restricted Project
junaire accepted D150377: Add baseline tests for PR62238.
May 16 2023, 4:16 AM · Restricted Project, Restricted Project
junaire updated the diff for D150378: [Instsimplfy] X == Y ? 0 : X - Y --> X - Y.

Address comments, thanks!

May 16 2023, 4:10 AM · Restricted Project, Restricted Project
junaire updated the diff for D141215: [clang-repl] Introduce Value to capture expression results.

Address comment from Vassil, thx

May 16 2023, 4:01 AM · Restricted Project, Restricted Project
junaire updated the diff for D141215: [clang-repl] Introduce Value to capture expression results.

Add comments

May 16 2023, 3:52 AM · Restricted Project, Restricted Project

May 15 2023

junaire updated the diff for D148210: [InstCombine] Reassociate (C * X) * Y in foldICmpMulConstant.

Ooops, updated a wrong diff, sorry

May 15 2023, 4:13 AM · Restricted Project, Restricted Project
junaire updated the diff for D148210: [InstCombine] Reassociate (C * X) * Y in foldICmpMulConstant.

Rebase + ping :)

May 15 2023, 4:04 AM · Restricted Project, Restricted Project

May 14 2023

junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Make and use our own std::void_t

May 14 2023, 3:38 AM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..
  • include <tuple> to avoid incorrect lookup on Windows
  • Add -Xcc -fno-delayed-template-parsing to fix failure on Windows
May 14 2023, 1:20 AM · Restricted Project, Restricted Project

May 13 2023

junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Add macro guard.

May 13 2023, 9:21 PM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Don't use C++17 because Clang on Windows is not default to that :(

May 13 2023, 9:06 PM · Restricted Project, Restricted Project

May 12 2023

junaire added inline comments to D141215: [clang-repl] Introduce Value to capture expression results.
May 12 2023, 12:30 AM · Restricted Project, Restricted Project

May 11 2023

junaire added inline comments to D150378: [Instsimplfy] X == Y ? 0 : X - Y --> X - Y.
May 11 2023, 10:21 PM · Restricted Project, Restricted Project
junaire updated the diff for D150378: [Instsimplfy] X == Y ? 0 : X - Y --> X - Y.

Replace simplifyInstructionWithOperands => Constant::getNullValue(Op0->getType())

May 11 2023, 10:21 PM · Restricted Project, Restricted Project
junaire added a comment to D150378: [Instsimplfy] X == Y ? 0 : X - Y --> X - Y.
In D150378#4335986, @nikic wrote:

The handling for this should be inside simplifyWithOpReplaced().

May 11 2023, 10:12 PM · Restricted Project, Restricted Project
junaire updated the diff for D150378: [Instsimplfy] X == Y ? 0 : X - Y --> X - Y.

Move the fold to simplifyWithOpReplaced

May 11 2023, 10:08 PM · Restricted Project, Restricted Project
junaire updated the diff for D150377: Add baseline tests for PR62238.

Add negative tests

May 11 2023, 10:07 PM · Restricted Project, Restricted Project
junaire added reviewers for D150378: [Instsimplfy] X == Y ? 0 : X - Y --> X - Y: goldstein.w.n, bcl5980.
May 11 2023, 8:59 AM · Restricted Project, Restricted Project
junaire added reviewers for D150378: [Instsimplfy] X == Y ? 0 : X - Y --> X - Y: nikic, StephenFan.
May 11 2023, 8:48 AM · Restricted Project, Restricted Project
junaire requested review of D150378: [Instsimplfy] X == Y ? 0 : X - Y --> X - Y.
May 11 2023, 8:47 AM · Restricted Project, Restricted Project
junaire requested review of D150377: Add baseline tests for PR62238.
May 11 2023, 8:46 AM · Restricted Project, Restricted Project

May 10 2023

junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Export symbols in Windows.

May 10 2023, 8:04 AM · Restricted Project, Restricted Project

May 9 2023

junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Add some comments

May 9 2023, 11:10 PM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Remove unused code.

May 9 2023, 11:07 PM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Fix

May 9 2023, 11:06 PM · Restricted Project, Restricted Project

May 8 2023

junaire added a comment to D148210: [InstCombine] Reassociate (C * X) * Y in foldICmpMulConstant.

gentle ping :)

May 8 2023, 4:07 AM · Restricted Project, Restricted Project
junaire updated the diff for D141215: [clang-repl] Introduce Value to capture expression results.

.

May 8 2023, 4:02 AM · Restricted Project, Restricted Project
junaire updated the diff for D141215: [clang-repl] Introduce Value to capture expression results.

Rebase + Update

May 8 2023, 3:53 AM · Restricted Project, Restricted Project
junaire updated the diff for D148997: [clang] Add a new annotation token: annot_repl_input_end.

Update + Rebase

May 8 2023, 3:11 AM · Restricted Project, Restricted Project

May 2 2023

junaire updated the diff for D141215: [clang-repl] Introduce Value to capture expression results.

Fix typos

May 2 2023, 9:13 PM · Restricted Project, Restricted Project
junaire added inline comments to D141215: [clang-repl] Introduce Value to capture expression results.
May 2 2023, 9:10 PM · Restricted Project, Restricted Project
junaire updated the diff for D141215: [clang-repl] Introduce Value to capture expression results.

Add more comments.

May 2 2023, 9:10 PM · Restricted Project, Restricted Project
junaire added inline comments to D141215: [clang-repl] Introduce Value to capture expression results.
May 2 2023, 8:24 PM · Restricted Project, Restricted Project
junaire updated the diff for D141215: [clang-repl] Introduce Value to capture expression results.

Address comments from @aaron.ballman, thanks!

May 2 2023, 8:24 PM · Restricted Project, Restricted Project
junaire added a reviewer for D148997: [clang] Add a new annotation token: annot_repl_input_end: rsmith.
May 2 2023, 8:07 AM · Restricted Project, Restricted Project
junaire added inline comments to D148997: [clang] Add a new annotation token: annot_repl_input_end.
May 2 2023, 8:06 AM · Restricted Project, Restricted Project
junaire updated the diff for D148997: [clang] Add a new annotation token: annot_repl_input_end.

Address comments, thanks!

May 2 2023, 8:06 AM · Restricted Project, Restricted Project

May 1 2023

junaire added inline comments to D146809: [clang-repl] Implement pretty printing of custom types..
May 1 2023, 8:42 AM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

Fix AutoType sugar

May 1 2023, 8:42 AM · Restricted Project, Restricted Project
junaire added inline comments to D141215: [clang-repl] Introduce Value to capture expression results.
May 1 2023, 8:18 AM · Restricted Project, Restricted Project
junaire updated the diff for D141215: [clang-repl] Introduce Value to capture expression results.

.

May 1 2023, 8:15 AM · Restricted Project, Restricted Project
junaire updated the diff for D148997: [clang] Add a new annotation token: annot_repl_input_end.

.

May 1 2023, 8:14 AM · Restricted Project, Restricted Project
junaire added a comment to D148210: [InstCombine] Reassociate (C * X) * Y in foldICmpMulConstant.

The review process seems to be stuck. What's your take on the patch? @nikic

May 1 2023, 12:40 AM · Restricted Project, Restricted Project

Apr 30 2023

junaire updated the diff for D141215: [clang-repl] Introduce Value to capture expression results.

.

Apr 30 2023, 3:42 AM · Restricted Project, Restricted Project
junaire added inline comments to D141215: [clang-repl] Introduce Value to capture expression results.
Apr 30 2023, 3:35 AM · Restricted Project, Restricted Project
junaire updated the diff for D141215: [clang-repl] Introduce Value to capture expression results.

.

Apr 30 2023, 3:15 AM · Restricted Project, Restricted Project
junaire added inline comments to D146809: [clang-repl] Implement pretty printing of custom types..
Apr 30 2023, 3:04 AM · Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

.

Apr 30 2023, 2:59 AM · Restricted Project, Restricted Project
junaire added a reviewer for D146809: [clang-repl] Implement pretty printing of custom types.: mizvekov.
Apr 30 2023, 2:52 AM · Restricted Project, Restricted Project
junaire updated the diff for D148209: Add baseline tests for D148210.

.

Apr 30 2023, 2:51 AM · Restricted Project, Restricted Project, Restricted Project
junaire updated the diff for D146809: [clang-repl] Implement pretty printing of custom types..

.

Apr 30 2023, 2:50 AM · Restricted Project, Restricted Project