Page MenuHomePhabricator

junaire (Jun Zhang)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 25 2021, 4:22 AM (62 w, 4 d)

Recent Activity

Sat, Feb 4

junaire updated the diff for D141215: [clang-repl][WIP] Implement pretty printing.

Update

Sat, Feb 4, 10:05 PM · Restricted Project, Restricted Project

Fri, Jan 27

junaire updated the diff for D141215: [clang-repl][WIP] Implement pretty printing.

Update

Fri, Jan 27, 1:36 AM · Restricted Project, Restricted Project

Thu, Jan 12

junaire updated the diff for D141215: [clang-repl][WIP] Implement pretty printing.

Introduce Value class

Thu, Jan 12, 12:19 AM · Restricted Project, Restricted Project

Wed, Jan 11

junaire updated the diff for D141215: [clang-repl][WIP] Implement pretty printing.

Let's try a better approach to determine whether we should pretty print the expression.

Wed, Jan 11, 8:45 PM · Restricted Project, Restricted Project
junaire updated the diff for D141215: [clang-repl][WIP] Implement pretty printing.

Make build bots happy

Wed, Jan 11, 4:47 AM · Restricted Project, Restricted Project

Jan 7 2023

junaire requested review of D141215: [clang-repl][WIP] Implement pretty printing.
Jan 7 2023, 10:58 PM · Restricted Project, Restricted Project

Dec 29 2022

junaire committed rGeda2eaabf294: [clang][dataflow] Fix crash when having boolean-to-integral casts. (authored by junaire).
[clang][dataflow] Fix crash when having boolean-to-integral casts.
Dec 29 2022, 9:16 PM · Restricted Project, Restricted Project
junaire closed D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts..
Dec 29 2022, 9:16 PM · Restricted Project, Restricted Project
junaire updated the diff for D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts..

Fix typos

Dec 29 2022, 6:31 PM · Restricted Project, Restricted Project
junaire retitled D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts. from [clang][dataflow] Check both operand's type in mergeDistinctValues to [clang][dataflow] Fix crash when having boolean-to-integral casts..
Dec 29 2022, 6:25 PM · Restricted Project, Restricted Project
junaire updated the diff for D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts..

Update patch according to @ymandel 's suggestion. Thanks!

Dec 29 2022, 6:24 PM · Restricted Project, Restricted Project
junaire added a comment to D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts..

Thank you for your contribution!

While adding a conditional check fixes the crash, the problem's root cause must be deeper. Mismatched types indicate that one code path in dataflow analysis computes a bool type for a storage location, while a different code path computes an integer type. That's the actual root cause. Could you try to investigate the reasons for that, and try to fix it? The dataflow analysis should be computing values of the same type no matter through which path we arrived at a program point.

Dec 29 2022, 3:03 AM · Restricted Project, Restricted Project
junaire added reviewers for D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts.: ymandel, sgatev, gribozavr2.
Dec 29 2022, 1:20 AM · Restricted Project, Restricted Project
junaire requested review of D140753: [clang][dataflow] Fix crash when having boolean-to-integral casts..
Dec 29 2022, 1:16 AM · Restricted Project, Restricted Project

Dec 2 2022

junaire added a comment to rG8431436e543f: Link with missing libs to fix broken shared build.

Forgot about the tests :)

Dec 2 2022, 9:13 AM · Restricted Project, Restricted Project
junaire committed rG4fd0c14a17f9: Link with missing libs to fix broken shared unittest build (authored by junaire).
Link with missing libs to fix broken shared unittest build
Dec 2 2022, 9:12 AM · Restricted Project, Restricted Project
junaire committed rG8431436e543f: Link with missing libs to fix broken shared build (authored by junaire).
Link with missing libs to fix broken shared build
Dec 2 2022, 8:02 AM · Restricted Project, Restricted Project
junaire closed D139202: Link with missing libs to fix broken shared build.
Dec 2 2022, 8:02 AM · Restricted Project, Restricted Project
junaire added a comment to D139202: Link with missing libs to fix broken shared build.

This is caused by https://reviews.llvm.org/D139013 I should mention.

Dec 2 2022, 7:39 AM · Restricted Project, Restricted Project
junaire added reviewers for D139202: Link with missing libs to fix broken shared build: sammccall, aaron.ballman.
Dec 2 2022, 7:37 AM · Restricted Project, Restricted Project
junaire requested review of D139202: Link with missing libs to fix broken shared build.
Dec 2 2022, 7:36 AM · Restricted Project, Restricted Project

Nov 5 2022

junaire added inline comments to D137494: [Clangd] Fix the code action `RemoveUsingNamespace`.
Nov 5 2022, 8:56 PM · Restricted Project, Restricted Project
junaire added a comment to D137494: [Clangd] Fix the code action `RemoveUsingNamespace`.

@tom-anders Thank you for reviewing!

I tried adding a test but I don't know how to run the tests.

And I just found that operators declared in a class context are already handled in the existing version, but user-defined literals are not, so I rewrote the comments.

Nov 5 2022, 8:16 PM · Restricted Project, Restricted Project

Oct 18 2022

junaire committed rG2946b252993d: [Clang] Fix crash when checking misaligned member with dependent type (authored by junaire).
[Clang] Fix crash when checking misaligned member with dependent type
Oct 18 2022, 6:07 AM · Restricted Project, Restricted Project
junaire closed D136018: [Clang] Fix crash when checking misaligned member with dependent type.
Oct 18 2022, 6:07 AM · Restricted Project, Restricted Project

Oct 17 2022

junaire added inline comments to D136018: [Clang] Fix crash when checking misaligned member with dependent type.
Oct 17 2022, 9:35 PM · Restricted Project, Restricted Project
junaire updated the diff for D136018: [Clang] Fix crash when checking misaligned member with dependent type.

Add the original mailformed test case, thanks Shafik!

Oct 17 2022, 9:29 PM · Restricted Project, Restricted Project
junaire updated the diff for D136018: [Clang] Fix crash when checking misaligned member with dependent type.

Address Aaron's comments, thanks!

Oct 17 2022, 7:15 AM · Restricted Project, Restricted Project

Oct 15 2022

junaire requested review of D136018: [Clang] Fix crash when checking misaligned member with dependent type.
Oct 15 2022, 6:33 AM · Restricted Project, Restricted Project

Sep 27 2022

junaire committed rG89e56e732d5e: [Clang] Don't warn if deferencing void pointers in unevaluated context (authored by junaire).
[Clang] Don't warn if deferencing void pointers in unevaluated context
Sep 27 2022, 9:30 PM · Restricted Project, Restricted Project
junaire closed D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context.
Sep 27 2022, 9:30 PM · Restricted Project, Restricted Project
junaire added a comment to D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context.

Thanks a lot for fixing this! I took it for a spin against the Linux kernel and all instances of -Wvoid-ptr-dereference disappeared :)

Sep 27 2022, 8:31 AM · Restricted Project, Restricted Project

Sep 26 2022

junaire requested review of D134702: [Clang] Don't warn if deferencing void pointers in unevaluated context.
Sep 26 2022, 9:58 PM · Restricted Project, Restricted Project
junaire added a comment to D134461: [Clang] Warn when trying to deferencing void pointers in C.

Sorry for missing the conversation, I was in sleeping mode at that time ;D

Sep 26 2022, 8:47 PM · Restricted Project, Restricted Project

Sep 24 2022

junaire committed rGe07ead85a368: [Clang] Warn when trying to dereference void pointers in C (authored by junaire).
[Clang] Warn when trying to dereference void pointers in C
Sep 24 2022, 7:20 AM · Restricted Project, Restricted Project
junaire closed D134461: [Clang] Warn when trying to deferencing void pointers in C.
Sep 24 2022, 7:20 AM · Restricted Project, Restricted Project

Sep 23 2022

junaire updated the diff for D134461: [Clang] Warn when trying to deferencing void pointers in C.

Address comments.

Sep 23 2022, 9:18 PM · Restricted Project, Restricted Project
junaire added inline comments to D134461: [Clang] Warn when trying to deferencing void pointers in C.
Sep 23 2022, 8:35 PM · Restricted Project, Restricted Project
junaire added inline comments to D134283: [clang][DR2621] using enum NAME lookup fix.
Sep 23 2022, 6:24 AM · Restricted Project, Restricted Project
junaire updated the diff for D134461: [Clang] Warn when trying to deferencing void pointers in C.

Add &(*p) test case in dr1xx.c. (Previous seperate test is removed as it mostly duplicate with the DR test)

Sep 23 2022, 2:34 AM · Restricted Project, Restricted Project
junaire retitled D134461: [Clang] Warn when trying to deferencing void pointers in C from [Clang] Diagnose an error when trying to deferencing void pointers in C to [Clang] Warn when trying to deferencing void pointers in C.
Sep 23 2022, 2:28 AM · Restricted Project, Restricted Project
junaire added a comment to D134461: [Clang] Warn when trying to deferencing void pointers in C.

So I thought 'isAddressOfOperand' might be good enough for this, is this not the case?

Sep 23 2022, 2:27 AM · Restricted Project, Restricted Project
junaire updated the diff for D134461: [Clang] Warn when trying to deferencing void pointers in C.

Address comments from reviewers.

Sep 23 2022, 2:24 AM · Restricted Project, Restricted Project

Sep 22 2022

junaire added inline comments to D134461: [Clang] Warn when trying to deferencing void pointers in C.
Sep 22 2022, 11:06 AM · Restricted Project, Restricted Project
junaire added a comment to D134461: [Clang] Warn when trying to deferencing void pointers in C.

I'd admit that passing a boolean between these functions is ugly but surprisingly it works! even for `&(void_ptr)! But yeah, please suggest if you have better solutions ;D

Sep 22 2022, 11:05 AM · Restricted Project, Restricted Project
junaire requested review of D134461: [Clang] Warn when trying to deferencing void pointers in C.
Sep 22 2022, 10:59 AM · Restricted Project, Restricted Project

Sep 18 2022

junaire committed rG303526ef3aa2: [Docs] Add a link that refers to C++ standard modules in Clang modules doc (authored by junaire).
[Docs] Add a link that refers to C++ standard modules in Clang modules doc
Sep 18 2022, 3:32 AM · Restricted Project, Restricted Project
junaire closed D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc.
Sep 18 2022, 3:32 AM · Restricted Project, Restricted Project

Sep 17 2022

junaire added a comment to D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc.

Sep 17 2022, 8:14 PM · Restricted Project, Restricted Project
junaire updated the diff for D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc.

I bet now it rendered correctly.

Sep 17 2022, 8:13 PM · Restricted Project, Restricted Project
junaire requested review of D134105: [Docs] Add a link that refers to C++ standard modules in Clang modules doc.
Sep 17 2022, 2:51 AM · Restricted Project, Restricted Project

Sep 15 2022

junaire added a comment to D133941: [clang][Interp] Record item types in InterpStack.

Do you think std::is_same_v will be even better?

Sep 15 2022, 11:46 PM · Restricted Project, Restricted Project

Sep 12 2022

junaire closed D133088: [Clang] Reword diagnostic for scope identifier with linkage.
Sep 12 2022, 7:43 AM · Restricted Project, Restricted Project
junaire committed rG1d51bb824f25: [Clang] Reword diagnostic for scope identifier with linkage (authored by junaire).
[Clang] Reword diagnostic for scope identifier with linkage
Sep 12 2022, 7:41 AM · Restricted Project, Restricted Project

Sep 11 2022

junaire retitled D133088: [Clang] Reword diagnostic for scope identifier with linkage from [Clang] Reword diagnostic for scope identifier with internal linkage to [Clang] Reword diagnostic for scope identifier with linkage.
Sep 11 2022, 7:47 PM · Restricted Project, Restricted Project
junaire retitled D133088: [Clang] Reword diagnostic for scope identifier with linkage from [Clang] Fix wrong diagnostic for scope identifier with internal linkage to [Clang] Reword diagnostic for scope identifier with internal linkage.
Sep 11 2022, 7:47 PM · Restricted Project, Restricted Project
junaire updated the diff for D133088: [Clang] Reword diagnostic for scope identifier with linkage.

Rebase, adjust commit message and release note.

Sep 11 2022, 7:46 PM · Restricted Project, Restricted Project

Sep 10 2022

junaire updated the diff for D133088: [Clang] Reword diagnostic for scope identifier with linkage.

Try to address Aaron's comments.

Sep 10 2022, 7:06 AM · Restricted Project, Restricted Project

Sep 9 2022

junaire added a comment to D133088: [Clang] Reword diagnostic for scope identifier with linkage.

gentle ping :)

Sep 9 2022, 8:14 AM · Restricted Project, Restricted Project

Sep 4 2022

junaire updated the diff for D133088: [Clang] Reword diagnostic for scope identifier with linkage.

Rebase

Sep 4 2022, 7:01 AM · Restricted Project, Restricted Project

Sep 1 2022

junaire updated the diff for D133088: [Clang] Reword diagnostic for scope identifier with linkage.

Update the existing diagnostic and its tests.

Sep 1 2022, 8:05 PM · Restricted Project, Restricted Project

Aug 31 2022

junaire updated the diff for D133088: [Clang] Reword diagnostic for scope identifier with linkage.

Simpify code a little bit.

Aug 31 2022, 9:32 PM · Restricted Project, Restricted Project
junaire requested review of D133088: [Clang] Reword diagnostic for scope identifier with linkage.
Aug 31 2022, 9:11 PM · Restricted Project, Restricted Project

Aug 27 2022

junaire committed rGb9c2b6069ea7: Avoid else-if after return, NFC (authored by junaire).
Avoid else-if after return, NFC
Aug 27 2022, 8:19 AM · Restricted Project, Restricted Project
junaire committed rGa4f84f1b2e92: [CodeGen] Track DeferredDecls that have been emitted (authored by junaire).
[CodeGen] Track DeferredDecls that have been emitted
Aug 27 2022, 7:53 AM · Restricted Project, Restricted Project
junaire closed D130831: [CodeGen] Track DeferredDecls that have been emitted.
Aug 27 2022, 7:52 AM · Restricted Project, Restricted Project

Aug 13 2022

junaire added a comment to D130831: [CodeGen] Track DeferredDecls that have been emitted.

gentle ping :)

Aug 13 2022, 7:56 PM · Restricted Project, Restricted Project

Aug 11 2022

junaire abandoned D124434: [Clang][Test] Run tests in C++14 mode explicitly..

Prefer https://reviews.llvm.org/D131464

Aug 11 2022, 7:00 AM · Restricted Project, Restricted Project
junaire closed D131657: Remove redundant condition check, NFC.
Aug 11 2022, 6:51 AM · Restricted Project, Restricted Project
junaire added a comment to D131657: Remove redundant condition check, NFC.

LGTM! Let us know if you need this committed for you.

Aug 11 2022, 6:50 AM · Restricted Project, Restricted Project
junaire committed rGefc75a2baedc: Remove redundant condition check, NFC (authored by junaire).
Remove redundant condition check, NFC
Aug 11 2022, 6:48 AM · Restricted Project, Restricted Project
junaire added reviewers for D131657: Remove redundant condition check, NFC: aaron.ballman, erichkeane.
Aug 11 2022, 12:51 AM · Restricted Project, Restricted Project
junaire requested review of D131657: Remove redundant condition check, NFC.
Aug 11 2022, 12:50 AM · Restricted Project, Restricted Project

Aug 9 2022

junaire added inline comments to D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default.
Aug 9 2022, 4:08 PM · Restricted Project, Restricted Project, Restricted Project
junaire committed rG0981975ad0df: [LLVM] Use range based for loop, NFC (authored by junaire).
[LLVM] Use range based for loop, NFC
Aug 9 2022, 9:06 AM · Restricted Project, Restricted Project

Aug 8 2022

junaire added reviewers for D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default: aaron.ballman, dblaikie.
Aug 8 2022, 10:22 PM · Restricted Project, Restricted Project, Restricted Project
junaire added a comment to D131464: [test] Make tests pass regardless of gnu++14/gnu++17 default.

I wonder what's the difference between this patch and https://reviews.llvm.org/D124434 ? Also add some reviewers that get involved in the previous discussion.

Aug 8 2022, 10:21 PM · Restricted Project, Restricted Project, Restricted Project

Aug 7 2022

junaire added a comment to D131313: [Support] move llvm::llvm_is_multithread to header, NFC.

Thanks!

Aug 7 2022, 5:51 PM · Restricted Project, Restricted Project
junaire committed rG98339ac7af30: [Support] move llvm::llvm_is_multithread to header, NFC (authored by junaire).
[Support] move llvm::llvm_is_multithread to header, NFC
Aug 7 2022, 5:50 PM · Restricted Project, Restricted Project
junaire closed D131313: [Support] move llvm::llvm_is_multithread to header, NFC.
Aug 7 2022, 5:50 PM · Restricted Project, Restricted Project
junaire updated the diff for D131313: [Support] move llvm::llvm_is_multithread to header, NFC.

git clang-format HEAD~1 can't format code that not been touched, format by hand.

Aug 7 2022, 8:04 AM · Restricted Project, Restricted Project
junaire added inline comments to D131313: [Support] move llvm::llvm_is_multithread to header, NFC.
Aug 7 2022, 7:58 AM · Restricted Project, Restricted Project
junaire retitled D131313: [Support] move llvm::llvm_is_multithread to header, NFC from [Support] Use constexpr if to [Support] move llvm::llvm_is_multithread to header, NFC.
Aug 7 2022, 7:35 AM · Restricted Project, Restricted Project
junaire updated the diff for D131313: [Support] move llvm::llvm_is_multithread to header, NFC.

I'm not if this patch is worth to continue...

Aug 7 2022, 7:33 AM · Restricted Project, Restricted Project

Aug 6 2022

junaire added reviewers for D131313: [Support] move llvm::llvm_is_multithread to header, NFC: thieta, MaskRay, mehdi_amini, thakis, nikic.
Aug 6 2022, 3:42 AM · Restricted Project, Restricted Project
junaire updated the diff for D131313: [Support] move llvm::llvm_is_multithread to header, NFC.

Clang-format

Aug 6 2022, 2:56 AM · Restricted Project, Restricted Project
junaire updated the diff for D131313: [Support] move llvm::llvm_is_multithread to header, NFC.

Fix the build

Aug 6 2022, 2:14 AM · Restricted Project, Restricted Project
junaire requested review of D131313: [Support] move llvm::llvm_is_multithread to header, NFC.
Aug 6 2022, 1:13 AM · Restricted Project, Restricted Project

Aug 5 2022

junaire committed rG786b503f66b1: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior. (authored by junaire).
[Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.
Aug 5 2022, 8:58 PM · Restricted Project, Restricted Project
junaire closed D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior..
Aug 5 2022, 8:58 PM · Restricted Project, Restricted Project

Aug 4 2022

junaire added reviewers for D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior.: v.g.vassilev, rsmith, akyrtzi, jansvoboda11.
Aug 4 2022, 11:30 PM · Restricted Project, Restricted Project
junaire requested review of D131241: [Clang][Lex] Extend HeaderSearch::LookupFile to control OpenFile behavior..
Aug 4 2022, 11:25 PM · Restricted Project, Restricted Project

Jul 31 2022

junaire committed rG9caee577ef0f: [clang-repl] Fix incorrect return code (authored by junaire).
[clang-repl] Fix incorrect return code
Jul 31 2022, 4:15 AM · Restricted Project, Restricted Project
junaire closed D130422: [clang-repl] Fix incorrect return code.
Jul 31 2022, 4:14 AM · Restricted Project, Restricted Project
junaire added inline comments to D130827: [clang] Fixed a number of typos.
Jul 31 2022, 4:12 AM · Restricted Project, Restricted Project
junaire added a comment to rG067faddb55b9: [JITLink][COFF] Add explicit std::move..

This is actually because we are using implicit consturctor of Expected class. We should explicitly move in this case.

Jul 31 2022, 3:39 AM · Restricted Project, Restricted Project
junaire added inline comments to D130422: [clang-repl] Fix incorrect return code.
Jul 31 2022, 2:47 AM · Restricted Project, Restricted Project
junaire added a comment to D130422: [clang-repl] Fix incorrect return code.

@v.g.vassilev if you can take another look at the wording of the FIXME, and make sure you're happy about it, that will be awesome.

Jul 31 2022, 2:13 AM · Restricted Project, Restricted Project
junaire updated the diff for D130422: [clang-repl] Fix incorrect return code.

Fix some typos

Jul 31 2022, 2:11 AM · Restricted Project, Restricted Project
junaire updated the diff for D130422: [clang-repl] Fix incorrect return code.

Rebase and add a FIXME

Jul 31 2022, 2:07 AM · Restricted Project, Restricted Project