Non-incremental Clang can also exit with the WeakRefReferences not empty upon such example. This patch makes clang-repl consistent to what Clang does.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
This patch fixes issues that have not been found in the past. This unblocks D141215 and D146809. Since it's only relevant to the clang-repl, I believe this is safe to just land it. (I added these assertions in https://reviews.llvm.org/rGcd64a427efa0baaf1bb7ae624d4301908afc07f7 ) However, it will be nice if other reviewers, maybe @rjmccall could take a look at this as well.