Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Avoid migrating existing patches. Phabricator shutdown timeline

Differential D147670

[mlir][sparse] enable more sparse convolution kernels.
ClosedPublic
Actions

Authored by Peiming on Apr 5 2023, 4:44 PM.

Details

Reviewers
aartbik
nicolasvasilache
wrengr
bixia
Commits
rG6a148c5aa7c7: [mlir][sparse] enable more sparse convolution kernels.

Diff Detail

Event Timeline

Peiming created this revision.Apr 5 2023, 4:44 PM
Herald added a reviewer: aartbik. · View Herald TranscriptApr 5 2023, 4:44 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: hanchung, jsetoain, Moerafaat and 23 others. · View Herald Transcript
Peiming requested review of this revision.Apr 5 2023, 4:44 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptApr 5 2023, 4:44 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B223896: Diff 511232.Apr 5 2023, 4:45 PM
Peiming added reviewers: wrengr, bixia.Apr 5 2023, 4:46 PM
Peiming added a parent revision: D147553: [mlir][sparse] use macro to build common operations in LoopEmitter.
Peiming updated this revision to Diff 511234.Apr 5 2023, 4:57 PM

revert debug code.

Harbormaster completed remote builds in B223898: Diff 511234.Apr 5 2023, 5:06 PM
Peiming updated this revision to Diff 513360.Apr 13 2023, 2:17 PM

rebase.

Herald added a subscriber: bviyer. · View Herald TranscriptApr 13 2023, 2:17 PM
Harbormaster completed remote builds in B225439: Diff 513360.Apr 13 2023, 2:50 PM
Peiming updated this revision to Diff 514285.Apr 17 2023, 10:00 AM

rebase.

aartbik added inline comments.Apr 17 2023, 10:23 AM
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp
1620

typo: outermost

then, in terms of reading the code, seeing

if (!outermost)

this is outermost

is very confusing ;-)
Can you rephrase so that your logic is more clear

Peiming updated this revision to Diff 514294.Apr 17 2023, 10:25 AM

address comments.

aartbik accepted this revision.Apr 17 2023, 10:31 AM
This revision is now accepted and ready to land.Apr 17 2023, 10:31 AM
This revision was landed with ongoing or failed builds.Apr 17 2023, 10:44 AM
Closed by commit rG6a148c5aa7c7: [mlir][sparse] enable more sparse convolution kernels. (authored by Peiming). · Explain Why
This revision was automatically updated to reflect the committed changes.
Peiming added a commit: rG6a148c5aa7c7: [mlir][sparse] enable more sparse convolution kernels..
Harbormaster completed remote builds in B226139: Diff 514294.Apr 17 2023, 11:19 AM

Revision Contents
Changeset List

PathSize
mlir/
lib/
Dialect/
SparseTensor/
Transforms/
10 lines
150 lines
test/
Integration/
Dialect/
SparseTensor/
CPU/
33 lines
32 lines
36 lines

Diff 514294

View Options

mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp

Loading...
View Options

mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_conv_1d_nwc_wcf.mlir

Loading...
View Options

mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_conv_2d_nhwc_hwcf.mlir

Loading...
View Options

mlir/test/Integration/Dialect/SparseTensor/CPU/sparse_conv_3d_ndhwc_dhwcf.mlir

Loading...