[python] Expose clang_Location_isInSystemHeader

[R2RT]

Summary

Add is_in_system_header property for Location class.

Corresponding unit test was also added.

[R2RT]

I thought about adding it into release notes, but recently Python section has got removed from ReleaseNotes.rst, so I am not sure what to do now: https://reviews.llvm.org/D142578

[aaron.ballman]

LGTM! Do you need someone to land this on your behalf? If so, please let me know what name and email address you would like for patch attribution.

In D147414#4239453, @R2RT wrote:

I thought about adding it into release notes, but recently Python section has got removed from ReleaseNotes.rst, so I am not sure what to do now: https://reviews.llvm.org/D142578

The section was removed mostly because the python bindings weren't getting a lot of updates. I think this deserves a release note, so let's add the python bindings section back in and put a note under it for this.

[R2RT]

Bring back Python section in release notes and document new is_in_system_header property.

[R2RT]

In D147414#4240343, @aaron.ballman wrote:

LGTM! Do you need someone to land this on your behalf? If so, please let me know what name and email address you would like for patch attribution.

In D147414#4239453, @R2RT wrote:

I thought about adding it into release notes, but recently Python section has got removed from ReleaseNotes.rst, so I am not sure what to do now: https://reviews.llvm.org/D142578

The section was removed mostly because the python bindings weren't getting a lot of updates. I think this deserves a release note, so let's add the python bindings section back in and put a note under it for this.

I've brought back Python section with relevant note.

I have no idea how to land it, it is my first contribution here, so maybe it will be easier this way.
Please attribute it to Artur Ryt <[e-mail]>, thanks :)

clang/bindings/python/clang/cindex.py

def column(self):
         """Get the column represented by this source location."""
         return self._get_instantiation()[2]
 
     @property
     def offset(self):
         """Get the file offset represented by this source location."""
         return self._get_instantiation()[3]
 
+    @property
+    def is_in_system_header(self):
+        """Returns true if the given source location is in a system header."""
+        return conf.lib.clang_Location_isInSystemHeader(self)
+
     def __eq__(self, other):
         return conf.lib.clang_equalLocations(self, other)
 
     def __ne__(self, other):
         return not self.__eq__(other)
 
     def __repr__(self):
         if self.file:
#  CXTUResourceUsage),
    [Cursor],
    _CXString,
    _CXString.from_result),
 
   ("clang_Cursor_getOffsetOfField",
    [Cursor],
    c_longlong),
 
+  ("clang_Location_isInSystemHeader",
+   [SourceLocation],
+   bool),
+
   ("clang_Type_getAlignOf",
    [Type],
    c_longlong),
 
   ("clang_Type_getClassType",
    [Type],
    Type,
    Type.from_result),

clang/bindings/python/tests/cindex/test_location.py

 import os
 from clang.cindex import Config
 if 'CLANG_LIBRARY_PATH' in os.environ:
     Config.set_library_path(os.environ['CLANG_LIBRARY_PATH'])
 
 from clang.cindex import Cursor
 from clang.cindex import File
 from clang.cindex import SourceLocation
 from clang.cindex import SourceRange
+from clang.cindex import TranslationUnit
 from .util import get_cursor
 from .util import get_tu
 
 import unittest
 
 
 baseInput="int one;\nint two;\n"
 
def test_extent(self):
 
         range1 = SourceRange.from_locations(location1, location2)
         range2 = SourceRange.from_locations(location1, location2)
         self.assertEqual(range1, range2)
 
         location3 = SourceLocation.from_position(tu, file, 1, 6)
         range3 = SourceRange.from_locations(location1, location3)
         self.assertNotEqual(range1, range3)
+
+    def test_is_system_location(self):
+        header = os.path.normpath('./fake/fake.h')
+        tu = TranslationUnit.from_source('fake.c', [f'-isystem{os.path.dirname(header)}'], unsaved_files = [
+                ('fake.c', """
+#include <fake.h>
+int one;
+"""),
+                (header, "int two();")
+                ])
+        one = get_cursor(tu, 'one')
+        two = get_cursor(tu, 'two')
+        self.assertFalse(one.location.is_in_system_header)
+        self.assertTrue(two.location.is_in_system_header)

clang/docs/ReleaseNotes.rst

- Fix incorrect alignment attribute on the this parameter of certain
   non-complete destructors when using the Microsoft ABI.
   (`#60465 <https://github.com/llvm/llvm-project/issues/60465>`_)
 
 .. _release-notes-sanitizers:
 
 Sanitizers
 ----------
 
+Python Binding Changes
+----------------------
+The following methods have been added:
+
+- ``clang_Location_isInSystemHeader`` exposed via the ``is_in_system_header``
+  property of the `Location` class.
 
 Additional Information
 ======================
 
 A wide variety of additional information is available on the `Clang web
 page <https://clang.llvm.org/>`_. The web page contains versions of the
 API documentation which are up-to-date with the Git version of
 the source code. You can access versions of these documents specific to
 this release by going into the "``clang/docs/``" directory in the Clang
 tree.
 
 If you have any questions or comments about Clang, please feel free to
 contact us on the `Discourse forums (Clang Frontend category)
 <https://discourse.llvm.org/c/clang/6>`_.