Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D146693

[mlir][sparse] Introducing newtypes for TensorId, LoopId, TensorLoopId
Needs ReviewPublic
Actions

Authored by wrengr on Mar 22 2023, 10:55 PM.

Details

Reviewers
bixia
Peiming
nicolasvasilache
aartbik
Summary

This commit converts these types from typedefs to newtypes. In addition this allows cleaning up some other code (because we couldn't overload things by type before), such as the TensorExp constructor.

Depends On D146691

Diff Detail

Event Timeline

wrengr created this revision.Mar 22 2023, 10:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2023, 10:55 PM
Herald added subscribers: hanchung, jsetoain, Moerafaat and 20 others. · View Herald Transcript
wrengr requested review of this revision.Mar 22 2023, 10:55 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 22 2023, 10:55 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B221227: Diff 507615.Mar 22 2023, 10:56 PM
wrengr updated this revision to Diff 507618.Mar 22 2023, 10:57 PM

git-clang-format

Harbormaster completed remote builds in B221229: Diff 507618.Mar 22 2023, 10:59 PM
wrengr mentioned this in D142930: [mlir][sparse] extend loop emitter to emit slice driven loops.Mar 24 2023, 6:15 PM
Peiming added inline comments.Mar 27 2023, 1:39 PM
mlir/include/mlir/Dialect/SparseTensor/Utils/MergerNewtypes.h
308

Why using operation * instead of operator unsigned() to convert it implicitly to unsigned for array indexing?

wrengr mentioned this in D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.Mar 29 2023, 12:17 PM
wrengr mentioned this in D147011: [mlir][sparse] Replace Element with ElementId for sorting..Mar 29 2023, 1:27 PM
wrengr updated this revision to Diff 509499.Mar 29 2023, 4:32 PM
wrengr mentioned this in D146690: [mlir][sparse] Introducing newtypes for ExprId, LatPointId, LatSetId.

rebasing for the postponement splitting of D146684

Harbormaster completed remote builds in B222612: Diff 509499.Mar 29 2023, 4:44 PM
wrengr updated this revision to Diff 509502.Mar 29 2023, 4:47 PM

rebasing for the postponement splitting of D146684

Harbormaster completed remote builds in B222615: Diff 509502.Mar 29 2023, 4:58 PM
aartbik resigned from this revision.Aug 22 2023, 7:55 PM
Herald added subscribers: K-Wu, bviyer, aartbik. · View Herald TranscriptAug 22 2023, 7:55 PM

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
SparseTensor/
Utils/
103 lines
334 lines
lib/
Dialect/
SparseTensor/
Transforms/
2 lines
12 lines
244 lines
2 lines
85 lines
Utils/
120 lines
unittests/
Dialect/
SparseTensor/
2 lines

Diff 507618

View Options

mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h

Loading...
View Options

mlir/include/mlir/Dialect/SparseTensor/Utils/MergerNewtypes.h

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/CodegenEnv.cpp

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp

Loading...
View Options

mlir/unittests/Dialect/SparseTensor/MergerTest.cpp

Loading...