[mlir][sparse] Introducing newtypes for ExprId, LatPointId, LatSetId
Needs ReviewPublic
Actions

Authored by wrengr on Mar 22 2023, 10:26 PM.

Details

Reviewers

aartbik
bixia
Peiming
nicolasvasilache

Summary

This commit performs the actual change from using typedefs to using newtypes. The ExprId, LatPointId, LatSetId types are especially simple, because: (1) the Merger has compete control over allocating them, and (2) client code only ever needs the equality operator (if it even needs that).

Depends On D146684

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

wrengr created this revision.Mar 22 2023, 10:26 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2023, 10:26 PM

Herald added subscribers: hanchung, jsetoain, Moerafaat and 20 others. · View Herald Transcript

wrengr requested review of this revision.Mar 22 2023, 10:26 PM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 22 2023, 10:26 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript

Harbormaster completed remote builds in B221223: Diff 507610.Mar 22 2023, 10:27 PM

wrengr added a child revision: D146691: [mlir][sparse] Introducing iterators for TensorId, LoopId, TensorLoopId.Mar 22 2023, 10:40 PM

rebase

Harbormaster completed remote builds in B221712: Diff 508260.Mar 24 2023, 6:40 PM

Addressing the -Wmismatched-tags warnings on Debian.

Harbormaster completed remote builds in B221716: Diff 508265.Mar 24 2023, 7:16 PM

Peiming added inline comments.Mar 27 2023, 1:30 PM

mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h
590	Why not supporting an implicit type conversion from the new types to unsigned (but not vice versa) so that they can be used directly for vector/array indices?