This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] Introducing newtypes for TensorId, LoopId, TensorLoopId
Needs ReviewPublic

Authored by wrengr on Mar 22 2023, 10:55 PM.



This commit converts these types from typedefs to newtypes. In addition this allows cleaning up some other code (because we couldn't overload things by type before), such as the TensorExp constructor.

Depends On D146691

Diff Detail

Event Timeline

wrengr created this revision.Mar 22 2023, 10:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2023, 10:55 PM
wrengr requested review of this revision.Mar 22 2023, 10:55 PM
wrengr updated this revision to Diff 507618.Mar 22 2023, 10:57 PM


Peiming added inline comments.Mar 27 2023, 1:39 PM

Why using operation * instead of operator unsigned() to convert it implicitly to unsigned for array indexing?

wrengr updated this revision to Diff 509502.Mar 29 2023, 4:47 PM

rebasing for the postponement splitting of D146684

aartbik resigned from this revision.Aug 22 2023, 7:55 PM