This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] Misc cleanup in Merger.h

Authored by wrengr on Mar 21 2023, 1:40 PM.


  • Moving the Children class to be nested under TensorExp.
  • Marking TensorExp, TensorExp::Children, and LatPoint as final.

Depends On D146083

Diff Detail

Event Timeline

wrengr created this revision.Mar 21 2023, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2023, 1:40 PM
wrengr requested review of this revision.Mar 21 2023, 1:40 PM
aartbik accepted this revision.Mar 21 2023, 1:46 PM
aartbik added inline comments.

is it, an MLIR expression?

This revision is now accepted and ready to land.Mar 21 2023, 1:46 PM
wrengr added inline comments.Mar 21 2023, 4:26 PM

I didn't actually change anything there (the diff is misaligned for some reason), but yes it should be "an" :)

wrengr updated this revision to Diff 507590.Mar 22 2023, 9:21 PM

rebase, and removing D146561 as a dependency

This revision was automatically updated to reflect the committed changes.