Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

Differential D146562

[mlir][sparse] Misc cleanup in Merger.h
ClosedPublic
Actions

Authored by wrengr on Mar 21 2023, 1:40 PM.

Details

Reviewers
aartbik
bixia
Peiming
nicolasvasilache
Commits
rGb3379538e8bd: [mlir][sparse] Misc cleanup in Merger.h
Summary
  • Moving the Children class to be nested under TensorExp.
  • Marking TensorExp, TensorExp::Children, and LatPoint as final.

Depends On D146083

Diff Detail

Event Timeline

wrengr created this revision.Mar 21 2023, 1:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2023, 1:40 PM
Herald added subscribers: hanchung, jsetoain, Moerafaat and 20 others. · View Herald Transcript
wrengr requested review of this revision.Mar 21 2023, 1:40 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 21 2023, 1:40 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B220825: Diff 507110.Mar 21 2023, 1:41 PM
aartbik accepted this revision.Mar 21 2023, 1:46 PM
aartbik added inline comments.
mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h
82–83

is it, an MLIR expression?

This revision is now accepted and ready to land.Mar 21 2023, 1:46 PM
wrengr added inline comments.Mar 21 2023, 4:26 PM
mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h
82–83

I didn't actually change anything there (the diff is misaligned for some reason), but yes it should be "an" :)

wrengr updated this revision to Diff 507554.Mar 22 2023, 5:08 PM

rebase

Harbormaster completed remote builds in B221174: Diff 507554.Mar 22 2023, 5:09 PM
wrengr added a child revision: D146673: [mlir][sparse] Updating TensorExp ctor to catch unknown TensorExp::Kind.Mar 22 2023, 5:09 PM
wrengr edited the summary of this revision. (Show Details)Mar 22 2023, 9:17 PM
wrengr added a parent revision: D146083: [mlir][sparse] Updating the `Merger::{exp,lat,set}` methods to return const.
wrengr removed a parent revision: D146561: [mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test.
wrengr updated this revision to Diff 507590.Mar 22 2023, 9:21 PM

rebase, and removing D146561 as a dependency

Harbormaster completed remote builds in B221205: Diff 507590.Mar 22 2023, 9:38 PM
wrengr updated this revision to Diff 508217.Mar 24 2023, 2:37 PM

rebase

Harbormaster completed remote builds in B221684: Diff 508217.Mar 24 2023, 2:54 PM
Closed by commit rGb3379538e8bd: [mlir][sparse] Misc cleanup in Merger.h (authored by wrengr). · Explain WhyMar 24 2023, 3:06 PM
This revision was automatically updated to reflect the committed changes.
wrengr added a commit: rGb3379538e8bd: [mlir][sparse] Misc cleanup in Merger.h.

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
SparseTensor/
Utils/
18 lines

Diff 508223

View Options

mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h

Loading...