Page MenuHomePhabricator
Differential D146691

[mlir][sparse] Introducing iterators for TensorId, LoopId, TensorLoopId
Needs ReviewPublic
Actions

Authored by wrengr on Mar 22 2023, 10:40 PM.

Details

Reviewers
aartbik
bixia
Peiming
nicolasvasilache
Summary

Client code frequently wants to iterate over the values of these three types. This commit introduces the iterators themselves, whereas the next commit will perform the actual conversion from typedefs to newtypes.

Depends On D146690

Diff Detail

Event Timeline

wrengr created this revision.Mar 22 2023, 10:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2023, 10:40 PM
Herald added subscribers: hanchung, jsetoain, Moerafaat and 20 others. · View Herald Transcript
wrengr requested review of this revision.Mar 22 2023, 10:40 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 22 2023, 10:40 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B221224: Diff 507611.Mar 22 2023, 10:41 PM
wrengr updated this revision to Diff 507613.Mar 22 2023, 10:45 PM

git-clang-format

Harbormaster completed remote builds in B221225: Diff 507613.Mar 22 2023, 10:46 PM
wrengr added a child revision: D146693: [mlir][sparse] Introducing newtypes for TensorId, LoopId, TensorLoopId.Mar 22 2023, 10:55 PM
wrengr updated this revision to Diff 508264.Mar 24 2023, 6:51 PM

rebase

Harbormaster completed remote builds in B221715: Diff 508264.Mar 24 2023, 6:51 PM
wrengr updated this revision to Diff 508266.Mar 24 2023, 7:00 PM

rebase

Harbormaster completed remote builds in B221717: Diff 508266.Mar 24 2023, 7:18 PM
wrengr mentioned this in D147011: [mlir][sparse] Replace Element with ElementId for sorting..Mar 28 2023, 6:11 PM
Peiming added inline comments.Mar 29 2023, 10:29 AM
mlir/include/mlir/Dialect/SparseTensor/Utils/MergerNewtypes.h
269–277

Isn't it too heavy for a such a simple concept? I would prefer a foreach function for the same purpose.

wrengr mentioned this in D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.Mar 29 2023, 12:17 PM
wrengr updated this revision to Diff 509498.Mar 29 2023, 4:32 PM
wrengr mentioned this in D146690: [mlir][sparse] Introducing newtypes for ExprId, LatPointId, LatSetId.

rebasing for the postponement splitting of D146684

Harbormaster completed remote builds in B222611: Diff 509498.Mar 29 2023, 4:46 PM

Revision Contents
Changeset List

PathSize
mlir/
include/
mlir/
Dialect/
SparseTensor/
Utils/
58 lines
194 lines
lib/
Dialect/
SparseTensor/
Transforms/
4 lines
4 lines
26 lines
Utils/
33 lines

Diff 509498

View Options

mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h

Loading...
View Options

mlir/include/mlir/Dialect/SparseTensor/Utils/MergerNewtypes.h

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp

Loading...
View Options

mlir/lib/Dialect/SparseTensor/Utils/Merger.cpp

Loading...