This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] Introducing iterators for TensorId, LoopId, TensorLoopId
Needs ReviewPublic

Authored by wrengr on Mar 22 2023, 10:40 PM.



Client code frequently wants to iterate over the values of these three types. This commit introduces the iterators themselves, whereas the next commit will perform the actual conversion from typedefs to newtypes.

Depends On D146690

Diff Detail

Event Timeline

wrengr created this revision.Mar 22 2023, 10:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 22 2023, 10:40 PM
wrengr requested review of this revision.Mar 22 2023, 10:40 PM
wrengr updated this revision to Diff 507613.Mar 22 2023, 10:45 PM


Peiming added inline comments.Mar 29 2023, 10:29 AM

Isn't it too heavy for a such a simple concept? I would prefer a foreach function for the same purpose.

aartbik resigned from this revision.Aug 22 2023, 5:57 PM