This commit converts these types from typedefs to newtypes. In addition this allows cleaning up some other code (because we couldn't overload things by type before), such as the TensorExp constructor.
Depends On D146691
Paths
| Differential D146693
[mlir][sparse] Introducing newtypes for TensorId, LoopId, TensorLoopId Needs ReviewPublic Authored by wrengr on Mar 22 2023, 10:55 PM.
Details
Summary This commit converts these types from typedefs to newtypes. In addition this allows cleaning up some other code (because we couldn't overload things by type before), such as the TensorExp constructor. Depends On D146691
Diff Detail
Event Timeline
wrengr mentioned this in D146690: [mlir][sparse] Introducing newtypes for ExprId, LatPointId, LatSetId. Comment Actionsrebasing for the postponement splitting of D146684
Revision Contents
Diff 507615 mlir/include/mlir/Dialect/SparseTensor/Utils/Merger.h
mlir/include/mlir/Dialect/SparseTensor/Utils/MergerNewtypes.h
mlir/lib/Dialect/SparseTensor/Transforms/CodegenEnv.cpp
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.h
mlir/lib/Dialect/SparseTensor/Transforms/LoopEmitter.cpp
mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorRewriting.cpp
mlir/lib/Dialect/SparseTensor/Transforms/Sparsification.cpp
|
Why using operation * instead of operator unsigned() to convert it implicitly to unsigned for array indexing?