Page MenuHomePhabricator
Differential D146561

[mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test
ClosedPublic
Actions

Authored by wrengr on Mar 21 2023, 1:33 PM.

Details

Reviewers
aartbik
bixia
Peiming
nicolasvasilache
Commits
rG164b918d7377: [mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test
Summary

This is a preliminary change to make way for converting the Merger's identifier types from mere typedefs to actual types (which causes some issues that this patch fixes).

Depends On D146676

Diff Detail

Event Timeline

wrengr created this revision.Mar 21 2023, 1:33 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2023, 1:33 PM
Herald added subscribers: hanchung, jsetoain, Moerafaat and 20 others. · View Herald Transcript
wrengr requested review of this revision.Mar 21 2023, 1:33 PM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptMar 21 2023, 1:33 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B220824: Diff 507109.Mar 21 2023, 1:34 PM
wrengr added a child revision: D146562: [mlir][sparse] Misc cleanup in Merger.h.Mar 21 2023, 1:40 PM
wrengr updated this revision to Diff 507582.Mar 22 2023, 8:30 PM

rebase

Harbormaster completed remote builds in B221196: Diff 507582.Mar 22 2023, 8:31 PM
wrengr removed a child revision: D146562: [mlir][sparse] Misc cleanup in Merger.h.Mar 22 2023, 9:17 PM
wrengr mentioned this in D146562: [mlir][sparse] Misc cleanup in Merger.h.Mar 22 2023, 9:21 PM
wrengr added a child revision: D146684: [mlir][sparse] Preliminary code changes for ExprId, LatPointId, LatSetId newtypes.Mar 22 2023, 9:34 PM
wrengr edited the summary of this revision. (Show Details)Mar 22 2023, 9:47 PM
wrengr added a parent revision: D146676: [mlir][sparse] Factoring out LoopEmitter::isValidLevel.
wrengr removed a parent revision: D146083: [mlir][sparse] Updating the `Merger::{exp,lat,set}` methods to return const.
wrengr updated this revision to Diff 507599.Mar 22 2023, 9:53 PM

rebase

Harbormaster completed remote builds in B221213: Diff 507599.Mar 22 2023, 9:54 PM
wrengr updated this revision to Diff 508233.Mar 24 2023, 3:49 PM

rebase

Harbormaster completed remote builds in B221694: Diff 508233.Mar 24 2023, 4:24 PM
aartbik accepted this revision.Mar 27 2023, 4:10 PM
This revision is now accepted and ready to land.Mar 27 2023, 4:10 PM
Closed by commit rG164b918d7377: [mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test (authored by wrengr). · Explain WhyMar 28 2023, 11:25 AM
This revision was automatically updated to reflect the committed changes.
wrengr added a commit: rG164b918d7377: [mlir][sparse] Removing shared_ptr from the MergerTest.cpp unit test.
wrengr mentioned this in D147090: [mlir][sparse] Fixing -Wignored-reference-qualifiers in MergerTest.cpp.Mar 28 2023, 2:48 PM
wrengr mentioned this in rG0ceec3ebfcf3: [mlir][sparse] Fixing -Wignored-reference-qualifiers in MergerTest.cpp.Mar 28 2023, 4:33 PM

Revision Contents
Changeset List

PathSize
mlir/
unittests/
Dialect/
SparseTensor/
474 lines

Diff 509081

View Options

mlir/unittests/Dialect/SparseTensor/MergerTest.cpp

Loading...