This is an archive of the discontinued LLVM Phabricator instance.

Precommit test for #61120
ClosedPublic

Authored by junaire on Mar 21 2023, 4:19 AM.

Details

Reviewers
RKSimon
Summary

Signed-off-by: Jun Zhang <jun@junz.org>

Diff Detail

Event Timeline

junaire created this revision.Mar 21 2023, 4:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2023, 4:19 AM
Herald added a subscriber: pengfei. · View Herald Transcript
junaire requested review of this revision.Mar 21 2023, 4:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 21 2023, 4:19 AM
junaire updated this revision to Diff 506924.Mar 21 2023, 5:24 AM

Add more tests

Please can you add remaining icmp predicates - I think we still need sge/uge/eq/ne?

llvm/test/CodeGen/X86/setcc-combine.ll
503

maybe rename these to @cmp_not_????? to better explain the test

584

Please can you add at least one test with the constant on the LHS, to check that existing canonicalization will commute it.

640

<2 x i64> are interesting due to the weak support pre-SSE4 but it'd be good have some other vector types as well

junaire updated this revision to Diff 507264.Mar 22 2023, 1:31 AM
  1. Rename tests.
  2. Add more preds tests
  3. Use <3 x i64> for vector tests but also keep one for <2 x i64>
  4. Add commute tests
junaire marked 3 inline comments as done.Mar 22 2023, 1:36 AM

The <3 x i64> is interesting - but I meant other legal SSE vector types likes <16 x i8> / <8 x i16> / <4 x i32>

junaire updated this revision to Diff 507362.Mar 22 2023, 7:42 AM

Use legal SSE types <4 x i32>

RKSimon accepted this revision.Mar 22 2023, 9:13 AM

LGTM - cheers

This revision is now accepted and ready to land.Mar 22 2023, 9:13 AM