Signed-off-by: Jun Zhang <jun@junz.org>
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Unit Tests
Unit Tests
Event Timeline
Comment Actions
Please can you add remaining icmp predicates - I think we still need sge/uge/eq/ne?
llvm/test/CodeGen/X86/setcc-combine.ll | ||
---|---|---|
503 | maybe rename these to @cmp_not_????? to better explain the test | |
584 | Please can you add at least one test with the constant on the LHS, to check that existing canonicalization will commute it. | |
640 | <2 x i64> are interesting due to the weak support pre-SSE4 but it'd be good have some other vector types as well |
Comment Actions
- Rename tests.
- Add more preds tests
- Use <3 x i64> for vector tests but also keep one for <2 x i64>
- Add commute tests
Comment Actions
The <3 x i64> is interesting - but I meant other legal SSE vector types likes <16 x i8> / <8 x i16> / <4 x i32>
maybe rename these to @cmp_not_????? to better explain the test