This is an archive of the discontinued LLVM Phabricator instance.

[RISCV] Remove isCall instruction flag from JAL/JALR

Authored by jobnoorman on Mar 20 2023, 10:01 AM.



As far as I can tell, the instruction flags set in the various
RISCVInstrInfo*.td files are always under-approximations. That is,
something like isTerminator will only be set for opcodes that are
*always* terminators.

The exception seems to be isCall; this is set for JAL/JALR while these
instruction are not always calls. This patch proposes to remove isCall
from JAL/JALR for consistency.

A follow-up patch will add more detailed analysis of some instruction
properties based on MCInstrAnalysis.

Diff Detail

Event Timeline

jobnoorman created this revision.Mar 20 2023, 10:01 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 20 2023, 10:01 AM
jobnoorman requested review of this revision.Mar 20 2023, 10:01 AM
This revision is now accepted and ready to land.Mar 23 2023, 11:02 PM
asb accepted this revision.Mar 27 2023, 1:52 AM


This revision was landed with ongoing or failed builds.Mar 27 2023, 7:14 AM
This revision was automatically updated to reflect the committed changes.