Details

Reviewers

njames93
ChuanqiXu
carlosgalvezp
aaron.ballman

Commits

rG17d403f66443: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check

Summary

This commit implements check for CP.51 C++ Core Guidelines

Depends on D137514

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

PiotrZSL created this revision.Mar 9 2023, 12:40 PM

Herald added a reviewer: njames93. · View Herald TranscriptMar 9 2023, 12:40 PM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: carlosgalvezp, ChuanqiXu, shchenz and 3 others. · View Herald Transcript

PiotrZSL requested review of this revision.Mar 9 2023, 12:40 PM

Herald added a project: Restricted Project. · View Herald TranscriptMar 9 2023, 12:40 PM

Herald added a subscriber: cfe-commits. · View Herald Transcript

Harbormaster completed remote builds in B218477: Diff 503883.Mar 9 2023, 12:41 PM

Change base-line

PiotrZSL added reviewers: ChuanqiXu, carlosgalvezp.Mar 9 2023, 12:51 PM

Eugene.Zelenko added a subscriber: Eugene.Zelenko.Mar 9 2023, 1:04 PM

Eugene.Zelenko added inline comments.

clang-tools-extra/docs/ReleaseNotes.rst
126–128	Just `Flags`.
clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-capturing-lambda-coroutines.rst
6–24	Ditto.

Eugene.Zelenko added a reviewer: aaron.ballman.Mar 9 2023, 1:04 PM

PiotrZSL marked 2 inline comments as done.Mar 9 2023, 1:08 PM

Improve documentation (review comments)

Change baseline

Harbormaster completed remote builds in B218523: Diff 503940.Mar 9 2023, 4:08 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Mar 9 2023, 6:09 PM

Closed by commit rG17d403f66443: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check (authored by PiotrZSL). · Explain WhyMar 10 2023, 6:07 AM

This revision was automatically updated to reflect the committed changes.

PiotrZSL added a commit: rG17d403f66443: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check.

[clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 503940

clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapturingLambdaCoroutinesCheck.h

clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapturingLambdaCoroutinesCheck.cpp

clang-tools-extra/docs/ReleaseNotes.rst

clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-capturing-lambda-coroutines.rst

clang-tools-extra/docs/clang-tidy/checks/list.rst

clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/Inputs/system/coroutines.h

clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-capturing-lambda-coroutines.cpp

[clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines checkClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 503940

clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapturingLambdaCoroutinesCheck.h

clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapturingLambdaCoroutinesCheck.cpp

clang-tools-extra/docs/ReleaseNotes.rst

clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-capturing-lambda-coroutines.rst

clang-tools-extra/docs/clang-tidy/checks/list.rst

clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/Inputs/system/coroutines.h

clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-capturing-lambda-coroutines.cpp

[clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check
ClosedPublic
Actions

Revision Contents
Changeset List