Page MenuHomePhabricator
Differential D145720

[clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check
ClosedPublic
Actions

Authored by PiotrZSL on Thu, Mar 9, 12:40 PM.

Details

Reviewers
njames93
ChuanqiXu
carlosgalvezp
aaron.ballman
Commits
rG17d403f66443: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check
Summary

This commit implements check for CP.51 C++ Core Guidelines

Depends on D137514

Diff Detail

Event Timeline

PiotrZSL created this revision.Thu, Mar 9, 12:40 PM
Herald added a reviewer: njames93. · View Herald TranscriptThu, Mar 9, 12:40 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: carlosgalvezp, ChuanqiXu, shchenz and 3 others. · View Herald Transcript
PiotrZSL requested review of this revision.Thu, Mar 9, 12:40 PM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Mar 9, 12:40 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Harbormaster completed remote builds in B218477: Diff 503883.Thu, Mar 9, 12:41 PM
PiotrZSL updated this revision to Diff 503889.Thu, Mar 9, 12:48 PM

Change base-line

PiotrZSL added reviewers: ChuanqiXu, carlosgalvezp.Thu, Mar 9, 12:51 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.Thu, Mar 9, 1:04 PM
Eugene.Zelenko added inline comments.
clang-tools-extra/docs/ReleaseNotes.rst
126–128

Just Flags.

clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-capturing-lambda-coroutines.rst
6–24

Ditto.

Eugene.Zelenko added a reviewer: aaron.ballman.Thu, Mar 9, 1:04 PM
PiotrZSL marked 2 inline comments as done.Thu, Mar 9, 1:08 PM
PiotrZSL updated this revision to Diff 503907.Thu, Mar 9, 1:08 PM

Improve documentation (review comments)

PiotrZSL updated this revision to Diff 503940.Thu, Mar 9, 2:47 PM

Change baseline

Harbormaster completed remote builds in B218523: Diff 503940.Thu, Mar 9, 4:08 PM
ChuanqiXu accepted this revision.Thu, Mar 9, 6:09 PM

LGTM. Thanks!

This revision is now accepted and ready to land.Thu, Mar 9, 6:09 PM
Closed by commit rG17d403f66443: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check (authored by PiotrZSL). · Explain WhyFri, Mar 10, 6:07 AM
This revision was automatically updated to reflect the committed changes.
PiotrZSL added a commit: rG17d403f66443: [clang-tidy] Finish cppcoreguidelines-avoid-capturing-lambda-coroutines check.

Revision Contents
Changeset List

PathSize
clang-tools-extra/
clang-tidy/
cppcoreguidelines/
17 lines
44 lines
docs/
6 lines
clang-tidy/
checks/
cppcoreguidelines/
69 lines
2 lines
test/
clang-tidy/
checkers/
cppcoreguidelines/
Inputs/
system/
32 lines
19 lines

Diff 504124

View Options

clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapturingLambdaCoroutinesCheck.h

Loading...
View Options

clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCapturingLambdaCoroutinesCheck.cpp

Loading...
View Options

clang-tools-extra/docs/ReleaseNotes.rst

Loading...
View Options

clang-tools-extra/docs/clang-tidy/checks/cppcoreguidelines/avoid-capturing-lambda-coroutines.rst

Loading...
View Options

clang-tools-extra/docs/clang-tidy/checks/list.rst

Loading...
View Options

clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/Inputs/system/coroutines.h

Loading...
View Options

clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/avoid-capturing-lambda-coroutines.cpp

Loading...