This is an archive of the discontinued LLVM Phabricator instance.

Refactor the mlir-opt command line options related to debugging in a helper
ClosedPublic

Authored by mehdi_amini on Feb 25 2023, 10:19 PM.

Details

Summary

This makes it reusable across various tooling and reduces the amount of
boilerplate needed.

Diff Detail

Event Timeline

mehdi_amini created this revision.Feb 25 2023, 10:19 PM
mehdi_amini requested review of this revision.Feb 25 2023, 10:19 PM
Mogball accepted this revision.Mar 6 2023, 11:57 AM
Mogball added a subscriber: Mogball.

LGTM

mlir/lib/Debug/CLOptionsSetup.cpp
61–66
This revision is now accepted and ready to land.Mar 6 2023, 11:57 AM
rriddle added inline comments.Mar 13 2023, 12:20 AM
mlir/include/mlir/Debug/CLOptionsSetup.h
31–33
35

Is there a better name than GDB? Would remove a lot of questions of "what about lldb?"

mehdi_amini added inline comments.Mar 13 2023, 6:02 AM
mlir/include/mlir/Debug/CLOptionsSetup.h
35

I don't know, I tend to use "gdb" for the debugger, but what about simply "Debugger"?

This revision was landed with ongoing or failed builds.Apr 24 2023, 2:34 PM
This revision was automatically updated to reflect the committed changes.