Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

tlongeri (Tomás Longeri)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 15 2022, 5:25 PM (66 w, 4 d)

Recent Activity

Apr 4 2023

tlongeri updated the diff for D147583: Fix bazel overlay after "[mlir] Introduce IRDL dialect".

More missing direct dep

Apr 4 2023, 5:59 PM · Restricted Project, Restricted Project
tlongeri updated the diff for D147583: Fix bazel overlay after "[mlir] Introduce IRDL dialect".

Missing direct dep

Apr 4 2023, 5:43 PM · Restricted Project, Restricted Project
tlongeri added reviewers for D147583: Fix bazel overlay after "[mlir] Introduce IRDL dialect": mehdi_amini, rdzhabarov.
Apr 4 2023, 5:38 PM · Restricted Project, Restricted Project
tlongeri updated the diff for D147583: Fix bazel overlay after "[mlir] Introduce IRDL dialect".

Fix missing deps

Apr 4 2023, 5:29 PM · Restricted Project, Restricted Project
tlongeri updated the diff for D147583: Fix bazel overlay after "[mlir] Introduce IRDL dialect".

More fix whitespace

Apr 4 2023, 4:57 PM · Restricted Project, Restricted Project
tlongeri updated the diff for D147583: Fix bazel overlay after "[mlir] Introduce IRDL dialect".

Fix whitespace

Apr 4 2023, 4:55 PM · Restricted Project, Restricted Project
tlongeri requested review of D147583: Fix bazel overlay after "[mlir] Introduce IRDL dialect".
Apr 4 2023, 4:50 PM · Restricted Project, Restricted Project

Oct 28 2022

tlongeri retitled D136910: Enable copy and move construction/assignment for ElementsAttrIterator from Add copy and move construction/assignment to ElementsAttrIterator to Enable copy and move construction/assignment for ElementsAttrIterator.
Oct 28 2022, 11:56 AM · Restricted Project, Restricted Project

Oct 27 2022

tlongeri added a comment to D136910: Enable copy and move construction/assignment for ElementsAttrIterator.

I assume we couldn't just set some of these to = default;?

Oct 27 2022, 8:38 PM · Restricted Project, Restricted Project
tlongeri updated the summary of D136910: Enable copy and move construction/assignment for ElementsAttrIterator.
Oct 27 2022, 8:37 PM · Restricted Project, Restricted Project
tlongeri updated the diff for D136910: Enable copy and move construction/assignment for ElementsAttrIterator.

Only define construction and assignment for ElementsAttrIndexer and let the compiler define the ones for ElementsAttrIterator

Oct 27 2022, 7:56 PM · Restricted Project, Restricted Project
tlongeri requested review of D136910: Enable copy and move construction/assignment for ElementsAttrIterator.
Oct 27 2022, 7:31 PM · Restricted Project, Restricted Project
tlongeri added a comment to D136777: llvm::zip should not require assignment operator.

I've got mixed feelings - the mechanics of the change seem fine, but iterator requirements include copy assignability and copy constructibility - so whatever iterator you're going to use with this feature isn't implementing the iterator requirements and probably should be fixed?

Oct 27 2022, 3:37 PM · Restricted Project, Restricted Project

Oct 26 2022

tlongeri updated the diff for D136777: llvm::zip should not require assignment operator.

clang-format

Oct 26 2022, 10:14 PM · Restricted Project, Restricted Project
tlongeri updated the diff for D136777: llvm::zip should not require assignment operator.

Add zip test. Fix tup_inc incorrectly remaining const. Rename increment_or_end to increment_if_not_end.

Oct 26 2022, 6:25 PM · Restricted Project, Restricted Project
tlongeri requested review of D136777: llvm::zip should not require assignment operator.
Oct 26 2022, 12:00 PM · Restricted Project, Restricted Project

Oct 17 2022

tlongeri updated the diff for D135924: Fix #58322: Handlers for debug actions with equal parameter types must not override each other.

Updating documentation (DebugActions.md)

Oct 17 2022, 11:12 AM · Restricted Project, Restricted Project

Oct 13 2022

tlongeri updated the diff for D135924: Fix #58322: Handlers for debug actions with equal parameter types must not override each other.

Actually fix the TypeID errors

Oct 13 2022, 6:44 PM · Restricted Project, Restricted Project
tlongeri updated the diff for D135924: Fix #58322: Handlers for debug actions with equal parameter types must not override each other.

Fix TypeID errors

Oct 13 2022, 6:24 PM · Restricted Project, Restricted Project
tlongeri added inline comments to D135924: Fix #58322: Handlers for debug actions with equal parameter types must not override each other.
Oct 13 2022, 4:06 PM · Restricted Project, Restricted Project
tlongeri retitled D135924: Fix #58322: Handlers for debug actions with equal parameter types must not override each other from Fix handlers for debug actions with equal parameter types overriding each other to Fix #58322: Handlers for debug actions with equal parameter types must not override each other.
Oct 13 2022, 3:57 PM · Restricted Project, Restricted Project
tlongeri requested review of D135924: Fix #58322: Handlers for debug actions with equal parameter types must not override each other.
Oct 13 2022, 3:50 PM · Restricted Project, Restricted Project

Sep 12 2022

tlongeri abandoned D133712: Move template function implementation to header (DownscaleSizeOneWindowed2DConvolution::returningMatchAndRewrite).

Issue was solved in 2b882f844e41

Sep 12 2022, 11:22 AM · Restricted Project, Restricted Project
tlongeri removed reviewers for D133712: Move template function implementation to header (DownscaleSizeOneWindowed2DConvolution::returningMatchAndRewrite): nicolasvasilache, rdzhabarov, mehdi_amini.
Sep 12 2022, 10:46 AM · Restricted Project, Restricted Project
tlongeri retitled D133712: Move template function implementation to header (DownscaleSizeOneWindowed2DConvolution::returningMatchAndRewrite) from Move template function implementation to header (DownscaleSizeOneWindowed2DConvolution::returninMatchAndRewrite) to Move template function implementation to header (DownscaleSizeOneWindowed2DConvolution::returningMatchAndRewrite).
Sep 12 2022, 10:41 AM · Restricted Project, Restricted Project
tlongeri added reviewers for D133712: Move template function implementation to header (DownscaleSizeOneWindowed2DConvolution::returningMatchAndRewrite): rdzhabarov, mehdi_amini.
Sep 12 2022, 10:41 AM · Restricted Project, Restricted Project
tlongeri requested review of D133712: Move template function implementation to header (DownscaleSizeOneWindowed2DConvolution::returningMatchAndRewrite).
Sep 12 2022, 10:38 AM · Restricted Project, Restricted Project

Jun 16 2022

tlongeri added a comment to D127927: [NFC] Correct comment: exponentially -> quadratically.

Probing is at hash, hash + 1, hash + 1 + 2, hash + 1 + 2 + 3... as can be seen in SmallPtrSetImplBase::FindBucketFor

Jun 16 2022, 8:46 AM · Restricted Project, Restricted Project

Jun 15 2022

tlongeri retitled D127927: [NFC] Correct comment: exponentially -> quadratically from Correct comment: exponentially -> quadratically to [NFC] Correct comment: exponentially -> quadratically.
Jun 15 2022, 6:21 PM · Restricted Project, Restricted Project
tlongeri requested review of D127927: [NFC] Correct comment: exponentially -> quadratically.
Jun 15 2022, 6:19 PM · Restricted Project, Restricted Project