Thanks for the reviews! Can someone land this for me? (no commit access)

In D91365#2392031, @scotttodd wrote:

In D91365#2391919, @ftynse wrote:

In D91365#2391787, @scotttodd wrote:

There's potential for a more generic solution here. I tried passing a ArrayRef<llvm::Module::ModuleFlagEntry> through: https://github.com/ScottTodd/llvm-project/commit/e276941578e8afd1f77380eceb9d76cd1b11b41c , but I think something using attributes on the Operation might be better. For projects not using memrefs, the "malloc" and "free" functions could also be optional.

Can we just add a triple as a module attribute similarly to what we already have for DataLayout? module attributes {llvm.data_layout = "E", llvm.triple = "x86-windows-msvc"} {...}. There is always at least the top-level module. One caveat is that we need to make sure LLVM doesn't exit(1) if it fails to parse the triple.

Yep, that looks good to me. Any suggestions on avoiding the exit(1)?

Add tests for llvm.target_triple attribute handling.

In D91365#2391919, @ftynse wrote:

In D91365#2391787, @scotttodd wrote:

There's potential for a more generic solution here. I tried passing a ArrayRef<llvm::Module::ModuleFlagEntry> through: https://github.com/ScottTodd/llvm-project/commit/e276941578e8afd1f77380eceb9d76cd1b11b41c , but I think something using attributes on the Operation might be better. For projects not using memrefs, the "malloc" and "free" functions could also be optional.

Can we just add a triple as a module attribute similarly to what we already have for DataLayout? module attributes {llvm.data_layout = "E", llvm.triple = "x86-windows-msvc"} {...}. There is always at least the top-level module. One caveat is that we need to make sure LLVM doesn't exit(1) if it fails to parse the triple.

Use LLVM Dialect attribute to pass llvm::Triple string to DebugTranslation.cpp.

There's potential for a more generic solution here. I tried passing a ArrayRef<llvm::Module::ModuleFlagEntry> through: https://github.com/ScottTodd/llvm-project/commit/e276941578e8afd1f77380eceb9d76cd1b11b41c , but I think something using attributes on the Operation might be better. For projects not using memrefs, the "malloc" and "free" functions could also be optional.

In D88512#2302324, @mehdi_amini wrote:

(you local commit is based of f20918b4b15 apparently)

Rebase on master.

BTW, this is my first patch to LLVM/MLIR, so I think I'll need help submitting/merging. Not sure about the "patch does not apply" build failures - I think there are no conflicts...

Move Symbol docs to Traits.md and update language.