Page MenuHomePhabricator

scotttodd (Scott Todd)
User

Projects

User does not belong to any projects.

User Details

User Since
Sep 29 2020, 11:20 AM (86 w, 2 d)

Recent Activity

Dec 13 2021

scotttodd accepted D115645: [NFC] Generalize a couple of passes so they can operate on any FunctionLike op..
Dec 13 2021, 11:19 AM · Restricted Project

Dec 10 2021

scotttodd accepted D115541: [mlir][spirv] Propagate LogicalResult in (de)serialization.
Dec 10 2021, 11:02 AM · Restricted Project
scotttodd accepted D115534: [mlir][spirv] Change default subgroup size.
Dec 10 2021, 9:15 AM · Restricted Project
scotttodd accepted D115532: [mlir][spirv] Avoid duplicated Block decoration during serialization.
Dec 10 2021, 9:03 AM · Restricted Project
scotttodd accepted D115531: [mlir][spirv] Add serialization control to emit symbol name.
Dec 10 2021, 9:00 AM · Restricted Project

Jul 8 2021

scotttodd accepted D105656: [mlir][bazel] Added missing MathDialect dep to LinalgOps target.
Jul 8 2021, 1:45 PM · Restricted Project

May 11 2021

scotttodd accepted D102276: [mlir][tosa] Tosa elementwise broadcasting had some minor bugs.
May 11 2021, 2:00 PM · Restricted Project
scotttodd accepted D102276: [mlir][tosa] Tosa elementwise broadcasting had some minor bugs.
May 11 2021, 1:53 PM · Restricted Project

Nov 13 2020

scotttodd added a comment to D91365: [MLIR] Allow setting "CodeView" flag in LLVMIR translation on MSVC..

Thanks for the reviews! Can someone land this for me? (no commit access)

Nov 13 2020, 8:05 AM · Restricted Project

Nov 12 2020

scotttodd added a comment to D91365: [MLIR] Allow setting "CodeView" flag in LLVMIR translation on MSVC..

There's potential for a more generic solution here. I tried passing a ArrayRef<llvm::Module::ModuleFlagEntry> through: https://github.com/ScottTodd/llvm-project/commit/e276941578e8afd1f77380eceb9d76cd1b11b41c , but I think something using attributes on the Operation might be better. For projects not using memrefs, the "malloc" and "free" functions could also be optional.

Can we just add a triple as a module attribute similarly to what we already have for DataLayout? module attributes {llvm.data_layout = "E", llvm.triple = "x86-windows-msvc"} {...}. There is always at least the top-level module. One caveat is that we need to make sure LLVM doesn't exit(1) if it fails to parse the triple.

Yep, that looks good to me. Any suggestions on avoiding the exit(1)?

Nov 12 2020, 1:37 PM · Restricted Project
scotttodd updated the diff for D91365: [MLIR] Allow setting "CodeView" flag in LLVMIR translation on MSVC..

Add tests for llvm.target_triple attribute handling.

Nov 12 2020, 11:41 AM · Restricted Project
scotttodd added a comment to D91365: [MLIR] Allow setting "CodeView" flag in LLVMIR translation on MSVC..

There's potential for a more generic solution here. I tried passing a ArrayRef<llvm::Module::ModuleFlagEntry> through: https://github.com/ScottTodd/llvm-project/commit/e276941578e8afd1f77380eceb9d76cd1b11b41c , but I think something using attributes on the Operation might be better. For projects not using memrefs, the "malloc" and "free" functions could also be optional.

Can we just add a triple as a module attribute similarly to what we already have for DataLayout? module attributes {llvm.data_layout = "E", llvm.triple = "x86-windows-msvc"} {...}. There is always at least the top-level module. One caveat is that we need to make sure LLVM doesn't exit(1) if it fails to parse the triple.

Nov 12 2020, 11:16 AM · Restricted Project
scotttodd updated the diff for D91365: [MLIR] Allow setting "CodeView" flag in LLVMIR translation on MSVC..

Use LLVM Dialect attribute to pass llvm::Triple string to DebugTranslation.cpp.

Nov 12 2020, 11:14 AM · Restricted Project
scotttodd added a comment to D91365: [MLIR] Allow setting "CodeView" flag in LLVMIR translation on MSVC..

There's potential for a more generic solution here. I tried passing a ArrayRef<llvm::Module::ModuleFlagEntry> through: https://github.com/ScottTodd/llvm-project/commit/e276941578e8afd1f77380eceb9d76cd1b11b41c , but I think something using attributes on the Operation might be better. For projects not using memrefs, the "malloc" and "free" functions could also be optional.

Nov 12 2020, 9:55 AM · Restricted Project
scotttodd requested review of D91365: [MLIR] Allow setting "CodeView" flag in LLVMIR translation on MSVC..
Nov 12 2020, 9:48 AM · Restricted Project

Sep 29 2020

scotttodd added a comment to D88512: [mlir] Update docs referencing OpTrait::Symbol..

(you local commit is based of f20918b4b15 apparently)

Sep 29 2020, 8:51 PM · Restricted Project
scotttodd updated the diff for D88512: [mlir] Update docs referencing OpTrait::Symbol..

Rebase on master.

Sep 29 2020, 8:46 PM · Restricted Project
scotttodd added a comment to D88512: [mlir] Update docs referencing OpTrait::Symbol..

BTW, this is my first patch to LLVM/MLIR, so I think I'll need help submitting/merging. Not sure about the "patch does not apply" build failures - I think there are no conflicts...

Sep 29 2020, 3:58 PM · Restricted Project
scotttodd added inline comments to D88512: [mlir] Update docs referencing OpTrait::Symbol..
Sep 29 2020, 2:38 PM · Restricted Project
scotttodd updated the diff for D88512: [mlir] Update docs referencing OpTrait::Symbol..

Move Symbol docs to Traits.md and update language.

Sep 29 2020, 2:36 PM · Restricted Project
scotttodd added a reviewer for D88512: [mlir] Update docs referencing OpTrait::Symbol.: rriddle.
Sep 29 2020, 1:49 PM · Restricted Project
scotttodd requested review of D88512: [mlir] Update docs referencing OpTrait::Symbol..
Sep 29 2020, 1:48 PM · Restricted Project