This is an archive of the discontinued LLVM Phabricator instance.

[DebugInfo] Remove `dbg.addr` from Coroutines
ClosedPublic

Authored by jryans on Feb 25 2023, 4:13 PM.

Details

Summary

This removes dbg.addr support from the Coroutines transform. This effectively
reverts the dbg.addr-only portions of 19279ffc77b8d224c447d4eb0ee0c727ab64babf
and 0b647fc5299156bf83c46aa539d6c9c39647bb36.

Part of dbg.addr removal
Discussed in https://discourse.llvm.org/t/what-is-the-status-of-dbg-addr/62898

Depends on D144794

Diff Detail

Event Timeline

jryans created this revision.Feb 25 2023, 4:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2023, 4:13 PM
jryans requested review of this revision.Feb 25 2023, 4:13 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 25 2023, 4:13 PM
jryans retitled this revision from [DebugInfo] Remove `dbg.addr` from Coroutines r=Orlando,StephenTozer,probinson,rnk to [DebugInfo] Remove `dbg.addr` from Coroutines.Feb 25 2023, 4:16 PM
jryans added a project: debug-info.
Orlando accepted this revision.Feb 27 2023, 2:13 AM
Orlando added subscribers: aprantl, gottesmm.

It looks like @aprantl and @gottesmm have touched debug-info around here recently, so cc-ing for visibility.

The code change is straight forward and LGTM.

This revision is now accepted and ready to land.Feb 27 2023, 2:13 AM
This revision was landed with ongoing or failed builds.Mar 2 2023, 1:31 AM
This revision was automatically updated to reflect the committed changes.
llvm/lib/Transforms/Coroutines/CoroSplit.cpp