Page MenuHomePhabricator

StephenTozer (Stephen Tozer)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2019, 4:12 AM (47 w, 10 h)

Recent Activity

Thu, Jan 23

StephenTozer updated the diff for D73054: Prevent explosion of debug intrinsics during jump threading.

Fix spelling error.

Thu, Jan 23, 3:17 AM · debug-info, Restricted Project
StephenTozer updated the diff for D73054: Prevent explosion of debug intrinsics during jump threading.

Add test, address nit comment. Note that some of the current test checks should pass even without this patch if commit 636c93 is not reverted, as some of the redundant debug info would be dropped.

Thu, Jan 23, 2:27 AM · debug-info, Restricted Project

Mon, Jan 20

StephenTozer created D73054: Prevent explosion of debug intrinsics during jump threading.
Mon, Jan 20, 9:30 AM · debug-info, Restricted Project
StephenTozer added a child revision for D73054: Prevent explosion of debug intrinsics during jump threading: D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.
Mon, Jan 20, 9:30 AM · debug-info, Restricted Project
StephenTozer added a parent revision for D70318: Recover debug intrinsics when killing duplicate or empty basic blocks: D73054: Prevent explosion of debug intrinsics during jump threading.
Mon, Jan 20, 9:30 AM · Restricted Project, debug-info

Wed, Jan 15

StephenTozer committed rG3191fa21be09: Use isa<UndefValue> where needed (authored by StephenTozer).
Use isa<UndefValue> where needed
Wed, Jan 15, 7:54 AM
StephenTozer committed rG24b81434a056: Add tests, code style fixes (authored by StephenTozer).
Add tests, code style fixes
Wed, Jan 15, 7:35 AM
StephenTozer committed rG80f81325b8e8: Format and use Small* data structures where appropriate (authored by StephenTozer).
Format and use Small* data structures where appropriate
Wed, Jan 15, 4:20 AM
StephenTozer committed rG6762d53b66d9: Add RemovePureUndefs to opt (authored by StephenTozer).
Add RemovePureUndefs to opt
Wed, Jan 15, 4:20 AM

Dec 19 2019

StephenTozer closed D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Merged in commit: llvmorg-10-init-12272-g89d19d60adb9

Dec 19 2019, 2:12 AM · Restricted Project

Dec 18 2019

StephenTozer committed rG89d19d60adb9: Reapply: [DebugInfo] Correctly handle salvaged casts and split fragments at ISel (authored by StephenTozer).
Reapply: [DebugInfo] Correctly handle salvaged casts and split fragments at ISel
Dec 18 2019, 8:33 AM
StephenTozer added a reverting change for rG1f3dd83cc1f2: Revert "[DebugInfo] Correctly handle salvaged casts and split fragments at ISel": rG89d19d60adb9: Reapply: [DebugInfo] Correctly handle salvaged casts and split fragments at ISel.
Dec 18 2019, 8:33 AM
StephenTozer committed rG1f3dd83cc1f2: Revert "[DebugInfo] Correctly handle salvaged casts and split fragments at ISel" (authored by StephenTozer).
Revert "[DebugInfo] Correctly handle salvaged casts and split fragments at ISel"
Dec 18 2019, 3:56 AM
StephenTozer added a reverting change for rGbb1b0bc4e574: [DebugInfo] Correctly handle salvaged casts and split fragments at ISel: rG1f3dd83cc1f2: Revert "[DebugInfo] Correctly handle salvaged casts and split fragments at ISel".
Dec 18 2019, 3:56 AM
StephenTozer committed rGbb1b0bc4e574: [DebugInfo] Correctly handle salvaged casts and split fragments at ISel (authored by StephenTozer).
[DebugInfo] Correctly handle salvaged casts and split fragments at ISel
Dec 18 2019, 3:18 AM

Dec 17 2019

StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Format, addressing review comments

Dec 17 2019, 7:38 AM · Restricted Project
StephenTozer added a comment to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

@djtodoro Does this latest change look good to you?

Dec 17 2019, 6:02 AM · Restricted Project

Dec 13 2019

StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Use shared functionality for zero/sign extension ops, fix tests

Dec 13 2019, 5:49 AM · Restricted Project
StephenTozer added inline comments to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Dec 13 2019, 1:26 AM · Restricted Project

Dec 12 2019

StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Rebased and updated for latest master, fixed clang version and unused attributes in tests.

Dec 12 2019, 9:28 AM · Restricted Project
StephenTozer committed rGe39e2b4a79c6: [DebugInfo] Prevent invalid fragments at ISel from dropping debug info (authored by StephenTozer).
[DebugInfo] Prevent invalid fragments at ISel from dropping debug info
Dec 12 2019, 5:10 AM
StephenTozer closed D70248: Disallow shift operations in debug expressions spanning multiple registers.
Dec 12 2019, 5:10 AM · Restricted Project

Dec 10 2019

StephenTozer committed rGf2ba93971ccc: Reapply: [DebugInfo] Recover debug intrinsics when killing duplicated/empty... (authored by StephenTozer).
Reapply: [DebugInfo] Recover debug intrinsics when killing duplicated/empty...
Dec 10 2019, 5:44 AM
StephenTozer added a reverting change for rG8b0780f795eb: Revert "[DebugInfo] Recover debug intrinsics when killing duplicated/empty…: rGf2ba93971ccc: Reapply: [DebugInfo] Recover debug intrinsics when killing duplicated/empty....
Dec 10 2019, 5:44 AM

Dec 6 2019

StephenTozer added inline comments to D69999: [DebugInfo] Support for DW_OP_implicit_pointer (IR Verifier and Bitcode).
Dec 6 2019, 2:00 AM · debug-info, Restricted Project

Dec 4 2019

StephenTozer committed rG8b0780f795eb: Revert "[DebugInfo] Recover debug intrinsics when killing duplicated/empty… (authored by StephenTozer).
Revert "[DebugInfo] Recover debug intrinsics when killing duplicated/empty…
Dec 4 2019, 10:50 AM
StephenTozer added a reverting change for rG72ce759928e6: [DebugInfo] Recover debug intrinsics when killing duplicated/empty basic blocks: rG8b0780f795eb: Revert "[DebugInfo] Recover debug intrinsics when killing duplicated/empty….
Dec 4 2019, 10:50 AM
StephenTozer added inline comments to D70644: [DebugInfo] Support for DW_OP_implicit_pointer (llvm.dbg_derefval).
Dec 4 2019, 9:04 AM · Restricted Project, debug-info, Restricted Project
StephenTozer committed rG72ce759928e6: [DebugInfo] Recover debug intrinsics when killing duplicated/empty basic blocks (authored by StephenTozer).
[DebugInfo] Recover debug intrinsics when killing duplicated/empty basic blocks
Dec 4 2019, 8:08 AM
StephenTozer closed D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.
Dec 4 2019, 8:08 AM · Restricted Project, debug-info
StephenTozer updated the diff for D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.

Use Undef int1 when undef-ing a DbgVariable without a type.

Dec 4 2019, 6:06 AM · Restricted Project, debug-info
StephenTozer updated the diff for D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.

Maintain order of debug intrinsics in empty block elimination, fix test

Dec 4 2019, 1:49 AM · Restricted Project, debug-info

Dec 3 2019

StephenTozer closed D70486: Make DebugVariable class available in DebugInfoMetadata.

Merged in commit: llvmorg-10-init-11043-g269a9afe25cb

Dec 3 2019, 7:55 AM · Restricted Project, debug-info
StephenTozer committed rG269a9afe25cb: [DebugInfo] Make DebugVariable class available in DebugInfoMetadata (authored by StephenTozer).
[DebugInfo] Make DebugVariable class available in DebugInfoMetadata
Dec 3 2019, 7:18 AM
StephenTozer updated the diff for D70486: Make DebugVariable class available in DebugInfoMetadata.

Rebased on master, rename getVar -> getVariable

Dec 3 2019, 5:54 AM · Restricted Project, debug-info

Dec 2 2019

StephenTozer updated the diff for D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.

Use another lambda to simplify skipping of dbg info, fix incorrect type usage in setDbgVariableUndef

Dec 2 2019, 9:02 AM · Restricted Project, debug-info
StephenTozer updated the diff for D70486: Make DebugVariable class available in DebugInfoMetadata.

Remove redundant assignment on test variable construction

Dec 2 2019, 7:08 AM · Restricted Project, debug-info
StephenTozer updated the diff for D70486: Make DebugVariable class available in DebugInfoMetadata.

Add unit test, allow nullptr for DIExpression in DebugVariable ctor

Dec 2 2019, 6:37 AM · Restricted Project, debug-info

Nov 28 2019

StephenTozer updated the diff for D70486: Make DebugVariable class available in DebugInfoMetadata.

Use NoneType() to call correct DebugVariable constructor

Nov 28 2019, 9:16 AM · Restricted Project, debug-info
StephenTozer updated the diff for D70486: Make DebugVariable class available in DebugInfoMetadata.

Clean up code, fix comments.

Nov 28 2019, 5:24 AM · Restricted Project, debug-info

Nov 27 2019

StephenTozer updated the diff for D70248: Disallow shift operations in debug expressions spanning multiple registers.

Rebased off of merged parent, trimmed unnecessary/confusing test metadata.

Nov 27 2019, 7:31 AM · Restricted Project

Nov 26 2019

StephenTozer committed rG184d72a7c6a7: [DebugInfo] Disallow fragmenting DIExpressions with shift operators (authored by StephenTozer).
[DebugInfo] Disallow fragmenting DIExpressions with shift operators
Nov 26 2019, 8:16 AM
StephenTozer closed D70601: Disallow DIExpressions with shift operators from being fragmented.
Nov 26 2019, 8:16 AM · Restricted Project, debug-info
StephenTozer added a child revision for D70248: Disallow shift operations in debug expressions spanning multiple registers: D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Nov 26 2019, 2:53 AM · Restricted Project
StephenTozer added a parent revision for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed: D70248: Disallow shift operations in debug expressions spanning multiple registers.
Nov 26 2019, 2:53 AM · Restricted Project
StephenTozer added child revisions for D70601: Disallow DIExpressions with shift operators from being fragmented: D70248: Disallow shift operations in debug expressions spanning multiple registers, D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Nov 26 2019, 2:53 AM · Restricted Project, debug-info
StephenTozer added a parent revision for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed: D70601: Disallow DIExpressions with shift operators from being fragmented.
Nov 26 2019, 2:53 AM · Restricted Project
StephenTozer added a parent revision for D70248: Disallow shift operations in debug expressions spanning multiple registers: D70601: Disallow DIExpressions with shift operators from being fragmented.
Nov 26 2019, 2:53 AM · Restricted Project

Nov 22 2019

StephenTozer created D70601: Disallow DIExpressions with shift operators from being fragmented.
Nov 22 2019, 8:53 AM · Restricted Project, debug-info
StephenTozer added a child revision for D70486: Make DebugVariable class available in DebugInfoMetadata: D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.
Nov 22 2019, 6:41 AM · Restricted Project, debug-info
StephenTozer removed a parent revision for D70486: Make DebugVariable class available in DebugInfoMetadata: D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.
Nov 22 2019, 6:41 AM · Restricted Project, debug-info
StephenTozer added a parent revision for D70318: Recover debug intrinsics when killing duplicate or empty basic blocks: D70486: Make DebugVariable class available in DebugInfoMetadata.
Nov 22 2019, 6:41 AM · Restricted Project, debug-info
StephenTozer removed a child revision for D70318: Recover debug intrinsics when killing duplicate or empty basic blocks: D70486: Make DebugVariable class available in DebugInfoMetadata.
Nov 22 2019, 6:41 AM · Restricted Project, debug-info
StephenTozer updated the diff for D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.

Fix formatting, include whole files in patch (mistakenly removed in prior revision).

Nov 22 2019, 6:32 AM · Restricted Project, debug-info
StephenTozer updated the diff for D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.
Nov 22 2019, 6:32 AM · Restricted Project, debug-info
StephenTozer added a child revision for D70318: Recover debug intrinsics when killing duplicate or empty basic blocks: D70486: Make DebugVariable class available in DebugInfoMetadata.
Nov 22 2019, 3:10 AM · Restricted Project, debug-info
StephenTozer added a parent revision for D70486: Make DebugVariable class available in DebugInfoMetadata: D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.
Nov 22 2019, 3:10 AM · Restricted Project, debug-info

Nov 21 2019

StephenTozer added inline comments to D70486: Make DebugVariable class available in DebugInfoMetadata.
Nov 21 2019, 4:43 AM · Restricted Project, debug-info
StephenTozer updated the diff for D70486: Make DebugVariable class available in DebugInfoMetadata.
Nov 21 2019, 4:12 AM · Restricted Project, debug-info

Nov 20 2019

StephenTozer updated the diff for D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.

Show correct changeset, preserve operands for dbg.declares

Nov 20 2019, 8:43 AM · Restricted Project, debug-info
StephenTozer created D70486: Make DebugVariable class available in DebugInfoMetadata.
Nov 20 2019, 3:04 AM · Restricted Project, debug-info
StephenTozer added inline comments to D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.
Nov 20 2019, 1:43 AM · Restricted Project, debug-info

Nov 19 2019

StephenTozer updated the diff for D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.

Updating according to review comments; the code in Local.cpp needs further work, but is close to its likely final state. This version also applies to master, so diffing the latest revision with the previous will give a lot of noise.

Nov 19 2019, 9:11 AM · Restricted Project, debug-info

Nov 15 2019

StephenTozer created D70318: Recover debug intrinsics when killing duplicate or empty basic blocks.
Nov 15 2019, 9:03 AM · Restricted Project, debug-info

Nov 14 2019

StephenTozer added reviewers for D70248: Disallow shift operations in debug expressions spanning multiple registers: markus, vsk, probinson, aprantl, dblaikie, djtodoro.
Nov 14 2019, 9:02 AM · Restricted Project
StephenTozer created D70248: Disallow shift operations in debug expressions spanning multiple registers.
Nov 14 2019, 9:02 AM · Restricted Project

Nov 5 2019

StephenTozer added inline comments to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Nov 5 2019, 1:54 AM · Restricted Project

Sep 9 2019

StephenTozer closed D60684: [llvm-readobj] Reapply: Improve error message for --string-dump.

This one has been merged in; it probably didn't get picked up because this review doesn't include the other changes that were reapplied in the patch.

Sep 9 2019, 2:57 AM · Restricted Project

Aug 20 2019

StephenTozer added a comment to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

The regression issue is documented in the bug above: https://bugs.llvm.org/show_bug.cgi?id=41931
The main issue can be summarised briefly as "splitting a fragment DIExpression across multiple registers is currently broken", which is what I've submitted a fix for (see comments in SelectionDAGBuilder.cpp); the test for the new behaviour is in fragmented-args-multiple-regs.ll

Aug 20 2019, 6:57 AM · Restricted Project

Aug 16 2019

StephenTozer reopened D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Reopening, as the merged patch caused a regression issue and needed to be reverted; this update should fix said regression issue.

Aug 16 2019, 9:35 AM · Restricted Project
StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Aug 16 2019, 9:35 AM · Restricted Project

Jul 26 2019

StephenTozer accepted D57145: [DebugInfo] Remove redundant initialization of DbgVariable's MInsn, NFC.

Looks like a sensible straightforward change.

Jul 26 2019, 5:55 AM · Restricted Project, debug-info

May 16 2019

StephenTozer committed rG6f59b4b6d95c: Resubmit: [Salvage] Change salvage debug info implementation to use… (authored by StephenTozer).
Resubmit: [Salvage] Change salvage debug info implementation to use…
May 16 2019, 7:40 AM

May 15 2019

StephenTozer committed rG0d02f2ff4fbe: Revert "[Salvage] Change salvage debug info implementation to use… (authored by StephenTozer).
Revert "[Salvage] Change salvage debug info implementation to use…
May 15 2019, 6:40 AM
StephenTozer committed rG17dd4d740377: [Salvage] Change salvage debug info implementation to use DW_OP_LLVM_convert… (authored by StephenTozer).
[Salvage] Change salvage debug info implementation to use DW_OP_LLVM_convert…
May 15 2019, 6:17 AM

May 14 2019

StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Update comment

May 14 2019, 6:08 AM · Restricted Project

May 3 2019

StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Remove incorrectly included lines.

May 3 2019, 2:47 AM · Restricted Project

May 2 2019

StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Updated to use convert OP correctly as suggested by markus.

May 2 2019, 9:39 AM · Restricted Project

Apr 26 2019

StephenTozer updated the summary of D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Apr 26 2019, 6:12 AM · Restricted Project
StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

As per the previous comment, ZExt is equivalent to a Noop on the DWARF expression stack, so can be caught by the same early exit.

Apr 26 2019, 6:12 AM · Restricted Project
StephenTozer created D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Apr 26 2019, 5:41 AM · Restricted Project

Apr 15 2019

StephenTozer committed rG19bb1d5739b4: [llvm-readobj] Reapply: Improve error message for --string-dump (authored by StephenTozer).
[llvm-readobj] Reapply: Improve error message for --string-dump
Apr 15 2019, 4:22 AM
StephenTozer created D60684: [llvm-readobj] Reapply: Improve error message for --string-dump.
Apr 15 2019, 3:53 AM · Restricted Project

Apr 8 2019

StephenTozer updated the diff for D59946: [llvm-readobj] Improve error message for for --string-dump.

Fixes an Object test that I missed in the last revision.

Apr 8 2019, 8:52 AM · Restricted Project

Apr 5 2019

StephenTozer committed rGbbeca849d7ba: Revert "[llvm-readobj] Improve error message for --string-dump" (authored by StephenTozer).
Revert "[llvm-readobj] Improve error message for --string-dump"
Apr 5 2019, 9:33 AM
StephenTozer added a reverting change for rG681b0798dbbc: [llvm-readobj] Improve error message for --string-dump: rGbbeca849d7ba: Revert "[llvm-readobj] Improve error message for --string-dump".
Apr 5 2019, 9:33 AM
StephenTozer committed rG681b0798dbbc: [llvm-readobj] Improve error message for --string-dump (authored by StephenTozer).
[llvm-readobj] Improve error message for --string-dump
Apr 5 2019, 9:17 AM
StephenTozer committed rGed7f8e6509ba: [format] Add correct punctuation to comment (authored by StephenTozer).
[format] Add correct punctuation to comment
Apr 5 2019, 8:58 AM

Mar 29 2019

StephenTozer updated the diff for D59946: [llvm-readobj] Improve error message for for --string-dump.

Remove unnecessary/unrelated changes.

Mar 29 2019, 4:57 AM · Restricted Project
StephenTozer updated the diff for D59946: [llvm-readobj] Improve error message for for --string-dump.

Minor code cleanups.

Mar 29 2019, 3:52 AM · Restricted Project
StephenTozer added inline comments to D59946: [llvm-readobj] Improve error message for for --string-dump.
Mar 29 2019, 3:29 AM · Restricted Project
StephenTozer added inline comments to D59946: [llvm-readobj] Improve error message for for --string-dump.
Mar 29 2019, 3:24 AM · Restricted Project
StephenTozer added inline comments to D59946: [llvm-readobj] Improve error message for for --string-dump.
Mar 29 2019, 3:21 AM · Restricted Project

Mar 28 2019

StephenTozer created D59946: [llvm-readobj] Improve error message for for --string-dump.
Mar 28 2019, 10:03 AM · Restricted Project

Mar 15 2019

StephenTozer updated the diff for D59417: [GVN] Add default debug location when constructing PHI nodes.

Update comment to give more context to the use of a Line 0 debug location.

Mar 15 2019, 9:56 AM · Restricted Project
StephenTozer created D59417: [GVN] Add default debug location when constructing PHI nodes.
Mar 15 2019, 8:21 AM · Restricted Project

Mar 11 2019

StephenTozer updated subscribers of D59206: [SimplifyCFG] Retain debug info when threading jumps with critical edges.
Mar 11 2019, 9:06 AM · Restricted Project
StephenTozer created D59206: [SimplifyCFG] Retain debug info when threading jumps with critical edges.
Mar 11 2019, 4:00 AM · Restricted Project

Mar 8 2019

StephenTozer updated the diff for D58963: [JumpThreading] Retain debug info when replacing branch instructions.

Added the test case for the second change, and reduced both it and the original test case as much as possible.

Mar 8 2019, 5:25 AM · Restricted Project

Mar 7 2019

StephenTozer added a comment to D58963: [JumpThreading] Retain debug info when replacing branch instructions.

The code change touches two places, but the test only seems to test one branch instruction - is one of the two code changes untested?

Mar 7 2019, 2:39 AM · Restricted Project