Page MenuHomePhabricator

StephenTozer (Stephen Tozer)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2019, 4:12 AM (28 w, 9 h)

Recent Activity

Mon, Sep 9

StephenTozer closed D60684: [llvm-readobj] Reapply: Improve error message for --string-dump.

This one has been merged in; it probably didn't get picked up because this review doesn't include the other changes that were reapplied in the patch.

Mon, Sep 9, 2:57 AM · Restricted Project

Tue, Aug 20

StephenTozer added a comment to D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

The regression issue is documented in the bug above: https://bugs.llvm.org/show_bug.cgi?id=41931
The main issue can be summarised briefly as "splitting a fragment DIExpression across multiple registers is currently broken", which is what I've submitted a fix for (see comments in SelectionDAGBuilder.cpp); the test for the new behaviour is in fragmented-args-multiple-regs.ll

Tue, Aug 20, 6:57 AM · Restricted Project

Aug 16 2019

StephenTozer reopened D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Reopening, as the merged patch caused a regression issue and needed to be reverted; this update should fix said regression issue.

Aug 16 2019, 9:35 AM · Restricted Project
StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Aug 16 2019, 9:35 AM · Restricted Project

Jul 26 2019

StephenTozer accepted D57145: [DebugInfo] Remove redundant initialization of DbgVariable's MInsn, NFC.

Looks like a sensible straightforward change.

Jul 26 2019, 5:55 AM · Restricted Project, debug-info

May 16 2019

StephenTozer committed rG6f59b4b6d95c: Resubmit: [Salvage] Change salvage debug info implementation to use… (authored by StephenTozer).
Resubmit: [Salvage] Change salvage debug info implementation to use…
May 16 2019, 7:40 AM

May 15 2019

StephenTozer committed rG0d02f2ff4fbe: Revert "[Salvage] Change salvage debug info implementation to use… (authored by StephenTozer).
Revert "[Salvage] Change salvage debug info implementation to use…
May 15 2019, 6:40 AM
StephenTozer committed rG17dd4d740377: [Salvage] Change salvage debug info implementation to use DW_OP_LLVM_convert… (authored by StephenTozer).
[Salvage] Change salvage debug info implementation to use DW_OP_LLVM_convert…
May 15 2019, 6:17 AM

May 14 2019

StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Update comment

May 14 2019, 6:08 AM · Restricted Project

May 3 2019

StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Remove incorrectly included lines.

May 3 2019, 2:47 AM · Restricted Project

May 2 2019

StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

Updated to use convert OP correctly as suggested by markus.

May 2 2019, 9:39 AM · Restricted Project

Apr 26 2019

StephenTozer updated the summary of D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Apr 26 2019, 6:12 AM · Restricted Project
StephenTozer updated the diff for D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.

As per the previous comment, ZExt is equivalent to a Noop on the DWARF expression stack, so can be caught by the same early exit.

Apr 26 2019, 6:12 AM · Restricted Project
StephenTozer created D61184: [Salvage] Change salvage debug info implementation to use new DW_OP_LLVM_convert where needed.
Apr 26 2019, 5:41 AM · Restricted Project

Apr 15 2019

StephenTozer committed rG19bb1d5739b4: [llvm-readobj] Reapply: Improve error message for --string-dump (authored by StephenTozer).
[llvm-readobj] Reapply: Improve error message for --string-dump
Apr 15 2019, 4:22 AM
StephenTozer created D60684: [llvm-readobj] Reapply: Improve error message for --string-dump.
Apr 15 2019, 3:53 AM · Restricted Project

Apr 8 2019

StephenTozer updated the diff for D59946: [llvm-readobj] Improve error message for for --string-dump.

Fixes an Object test that I missed in the last revision.

Apr 8 2019, 8:52 AM · Restricted Project

Apr 5 2019

StephenTozer committed rGbbeca849d7ba: Revert "[llvm-readobj] Improve error message for --string-dump" (authored by StephenTozer).
Revert "[llvm-readobj] Improve error message for --string-dump"
Apr 5 2019, 9:33 AM
StephenTozer added a reverting change for rG681b0798dbbc: [llvm-readobj] Improve error message for --string-dump: rGbbeca849d7ba: Revert "[llvm-readobj] Improve error message for --string-dump".
Apr 5 2019, 9:33 AM
StephenTozer committed rG681b0798dbbc: [llvm-readobj] Improve error message for --string-dump (authored by StephenTozer).
[llvm-readobj] Improve error message for --string-dump
Apr 5 2019, 9:17 AM
StephenTozer committed rGed7f8e6509ba: [format] Add correct punctuation to comment (authored by StephenTozer).
[format] Add correct punctuation to comment
Apr 5 2019, 8:58 AM

Mar 29 2019

StephenTozer updated the diff for D59946: [llvm-readobj] Improve error message for for --string-dump.

Remove unnecessary/unrelated changes.

Mar 29 2019, 4:57 AM · Restricted Project
StephenTozer updated the diff for D59946: [llvm-readobj] Improve error message for for --string-dump.

Minor code cleanups.

Mar 29 2019, 3:52 AM · Restricted Project
StephenTozer added inline comments to D59946: [llvm-readobj] Improve error message for for --string-dump.
Mar 29 2019, 3:29 AM · Restricted Project
StephenTozer added inline comments to D59946: [llvm-readobj] Improve error message for for --string-dump.
Mar 29 2019, 3:24 AM · Restricted Project
StephenTozer added inline comments to D59946: [llvm-readobj] Improve error message for for --string-dump.
Mar 29 2019, 3:21 AM · Restricted Project

Mar 28 2019

StephenTozer created D59946: [llvm-readobj] Improve error message for for --string-dump.
Mar 28 2019, 10:03 AM · Restricted Project

Mar 15 2019

StephenTozer updated the diff for D59417: [GVN] Add default debug location when constructing PHI nodes.

Update comment to give more context to the use of a Line 0 debug location.

Mar 15 2019, 9:56 AM · Restricted Project
StephenTozer created D59417: [GVN] Add default debug location when constructing PHI nodes.
Mar 15 2019, 8:21 AM · Restricted Project

Mar 11 2019

StephenTozer updated subscribers of D59206: [SimplifyCFG] Retain debug info when threading jumps with critical edges.
Mar 11 2019, 9:06 AM · Restricted Project
StephenTozer created D59206: [SimplifyCFG] Retain debug info when threading jumps with critical edges.
Mar 11 2019, 4:00 AM · Restricted Project

Mar 8 2019

StephenTozer updated the diff for D58963: [JumpThreading] Retain debug info when replacing branch instructions.

Added the test case for the second change, and reduced both it and the original test case as much as possible.

Mar 8 2019, 5:25 AM · Restricted Project

Mar 7 2019

StephenTozer added a comment to D58963: [JumpThreading] Retain debug info when replacing branch instructions.

The code change touches two places, but the test only seems to test one branch instruction - is one of the two code changes untested?

Mar 7 2019, 2:39 AM · Restricted Project

Mar 5 2019

StephenTozer created D58963: [JumpThreading] Retain debug info when replacing branch instructions.
Mar 5 2019, 6:31 AM · Restricted Project