Page MenuHomePhabricator

StephenTozer (Stephen Tozer)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2019, 4:12 AM (173 w, 3 d)

Recent Activity

Mon, Jun 20

StephenTozer updated the diff for D128174: [DebugInfo][InstrRef][NFC Update LDV to use generic DBG_VALUE* MI interface.

Use IsVariadic when emitting a location for an entry value.

Mon, Jun 20, 9:43 AM · debug-info, Restricted Project, Restricted Project
StephenTozer requested review of D128212: [DebugInfo] Extend the InstrRef LDV to support DbgValues with many Ops.
Mon, Jun 20, 8:43 AM · Restricted Project, Restricted Project, debug-info
StephenTozer requested review of D128211: [DebugInfo][InstrRef][NFC] Handle transfers of variadic debug values in InstrRefLDV.
Mon, Jun 20, 8:33 AM · Restricted Project, Restricted Project, debug-info
StephenTozer requested review of D128209: [DebugInfo][InstrRef][NFC] Emit variadic debug values from InstrRefLDV.
Mon, Jun 20, 7:50 AM · debug-info, Restricted Project, Restricted Project
StephenTozer requested review of D128180: [DebugInfo][InstrRef][NFC] Let LDV handle joins for lists of debug ops.
Mon, Jun 20, 3:43 AM · Restricted Project, Restricted Project, debug-info
StephenTozer requested review of D128177: [DebugInfo][InstrRef][NFC] Represent DbgValues with multiple ops in LDV.
Mon, Jun 20, 3:19 AM · Restricted Project, debug-info, Restricted Project
StephenTozer updated the summary of D128174: [DebugInfo][InstrRef][NFC Update LDV to use generic DBG_VALUE* MI interface.
Mon, Jun 20, 3:11 AM · debug-info, Restricted Project, Restricted Project
StephenTozer requested review of D128174: [DebugInfo][InstrRef][NFC Update LDV to use generic DBG_VALUE* MI interface.
Mon, Jun 20, 3:07 AM · debug-info, Restricted Project, Restricted Project

Fri, Jun 17

StephenTozer requested review of D128101: [DebugInfo][InstrRef] Fix error in copy handling in InstrRefLDV.
Fri, Jun 17, 3:00 PM · debug-info, Restricted Project, Restricted Project

Mon, Jun 13

StephenTozer committed rG6bc2ad235a83: [Dexter] Remove debugger-dependent test from windows (authored by StephenTozer).
[Dexter] Remove debugger-dependent test from windows
Mon, Jun 13, 11:28 AM · Restricted Project
StephenTozer committed rGec7c959671e8: [Dexter] Fix incorrect test expectations for floating point tests (authored by StephenTozer).
[Dexter] Fix incorrect test expectations for floating point tests
Mon, Jun 13, 11:07 AM · Restricted Project
StephenTozer committed rG30bb659c6f99: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values (authored by StephenTozer).
[Dexter] Allow Dexter watch commands to specify a range of acceptable FP values
Mon, Jun 13, 6:45 AM · Restricted Project
StephenTozer closed D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values.
Mon, Jun 13, 6:45 AM · Restricted Project, Restricted Project, debug-info

Wed, Jun 8

StephenTozer added inline comments to D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values.
Wed, Jun 8, 8:42 AM · Restricted Project, Restricted Project, debug-info
StephenTozer updated the diff for D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values.

Update name and add docstring to requested function.

Wed, Jun 8, 8:39 AM · Restricted Project, Restricted Project, debug-info
StephenTozer committed rGb03451bb9ace: [Dexter] Use PurePath to compare paths in Dexter commands (authored by StephenTozer).
[Dexter] Use PurePath to compare paths in Dexter commands
Wed, Jun 8, 8:29 AM · Restricted Project
StephenTozer closed D127099: [Dexter] Use PurePath to compare paths in Dexter commands.
Wed, Jun 8, 8:29 AM · Restricted Project, Restricted Project, debug-info
StephenTozer committed rG2a156f605805: [Dexter] Catch value error when encountering invalid address (authored by StephenTozer).
[Dexter] Catch value error when encountering invalid address
Wed, Jun 8, 8:06 AM · Restricted Project
StephenTozer closed D127101: [Dexter] Catch value error when encountering invalid address.
Wed, Jun 8, 8:06 AM · Restricted Project, Restricted Project, debug-info

Mon, Jun 6

StephenTozer requested review of D127101: [Dexter] Catch value error when encountering invalid address.
Mon, Jun 6, 4:28 AM · Restricted Project, Restricted Project, debug-info
StephenTozer requested review of D127099: [Dexter] Use PurePath to compare paths in Dexter commands.
Mon, Jun 6, 4:02 AM · Restricted Project, Restricted Project, debug-info

Jun 1 2022

StephenTozer updated the diff for D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values.

Make some changes to correctly handle the float_range=0.0 case, add tests to cover it, and change comment as requested.

Jun 1 2022, 6:36 AM · Restricted Project, Restricted Project, debug-info

May 23 2022

StephenTozer added inline comments to D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values.
May 23 2022, 3:04 AM · Restricted Project, Restricted Project, debug-info
StephenTozer updated the diff for D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values.

Remove unused "zero range" test.

May 23 2022, 2:58 AM · Restricted Project, Restricted Project, debug-info

May 19 2022

StephenTozer requested review of D125953: [DebugInfo][InstrRef] Handle joins PHI+Def values in LiveDebugValues.
May 19 2022, 1:54 AM · Restricted Project, Restricted Project, debug-info

May 13 2022

StephenTozer added a project to D124691: [Transforms] Fix a wrong debug info intrinsic call in `mem2reg` pass for ref 128-bit: debug-info.
May 13 2022, 7:30 AM · debug-info, Restricted Project, Restricted Project

Apr 28 2022

StephenTozer added inline comments to D123743: [lldb] Show the DBGError if dsymForUUID can't find a dSYM.
Apr 28 2022, 7:05 AM · Restricted Project, Restricted Project

Apr 27 2022

StephenTozer requested review of D124511: [Dexter] Allow Dexter watch commands to specify a range of acceptable FP values.
Apr 27 2022, 2:39 AM · Restricted Project, Restricted Project, debug-info

Apr 26 2022

StephenTozer accepted D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Sorry for the delay on approving this, LGTM!

Apr 26 2022, 3:27 AM · Restricted Project, Restricted Project
StephenTozer added inline comments to D105207: [debuginfo][lsr] SCEV-based salvaging for LoopStrengthReduction.
Apr 26 2022, 3:24 AM · Restricted Project, debug-info, Restricted Project

Apr 25 2022

StephenTozer accepted D124098: Don't replace Undef with null value for Constants.

Good fix, LGTM.

Apr 25 2022, 7:36 AM · Restricted Project, Restricted Project

Apr 20 2022

StephenTozer added a comment to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Still a further suggestion on the most recent change - it's a minor point, but necessary I think to not produce invalid expressions. Other than that, LGTM.

Apr 20 2022, 5:18 AM · Restricted Project, Restricted Project

Apr 11 2022

StephenTozer committed rG1c8366f9f2aa: [Dexter] Collate penalties of the same type into a single line for each (authored by StephenTozer).
[Dexter] Collate penalties of the same type into a single line for each
Apr 11 2022, 9:02 AM · Restricted Project
StephenTozer closed D120716: [Dexter] Collate penalties of the same type into a single line for each.
Apr 11 2022, 9:02 AM · Restricted Project, Restricted Project

Apr 6 2022

StephenTozer added inline comments to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Apr 6 2022, 6:31 AM · Restricted Project, Restricted Project

Mar 31 2022

StephenTozer added a comment to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].

Good patch - I've left quite a few comments, but most of them are minor nits and some are not requirements for this patch to be merged.

Mar 31 2022, 9:55 AM · Restricted Project, Restricted Project

Mar 21 2022

StephenTozer accepted D115623: [Debugify] Use DebugifyLevel in Debugify original mode.

Thanks for the change, LGTM

Mar 21 2022, 8:21 AM · Restricted Project, Restricted Project, debug-info
StephenTozer accepted D115622: [Debugify] Optimize debugify original mode.

Latest change makes sense, LGTM

Mar 21 2022, 8:10 AM · Restricted Project, Restricted Project, debug-info, Restricted Project

Mar 7 2022

StephenTozer added inline comments to D120169: [Debuginfo][LSR} Add support for salvaging variadic dbg.value intrinsics [2/2].
Mar 7 2022, 7:18 AM · Restricted Project, Restricted Project

Mar 1 2022

StephenTozer requested review of D120716: [Dexter] Collate penalties of the same type into a single line for each.
Mar 1 2022, 5:23 AM · Restricted Project, Restricted Project
StephenTozer committed rGb3f1480204e3: [Dexter] Optimize breakpoint deletion in Visual Studio (authored by StephenTozer).
[Dexter] Optimize breakpoint deletion in Visual Studio
Mar 1 2022, 5:14 AM
StephenTozer closed D120658: [Dexter] Optimize breakpoint deletion in Visual Studio.
Mar 1 2022, 5:14 AM · Restricted Project

Feb 28 2022

StephenTozer requested review of D120658: [Dexter] Optimize breakpoint deletion in Visual Studio.
Feb 28 2022, 4:50 AM · Restricted Project

Feb 23 2022

StephenTozer accepted D115616: [Debugify][OriginalDIMode] Make HTML reporting infrastructure more resilient.
Feb 23 2022, 4:26 AM · debug-info, Restricted Project

Feb 9 2022

StephenTozer added inline comments to D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan.
Feb 9 2022, 8:48 AM · Restricted Project, debug-info
StephenTozer added a comment to D118760: [cross-project-tests] Add REQUIRES: compiler-rt to tests that use asan.

LGTM apart from the comment below.

Feb 9 2022, 4:13 AM · Restricted Project, debug-info
StephenTozer accepted D119232: [DebugInfo][InstrRef] Don't create duplicate instruction numbers in X86-fixup-LEAs.

Simple fix LGTM.

Feb 9 2022, 2:55 AM · Restricted Project

Feb 2 2022

StephenTozer accepted D118715: [DebugInfo][InstrRef] Fix a tombstone-in-DenseMap crash from D117877.
Feb 2 2022, 3:54 AM · Restricted Project
StephenTozer added a comment to D118715: [DebugInfo][InstrRef] Fix a tombstone-in-DenseMap crash from D117877.

Seems reasonable as a fix to me. Is there any particular reason that the undef value test couldn't exist within the original function, or are they separated to look cleaner? YMMV and I don't feel strongly either way, so LGTM.

Feb 2 2022, 3:54 AM · Restricted Project

Jan 31 2022

StephenTozer accepted D118613: [DebugInfo][InstrRef][NFC] Bypass a frequently-noop loop.

LGTM, that's a depressingly good performance gain/prevented cost.

Jan 31 2022, 3:50 PM · Restricted Project
StephenTozer added a comment to D118455: [DebugInfo][InstrRef][NFC] Cache some PHI resolutions.

Seems like a good change - the compile time improvement is nice, and this doesn't look like it should have a noticeable memory footprint. LGTM with the other comments addressed.

Jan 31 2022, 3:44 PM · Restricted Project

Jan 28 2022

StephenTozer accepted D117877: [DebugInfo][InstrRef] Take a short-cut when propagating variable values if there's only one value.

LGTM, nice performance improvement!

Jan 28 2022, 6:02 AM · Restricted Project

Jan 26 2022

StephenTozer added a comment to D118048: [Dexter] Remove false requirement of lldb for dexter regression tests on Windows.

LGTM, with a couple of nits - good work!

Jan 26 2022, 1:44 AM · Restricted Project, debug-info

Jan 25 2022

StephenTozer added a comment to rGe5d958c45629: [DebugInfo] Support DIArgList in DbgVariableIntrinsic.

Just noting here (for future reference) the above issue should be fixed as of ea17d29a6c83.

Jan 25 2022, 8:50 AM

Jan 24 2022

StephenTozer committed rGea17d29a6c83: [llvm] Do not replace dead constant references in metadata with undef (authored by StephenTozer).
[llvm] Do not replace dead constant references in metadata with undef
Jan 24 2022, 9:39 AM
StephenTozer closed D117300: [opt] Do not replace MD refs to destroyed constants with undef.
Jan 24 2022, 9:39 AM · Restricted Project

Jan 17 2022

StephenTozer committed rG32417b320339: [DebugInfo] ValueMapper impl for DIArgList respects IgnoreMissingLocals (authored by StephenTozer).
[DebugInfo] ValueMapper impl for DIArgList respects IgnoreMissingLocals
Jan 17 2022, 9:18 AM
StephenTozer closed D114355: [DebugInfo] ValueMapper impl for DIArgList should respect RF_IgnoreMissingLocals.
Jan 17 2022, 9:18 AM · debug-info, Restricted Project

Jan 14 2022

StephenTozer added a comment to D115714: [Debugify] Limit number of processed functions for original mode.

Performance seems like a serious issue when working with large projects here, but I have some questions/thoughts about this approach:

Jan 14 2022, 5:53 AM · Restricted Project, Restricted Project, debug-info
StephenTozer requested review of D117300: [opt] Do not replace MD refs to destroyed constants with undef.
Jan 14 2022, 3:47 AM · Restricted Project

Jan 10 2022

StephenTozer added a comment to D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions.

Questions around testing aside, the code changes here LGTM.

Jan 10 2022, 11:07 AM · Restricted Project, Restricted Project

Dec 15 2021

StephenTozer added a comment to D115616: [Debugify][OriginalDIMode] Make HTML reporting infrastructure more resilient.

Change SGTM, except for the minor inline comments.

Dec 15 2021, 8:12 AM · debug-info, Restricted Project
StephenTozer added inline comments to D115616: [Debugify][OriginalDIMode] Make HTML reporting infrastructure more resilient.
Dec 15 2021, 8:12 AM · debug-info, Restricted Project
StephenTozer accepted D115621: [Debugify] Use WeakWH map collected before Pass when checking loc drop.

Trivial fix, LGTM.

Dec 15 2021, 7:23 AM · Restricted Project
StephenTozer requested changes to D115623: [Debugify] Use DebugifyLevel in Debugify original mode.

Apologies, didn't see the existing comments on this review before submitting - given that the concern has been raised by another, it may be worth making a change to confirm that debug values have been dropped, and also check the error message. A simple way to do this might be to run the test twice, using -debugify-level=locations-and-variables for the second run, with a directive CHECK: drops dbg.value()/dbg.declare() - this should solve both issues by ensuring the test only passes if we are actually dropping debug info, and we are checking for the correct error message.

Dec 15 2021, 5:03 AM · Restricted Project, Restricted Project, debug-info
StephenTozer accepted D115623: [Debugify] Use DebugifyLevel in Debugify original mode.

Aside from the mentioned nit, LGTM.

Dec 15 2021, 4:49 AM · Restricted Project, Restricted Project, debug-info
StephenTozer accepted D115622: [Debugify] Optimize debugify original mode.

Seems like a simple and sensible change.

Dec 15 2021, 4:38 AM · Restricted Project, Restricted Project, debug-info, Restricted Project

Dec 14 2021

StephenTozer updated the diff for D114355: [DebugInfo] ValueMapper impl for DIArgList should respect RF_IgnoreMissingLocals.

Add a lit test for llvm-link, move the unit test changes into a separate function (leaving the original unmodified). The long comment in the original test has been duplicated (with a minor change) in the new test - I figure it's better to have each test containing the relevant info directly, but if preferred I could change it to some kind of "see above" instead.

Dec 14 2021, 7:06 AM · debug-info, Restricted Project

Dec 13 2021

StephenTozer added inline comments to D114355: [DebugInfo] ValueMapper impl for DIArgList should respect RF_IgnoreMissingLocals.
Dec 13 2021, 9:48 AM · debug-info, Restricted Project

Dec 6 2021

StephenTozer accepted D115139: [Coroutines] Handle CallBrInst in SalvageDebugInfo.

LGTM.

Dec 6 2021, 6:09 AM · Restricted Project

Dec 3 2021

StephenTozer committed rG98a021fcbfe1: [DebugInfo] Attempt to preserve more information during tail duplication (authored by StephenTozer).
[DebugInfo] Attempt to preserve more information during tail duplication
Dec 3 2021, 7:31 AM
StephenTozer closed D106875: [DebugInfo] Attempt to preserve more information during tail duplication.
Dec 3 2021, 7:30 AM · Restricted Project, debug-info
StephenTozer added a comment to D114355: [DebugInfo] ValueMapper impl for DIArgList should respect RF_IgnoreMissingLocals.

Ping.

Dec 3 2021, 5:41 AM · debug-info, Restricted Project
StephenTozer added a comment to D97673: [RFC] [[Coroutine] [Debug] Salvage dbg.values.

It's a relatively obscure instruction I think, but we should also handle callbr in the same manner as invoke, as that is also a terminator instruction that defines an SSA value. A similar solution should suffice, as it also has a single destination where the value is expected to be valid (getDefaultDest()) that the dbg.declare can be inserted at the start of.

Dec 3 2021, 1:57 AM · debug-info, Restricted Project

Dec 2 2021

StephenTozer added inline comments to D97673: [RFC] [[Coroutine] [Debug] Salvage dbg.values.
Dec 2 2021, 8:55 AM · debug-info, Restricted Project

Dec 1 2021

StephenTozer committed rGf0eef1d21203: [Dexter] Fix address_printing test by requiring lldb (authored by StephenTozer).
[Dexter] Fix address_printing test by requiring lldb
Dec 1 2021, 6:07 AM
StephenTozer committed rG0428d44d4cfa: [Dexter] Add DexDeclareAddress command and address function (authored by StephenTozer).
[Dexter] Add DexDeclareAddress command and address function
Dec 1 2021, 5:08 AM
StephenTozer closed D111447: [Dexter] Add DexDeclareAddress command and address function.
Dec 1 2021, 5:08 AM · Restricted Project, debug-info

Nov 25 2021

StephenTozer added a comment to D114364: [DebugInfo][5/N] Recognise extra indirection in instruction-referencing for NRVO tests.

IMO these tests would benefit little as they're really targetted at LiveDebugValues, and shouldn't really be .ll tests. On the other hand, given that there isn't actually a test difference between the two implementations, it won't hurt to add some extra RUN lines, WDYT?

Nov 25 2021, 10:35 AM · Restricted Project
StephenTozer added a comment to D114364: [DebugInfo][5/N] Recognise extra indirection in instruction-referencing for NRVO tests.

Would it make sense to have these tests run twice, once with experimental-debug-variable-locations being true and once with false? Otherwise it looks like they will no longer cover the normal DBG_VALUE case with this patch.

Nov 25 2021, 9:11 AM · Restricted Project
StephenTozer accepted D114587: [DebugInfo][InstrRef] Avoid some quadratic behaviour in LiveDebugVariables.

Looks like a plain and simple performance improvement, LGTM (one minor nit included).

Nov 25 2021, 7:32 AM · Restricted Project

Nov 24 2021

StephenTozer added inline comments to D114355: [DebugInfo] ValueMapper impl for DIArgList should respect RF_IgnoreMissingLocals.
Nov 24 2021, 7:17 AM · debug-info, Restricted Project
StephenTozer added inline comments to D114355: [DebugInfo] ValueMapper impl for DIArgList should respect RF_IgnoreMissingLocals.
Nov 24 2021, 7:05 AM · debug-info, Restricted Project

Nov 22 2021

StephenTozer updated the summary of D114355: [DebugInfo] ValueMapper impl for DIArgList should respect RF_IgnoreMissingLocals.
Nov 22 2021, 3:32 AM · debug-info, Restricted Project
StephenTozer requested review of D114355: [DebugInfo] ValueMapper impl for DIArgList should respect RF_IgnoreMissingLocals.
Nov 22 2021, 3:26 AM · debug-info, Restricted Project

Nov 16 2021

StephenTozer added inline comments to D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.
Nov 16 2021, 4:03 AM · Restricted Project
StephenTozer added inline comments to D104827: [DebugInfo] Enforce implicit constraints on `distinct` MDNodes.
Nov 16 2021, 3:34 AM · Restricted Project

Nov 12 2021

StephenTozer added inline comments to D111447: [Dexter] Add DexDeclareAddress command and address function.
Nov 12 2021, 11:01 AM · Restricted Project, debug-info
StephenTozer updated the diff for D111447: [Dexter] Add DexDeclareAddress command and address function.

Add 1 more test for the hit_count argument.

Nov 12 2021, 6:56 AM · Restricted Project, debug-info

Nov 11 2021

StephenTozer updated the diff for D111447: [Dexter] Add DexDeclareAddress command and address function.

Move the generation of the address resolution map to Heuristic (None initialized on command objects until the heuristic runs). Added address information to the verbose output (only prints additional info if DexDeclareAddress is actually present), and always print the name of the address in the "missing values" and "encountered expected values" output (implementation for misordered values is more complex, and has been ignored). Also, removed some unused functions in DexExpectWatchBase.

Nov 11 2021, 10:49 AM · Restricted Project, debug-info
StephenTozer added inline comments to D111531: Fix minor deficiency in MachineSink..
Nov 11 2021, 5:47 AM · Restricted Project
StephenTozer added inline comments to D111531: Fix minor deficiency in MachineSink..
Nov 11 2021, 5:37 AM · Restricted Project
StephenTozer added inline comments to D111531: Fix minor deficiency in MachineSink..
Nov 11 2021, 5:30 AM · Restricted Project
StephenTozer added a comment to D111531: Fix minor deficiency in MachineSink..

Found one issue with the test (noted inline), but otherwise no issues.

Nov 11 2021, 4:27 AM · Restricted Project
StephenTozer added inline comments to D111531: Fix minor deficiency in MachineSink..
Nov 11 2021, 4:08 AM · Restricted Project
StephenTozer accepted D111531: Fix minor deficiency in MachineSink..

Seems straightforward enough to me, the code block in question clearly only cares about preg defs for the purposes of sinking. LGTM, with one inline nit.

Nov 11 2021, 4:07 AM · Restricted Project
StephenTozer added inline comments to D111447: [Dexter] Add DexDeclareAddress command and address function.
Nov 11 2021, 2:29 AM · Restricted Project, debug-info
StephenTozer updated the diff for D111447: [Dexter] Add DexDeclareAddress command and address function.

Add a set of feature tests for DexDeclareAddress; also fix a minor error that would appear if the address was never resolved.

Nov 11 2021, 2:17 AM · Restricted Project, debug-info

Nov 10 2021

StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

The relanding in 47633af9d4a8b93f50cb711cf23489736e0226f1 broke determinism for Firefox.

Nov 10 2021, 6:19 AM · debug-info, Restricted Project

Nov 9 2021

StephenTozer accepted D113468: Fix nondeterminism in debuginfo generation.

LGTM! Good catch on this one, I thought I'd removed all the DenseMap iteration errors but I guess this one slipped by. There's a small suggestion in the inline comments, but feel free to ignore it - it's more of a preference than a rule. Shouldn't need a test either since this patch is trivial and solves a determinism issue, so this should be fine as-is.

Nov 9 2021, 1:22 AM · Restricted Project