Page MenuHomePhabricator

StephenTozer (Stephen Tozer)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 5 2019, 4:12 AM (119 w, 6 d)

Recent Activity

Thu, Jun 17

StephenTozer added a reverting change for rGe8991caea869: Revert "[DebugInfo] Prevent non-determinism when updating DIArgList users of a…: rGdee2c76b4c46: Reapply "[DebugInfo] Prevent non-determinism when updating DIArgList users of a….
Thu, Jun 17, 8:17 AM
StephenTozer committed rGdee2c76b4c46: Reapply "[DebugInfo] Prevent non-determinism when updating DIArgList users of a… (authored by StephenTozer).
Reapply "[DebugInfo] Prevent non-determinism when updating DIArgList users of a…
Thu, Jun 17, 8:17 AM
StephenTozer added a reverting change for rGfa1de88f81e9: [DebugInfo] Prevent non-determinism when updating DIArgList users of a value: rGe8991caea869: Revert "[DebugInfo] Prevent non-determinism when updating DIArgList users of a….
Thu, Jun 17, 7:21 AM
StephenTozer committed rGe8991caea869: Revert "[DebugInfo] Prevent non-determinism when updating DIArgList users of a… (authored by StephenTozer).
Revert "[DebugInfo] Prevent non-determinism when updating DIArgList users of a…
Thu, Jun 17, 7:21 AM
StephenTozer added a reverting change for D104105: [DebugInfo] Prevent non-determinism when updating DIArgList users of a value: rGe8991caea869: Revert "[DebugInfo] Prevent non-determinism when updating DIArgList users of a….
Thu, Jun 17, 7:21 AM · Restricted Project, debug-info
StephenTozer committed rGfa1de88f81e9: [DebugInfo] Prevent non-determinism when updating DIArgList users of a value (authored by StephenTozer).
[DebugInfo] Prevent non-determinism when updating DIArgList users of a value
Thu, Jun 17, 7:09 AM
StephenTozer closed D104105: [DebugInfo] Prevent non-determinism when updating DIArgList users of a value.
Thu, Jun 17, 7:09 AM · Restricted Project, debug-info

Mon, Jun 14

StephenTozer added inline comments to D104105: [DebugInfo] Prevent non-determinism when updating DIArgList users of a value.
Mon, Jun 14, 3:44 AM · Restricted Project, debug-info

Fri, Jun 11

StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Fix for the determinism bug at D104105

Fri, Jun 11, 3:47 AM · Restricted Project, debug-info
StephenTozer requested review of D104105: [DebugInfo] Prevent non-determinism when updating DIArgList users of a value.
Fri, Jun 11, 3:47 AM · Restricted Project, debug-info

Thu, Jun 10

StephenTozer added inline comments to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.
Thu, Jun 10, 7:49 AM · Restricted Project, debug-info

Wed, Jun 2

StephenTozer committed rG4316b0e59cfa: [LoopStrengthReduce] Ensure that debug intrinsics do not affect LSR's output (authored by StephenTozer).
[LoopStrengthReduce] Ensure that debug intrinsics do not affect LSR's output
Wed, Jun 2, 7:57 AM
StephenTozer closed D103033: [LoopStrengthReduce] Ensure that debug intrinsics do not affect LSR's output.
Wed, Jun 2, 7:57 AM · debug-info, Restricted Project

Tue, Jun 1

StephenTozer added a comment to D103033: [LoopStrengthReduce] Ensure that debug intrinsics do not affect LSR's output.

Ping.

Tue, Jun 1, 9:06 AM · debug-info, Restricted Project

Wed, May 26

StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Might be handy to include a link to the fix here for context (in case other folks with out of tree backends hit similar issues, etc)

Wed, May 26, 4:24 PM · Restricted Project, debug-info
StephenTozer committed rGa0bd6105d806: [DebugInfo] Limit the number of values that may be referenced by a dbg.value (authored by StephenTozer).
[DebugInfo] Limit the number of values that may be referenced by a dbg.value
Wed, May 26, 9:34 AM
StephenTozer closed D103162: [DebugInfo] Limit the number of values that may be referenced by a dbg.value.
Wed, May 26, 9:34 AM · Restricted Project, debug-info
StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

I've opened review D103162 to fix the performance issue described above.

Wed, May 26, 5:39 AM · Restricted Project, debug-info
StephenTozer requested review of D103162: [DebugInfo] Limit the number of values that may be referenced by a dbg.value.
Wed, May 26, 5:38 AM · Restricted Project, debug-info
StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

We're seeing a pathological case with 36ec97f76ac0d8be76fb16ac521f55126766267d (3rd Reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands).

Wed, May 26, 2:55 AM · Restricted Project, debug-info

Tue, May 25

StephenTozer updated the diff for D103033: [LoopStrengthReduce] Ensure that debug intrinsics do not affect LSR's output.

Reduced test file by ~25%.

Tue, May 25, 2:57 AM · debug-info, Restricted Project
StephenTozer added a comment to D103033: [LoopStrengthReduce] Ensure that debug intrinsics do not affect LSR's output.

Any chance of reducing the test case further?

Tue, May 25, 2:39 AM · debug-info, Restricted Project

Mon, May 24

StephenTozer requested review of D103033: [LoopStrengthReduce] Ensure that debug intrinsics do not affect LSR's output.
Mon, May 24, 9:16 AM · debug-info, Restricted Project

May 21 2021

StephenTozer accepted D101527: [dexter] Add hit_count keyword arg to DexLimitSteps.

LGTM

May 21 2021, 3:59 AM · Restricted Project, debug-info
StephenTozer added a reverting change for rG4397b7095d64: Revert "Re-reapply "[DebugInfo] Use variadic debug values to salvage BinOps and…: rG36ec97f76ac0: 3rd Reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP….
May 21 2021, 3:07 AM
StephenTozer committed rG36ec97f76ac0: 3rd Reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP… (authored by StephenTozer).
3rd Reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP…
May 21 2021, 3:07 AM

May 20 2021

StephenTozer committed rGcf725dde9cb7: [DebugInfo] Handle DIArgList in FastISel or GlobalIsel (authored by StephenTozer).
[DebugInfo] Handle DIArgList in FastISel or GlobalIsel
May 20 2021, 9:38 AM
StephenTozer closed D102500: [DebugInfo] Produce undef DBG_VALUE instructions for variadic dbg.values when using FastISel or GlobalIsel.
May 20 2021, 9:38 AM · Restricted Project, debug-info

May 18 2021

StephenTozer added a comment to D100845: [Debugify][Original DI] Test preservation of original debug var intrinsics in optimizations.

LGTM - since this adds new output to debugify I would prefer if there was a review from someone with more authority regarding that sort of thing, but I think this should be harmless: this should only affect original DI preservation checks, since debugify does not add variables and should not be used on modules with existing variables, and I don't believe we depend on debugify's original DI preservation in any tests.

May 18 2021, 3:20 AM · Restricted Project, debug-info
StephenTozer accepted D100845: [Debugify][Original DI] Test preservation of original debug var intrinsics in optimizations.

LGTM - since this adds new output to debugify I would prefer if there was a review from someone with more authority regarding that sort of thing, but I think this should be harmless: this should only affect original DI preservation checks, since debugify does not add variables and should not be used on modules with existing variables, and I don't believe we depend on debugify's original DI preservation in any tests.

May 18 2021, 3:09 AM · Restricted Project, debug-info

May 17 2021

StephenTozer added a comment to D100845: [Debugify][Original DI] Test preservation of original debug var intrinsics in optimizations.

This looks mostly good to me right now - I haven't gone through the HTML template code in-depth, but it looks to do what it says on the tin at least. I agree with the prior discussion that we will probably see a lot of false positives emerge from this, but I think the most important thing is that we have the tool. Once we have a larger spread of results, we can examine them and determine how best to tackle false positives so that we can get useful output.

May 17 2021, 4:07 AM · Restricted Project, debug-info

May 14 2021

StephenTozer added a comment to D102500: [DebugInfo] Produce undef DBG_VALUE instructions for variadic dbg.values when using FastISel or GlobalIsel.

Do we expect cases where this feature is useful when doing -O0? I guess no, right? So the FastISel is OK, since it is being used at -O0 case only.

May 14 2021, 8:05 AM · Restricted Project, debug-info
StephenTozer updated the diff for D102500: [DebugInfo] Produce undef DBG_VALUE instructions for variadic dbg.values when using FastISel or GlobalIsel.

Added test that was missing from the previous diff.

May 14 2021, 7:47 AM · Restricted Project, debug-info
StephenTozer requested review of D102500: [DebugInfo] Produce undef DBG_VALUE instructions for variadic dbg.values when using FastISel or GlobalIsel.
May 14 2021, 7:46 AM · Restricted Project, debug-info

May 12 2021

StephenTozer added a reverting change for rG7ca26c5fa2df: Revert "[DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST": rGfdb055f4f139: Reapply "[DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST".
May 12 2021, 2:20 AM
StephenTozer committed rGfdb055f4f139: Reapply "[DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST" (authored by StephenTozer).
Reapply "[DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST"
May 12 2021, 2:20 AM
StephenTozer closed D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.
May 12 2021, 2:20 AM · Restricted Project, debug-info

May 11 2021

StephenTozer added a comment to D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.

Another question is what the old implementation of this did. Was it similarly borken?

May 11 2021, 4:57 AM · Restricted Project, debug-info

May 10 2021

StephenTozer closed D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values.

The updated patch was reapplied in aa3e78a59fdf.

May 10 2021, 7:40 AM · Restricted Project, debug-info
StephenTozer added a comment to D101540: [DebugInfo] Fix crash when emitting an invalidated SDDbgValue.

Might be handy to include the commit hash so folks can easily follow-up from here to there. (I think there's some way to write the commit hash in Phab such it it turns it into a link, which is nice)

May 10 2021, 6:50 AM · Restricted Project, debug-info
StephenTozer updated the diff for D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.

The previous version of the patch was handling subregisters incorrectly; the updateDbgUsersToReg function assumed that each operand MO that corresponded to OldRegwould satisfy MO.getReg() == OldReg - this is correct for virtual registers, which use the subReg field, but not for physical registers.

May 10 2021, 6:13 AM · Restricted Project, debug-info
StephenTozer added a comment to D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.

I've identified the issue with this patch, I'll submit an updated version for review shortly.

May 10 2021, 4:51 AM · Restricted Project, debug-info

May 7 2021

StephenTozer committed rG7bc1dd1191ab: Reapply "[DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug… (authored by StephenTozer).
Reapply "[DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug…
May 7 2021, 6:58 AM
StephenTozer added a reverting change for rGb11e4c990771: Revert "[DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug…: rG7bc1dd1191ab: Reapply "[DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug….
May 7 2021, 6:58 AM
StephenTozer added a comment to D101540: [DebugInfo] Fix crash when emitting an invalidated SDDbgValue.

This patch caused some failures on buildbots, caused by the fact that the test requires x86_64 but does not have the explicit REQUIRE set. I've pushed up a followup fix that moves the test from DebugInfo/Generic to DebugInfo/X86, which should fix the issue; I welcome any post-commit review on this change.

May 7 2021, 5:41 AM · Restricted Project, debug-info
StephenTozer committed rG14818a86d044: Fix: [DebugInfo] Fix crash when emitting an invalidated SDDbgValue (authored by StephenTozer).
Fix: [DebugInfo] Fix crash when emitting an invalidated SDDbgValue
May 7 2021, 5:39 AM
StephenTozer committed rGce0c1f3ced9b: [DebugInfo] Fix crash when emitting an invalidated SDDbgValue (authored by StephenTozer).
[DebugInfo] Fix crash when emitting an invalidated SDDbgValue
May 7 2021, 5:14 AM
StephenTozer closed D101540: [DebugInfo] Fix crash when emitting an invalidated SDDbgValue.
May 7 2021, 5:14 AM · Restricted Project, debug-info
StephenTozer committed rG0791f968fee2: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST (authored by StephenTozer).
[DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST
May 7 2021, 3:51 AM
StephenTozer closed D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.
May 7 2021, 3:51 AM · Restricted Project, debug-info

May 6 2021

StephenTozer updated the diff for D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.

Move test to DebugInfo/ARM, remove explicit ARM target requirement.

May 6 2021, 2:53 AM · Restricted Project, debug-info

May 5 2021

StephenTozer added a comment to D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.

Might it be more suitable to move the test to the DebugInfo/ARM directory - which I think implicitly has such a requirement?

May 5 2021, 5:19 PM · Restricted Project, debug-info
StephenTozer updated the diff for D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.

Added a "requires" to the test, and simplified the test target to just arm (instead of armv6k, which is not needed for the test to pass).

May 5 2021, 8:06 AM · Restricted Project, debug-info

May 4 2021

StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

@StephenTozer what's the status of the two fixes? Can you chase those please? You shouldn't be leaving breaking changes in for >24hrs please.

May 4 2021, 2:00 AM · Restricted Project, debug-info

Apr 29 2021

StephenTozer updated the diff for D101540: [DebugInfo] Fix crash when emitting an invalidated SDDbgValue.

Update test case with further reduced function body and implicit-check-not.

Apr 29 2021, 3:59 PM · Restricted Project, debug-info
StephenTozer updated the diff for D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.

Fixed an issue with the previous implementation of this fix: the CopyDbgUsers vectors would sometimes contain duplicate elements, causing errors when we attempt to replace the same debug operand multiple times. This has been fixed by making it into a SmallSet instead of a SmallVector, although we still convert to SmallVector before updating to avoid changing the MRI interface.

Apr 29 2021, 3:58 PM · Restricted Project, debug-info
StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Fixes are up for review at D101523 and D101540; both fixes are quite small and so shouldn't be held up too long in review, but if the fix is needed urgently you can either apply those patches directly while awaiting their arrival in the main branch, or they can potentially be commited prior to finishing review - this isn't preferred, but is an option for sufficiently simple changes.

Apr 29 2021, 9:09 AM · Restricted Project, debug-info
StephenTozer updated the diff for D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.

Remove git hash and directory path from test case metadata.

Apr 29 2021, 8:43 AM · Restricted Project, debug-info
StephenTozer updated the diff for D101540: [DebugInfo] Fix crash when emitting an invalidated SDDbgValue.

Remove git hash and directory path from test case metadata.

Apr 29 2021, 8:33 AM · Restricted Project, debug-info
StephenTozer requested review of D101540: [DebugInfo] Fix crash when emitting an invalidated SDDbgValue.
Apr 29 2021, 8:28 AM · Restricted Project, debug-info
StephenTozer updated the diff for D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.

Added test case.

Apr 29 2021, 6:16 AM · Restricted Project, debug-info
StephenTozer requested review of D101523: [DebugInfo] Fix updateDbgUsersToReg to support DBG_VALUE_LIST.
Apr 29 2021, 5:12 AM · Restricted Project, debug-info
StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

Thanks for the report @nathanchance, I'm putting together a fix now. The first error looks to be quite straightforward (the error is contained to a single small function), and I'm currently investigating the latter - if it seems sufficiently complicated I'll revert pending a fix, otherwise I'll submit a fix today and get it merged in shortly afterwards.

Apr 29 2021, 4:53 AM · Restricted Project, debug-info

Apr 28 2021

StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

I'm seeing a crash after the most recent time this was re-applied in 791930d74087b8ae8901172861a0fd21a211e436.

Apr 28 2021, 3:36 AM · Restricted Project, debug-info
StephenTozer committed rGb622df3c9398: [DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug operands (authored by StephenTozer).
[DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug operands
Apr 28 2021, 2:41 AM
StephenTozer closed D101373: [DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug operands.
Apr 28 2021, 2:41 AM · Restricted Project, debug-info

Apr 27 2021

StephenTozer updated the diff for D101373: [DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug operands.

Simplify test case by using constants in the DIArgList instead of SSA values.

Apr 27 2021, 3:25 PM · Restricted Project, debug-info
StephenTozer added a comment to D101373: [DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug operands.

Oh, right. I just realized this test doesn't have to be especially realistic because it's only about the length of the expression - not how we got such a long expression in the first place?

So perhaps we could include a comment describing the real-ish situation, but then make the test case really simple/obvious? - it doesn't need any IR instructions really, and can have an expression that's simple/uninteresting in some way? Like adding together the constant 1 repeatedly?

Apr 27 2021, 3:20 PM · Restricted Project, debug-info
StephenTozer updated the diff for D101373: [DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug operands.

Add reduced test case, use std::make_unique to initialize unique_ptrs.

Apr 27 2021, 12:54 PM · Restricted Project, debug-info
StephenTozer added a comment to D101373: [DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug operands.

Hmm - not sure I follow. The LLVM IR for the reproduce @rupprecht gave seems to be about half that (~460 lines) - in any case, one workaround could be to include a test-only flag for the limit and set the limit artificially low for testing.

Apr 27 2021, 12:25 PM · Restricted Project, debug-info
StephenTozer added a comment to D101373: [DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug operands.

This presumably needs a test case.

Apr 27 2021, 12:06 PM · Restricted Project, debug-info
StephenTozer requested review of D101373: [DebugInfo] Drop DBG_VALUE_LISTs with an excessive number of debug operands.
Apr 27 2021, 9:10 AM · Restricted Project, debug-info
StephenTozer added a comment to D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands.

I'm seeing a crash after the most recent time this was re-applied in 791930d74087b8ae8901172861a0fd21a211e436. The crash is when compiling https://github.com/beltoforion/muparser/blob/master/src/muParserTest.cpp, but I'm reducing it now, as the error might also depend on how we build that internally (we use at least`-g -O3`)

Apr 27 2021, 3:00 AM · Restricted Project, debug-info

Apr 23 2021

StephenTozer added a reverting change for rGdad5caa59e6b: Revert "Reapply "[DebugInfo] Use variadic debug values to salvage BinOps and…: rG791930d74087: Re-reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP….
Apr 23 2021, 2:56 AM
StephenTozer committed rG791930d74087: Re-reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP… (authored by StephenTozer).
Re-reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP…
Apr 23 2021, 2:56 AM

Apr 22 2021

StephenTozer committed rGe5d844b58744: [Bitcode] Ensure DIArgList in bitcode has no null or forward metadata refs (authored by StephenTozer).
[Bitcode] Ensure DIArgList in bitcode has no null or forward metadata refs
Apr 22 2021, 4:05 AM
StephenTozer closed D100572: [DebugInfo] Ensure DIArgList in bitcode has no null or forward metadata refs.
Apr 22 2021, 4:05 AM · Restricted Project, debug-info

Apr 21 2021

StephenTozer updated the diff for D100572: [DebugInfo] Ensure DIArgList in bitcode has no null or forward metadata refs.

Reduce possible performance issues in constant value ordering.

Apr 21 2021, 8:48 AM · Restricted Project, debug-info
StephenTozer added inline comments to D100572: [DebugInfo] Ensure DIArgList in bitcode has no null or forward metadata refs.
Apr 21 2021, 8:14 AM · Restricted Project, debug-info
StephenTozer accepted D100844: [DebugInfo] Salvage dbg.value() during ADCE.
Apr 21 2021, 2:38 AM · Restricted Project, debug-info

Apr 20 2021

StephenTozer updated the diff for D100572: [DebugInfo] Ensure DIArgList in bitcode has no null or forward metadata refs.

In the previous version of the patch, the actual Constant values used by the ConstantAsMetadata arguments to DIArgList were not being enumerated until the function that used them was incorporated, which resulted in incorrect bitcode output (all constant values in the bitcode are expected to appear at the module level).

Apr 20 2021, 8:26 AM · Restricted Project, debug-info
StephenTozer added a comment to D100844: [DebugInfo] Salvage dbg.value() during ADCE.

I think wait a short while in case anyone has any comments about the test (as a minor nitpick the "Function Attrs" comment could be removed for @llvm.dbg.value), but this LGTM.

Apr 20 2021, 6:14 AM · Restricted Project, debug-info

Apr 15 2021

StephenTozer requested review of D100572: [DebugInfo] Ensure DIArgList in bitcode has no null or forward metadata refs.
Apr 15 2021, 8:53 AM · Restricted Project, debug-info

Apr 12 2021

StephenTozer added a reverting change for rGf40976bd0103: Revert "[DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs…: rGf2e4f3eff3c9: Reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs….
Apr 12 2021, 8:58 AM
StephenTozer committed rGf2e4f3eff3c9: Reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs… (authored by StephenTozer).
Reapply "[DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs…
Apr 12 2021, 8:58 AM
StephenTozer added a reverting change for rG1b589172bd19: Revert "[DebugInfo] Correctly track SDNode dependencies for list debug values": rGaa3e78a59fdf: Reapply "[DebugInfo] Correctly track SDNode dependencies for list debug values".
Apr 12 2021, 4:53 AM
StephenTozer committed rGaa3e78a59fdf: Reapply "[DebugInfo] Correctly track SDNode dependencies for list debug values" (authored by StephenTozer).
Reapply "[DebugInfo] Correctly track SDNode dependencies for list debug values"
Apr 12 2021, 4:53 AM

Apr 9 2021

StephenTozer updated the diff for D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values.

Small update: explicitly deleted the copy constructors and destructor for SDDbgValue with an explanatory comment, to ensure that if we ever start copy constructing or destroying instances of SDDbgValue there will be notice that the raw pointers need to be managed.

Apr 9 2021, 9:21 AM · Restricted Project, debug-info
StephenTozer updated the diff for D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values.

Replace shared_ptr usage with raw pointers, as neither a copy constructor nor the destructor for SDDbgValue are ever called, making memory management a non-issue.

Apr 9 2021, 8:22 AM · Restricted Project, debug-info
StephenTozer requested review of D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values.
Apr 9 2021, 7:26 AM · Restricted Project, debug-info
StephenTozer updated the diff for D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values.

Fixed deletion lambdas in shared_ptrs, which were previously missing the size of the array.

Apr 9 2021, 7:25 AM · Restricted Project, debug-info
StephenTozer reopened D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values.

Reopening review, as non-trivial changes have been added following buildbot failure (see comment above for details).

Apr 9 2021, 6:42 AM · Restricted Project, debug-info
StephenTozer updated the diff for D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values.

Sanitizer builds were failing due to memory leaks; these were caused by the fact that SDDbgValues are allocated under a BumpPtrAllocator, which does not call destructors. SDDbgValues contained SmallVectors which did not use this allocator, so when the SDDbgValues were cleared they would not call the SmallVector destructor.

Apr 9 2021, 6:41 AM · Restricted Project, debug-info

Apr 8 2021

StephenTozer added a reverting change for rGe10493eb5012: [DebugInfo] Correctly track SDNode dependencies for list debug values: rG1b589172bd19: Revert "[DebugInfo] Correctly track SDNode dependencies for list debug values".
Apr 8 2021, 9:56 AM
StephenTozer committed rG1b589172bd19: Revert "[DebugInfo] Correctly track SDNode dependencies for list debug values" (authored by StephenTozer).
Revert "[DebugInfo] Correctly track SDNode dependencies for list debug values"
Apr 8 2021, 9:56 AM
StephenTozer added a reverting change for D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values: rG1b589172bd19: Revert "[DebugInfo] Correctly track SDNode dependencies for list debug values".
Apr 8 2021, 9:56 AM · Restricted Project, debug-info
StephenTozer committed rGe10493eb5012: [DebugInfo] Correctly track SDNode dependencies for list debug values (authored by StephenTozer).
[DebugInfo] Correctly track SDNode dependencies for list debug values
Apr 8 2021, 9:07 AM
StephenTozer closed D99423: [DebugInfo] Fix incorrect updating of SDNode dependencies for variadic debug values.
Apr 8 2021, 9:06 AM · Restricted Project, debug-info
StephenTozer abandoned D94631: [DebugInfo] Add support for multiple value references in debug values, and enable salvaging.

Closing this, as the work has all passed review and is in the process of merging - although any further comments on the design as a whole are welcome.

Apr 8 2021, 6:34 AM · Restricted Project, debug-info
StephenTozer committed rG140757bfaaa0: [DebugInfo] Prevent invalid debug info being produced during LoopStrengthReduce (authored by StephenTozer).
[DebugInfo] Prevent invalid debug info being produced during LoopStrengthReduce
Apr 8 2021, 5:06 AM