Page MenuHomePhabricator

gottesmm (Michael Gottesman)
User

Projects

User does not belong to any projects.

User Details

User Since
Jan 11 2013, 12:24 AM (340 w, 3 d)

Recent Activity

Jun 10 2019

gottesmm added a comment to D62433: [ObjC][ARC] Delete ObjC runtime calls if the argument is a global variable.

I looked at the other one. Beyond my question about the name, this looks great!

Jun 10 2019, 8:50 PM · Restricted Project
gottesmm added a comment to D62831: [CodeGen][ObjC] Add attribute "objc_arc_intert" to ObjC globals that are retain-agnostic.

This is exactly what I was imagining! This will enable the frontend to opt into this optimization without having to touch the optimizer. One nit: can we use a different name than "arc_retain_agnostic". Have you considered something like "arc_inert"? My fear is that at a glance (without thinking), you would think that the attribute would have something only to do with retain when we are really talking about ARC value operations. Beyond that looks great!

Jun 10 2019, 8:47 PM · Restricted Project, Restricted Project

May 28 2019

gottesmm added a comment to D62433: [ObjC][ARC] Delete ObjC runtime calls if the argument is a global variable.

I don't remember. That being said, this should be a conservative optimization. What if someone adds in the future a different global where this isn't a no-op. Is it possible if you know what the global is to add a whitelist that you only care about those 2 things.

May 28 2019, 2:34 PM · Restricted Project

Dec 10 2017

gottesmm added a comment to D41050: Fix over-release of return value of lambda implicitly converted to block/function pointer.

SGTM.

Dec 10 2017, 12:21 PM
gottesmm added a reviewer for D41050: Fix over-release of return value of lambda implicitly converted to block/function pointer: dexonsmith.

I do not work on objcarc any longer. +CC Duncan.

Dec 10 2017, 10:27 AM

Feb 8 2017

gottesmm accepted D29346: Fix APFloat mod.

Thanks for running it through git-clang-format. LGTM!

Feb 8 2017, 2:57 PM
gottesmm requested changes to D29346: Fix APFloat mod.

Did you run this through git-clang-format?

Feb 8 2017, 1:12 PM

Feb 17 2016

gottesmm added a comment to D17329: [AA] Hoist the logic to reformulate various AA queries in terms of other parts of the AA interface out of the base class of every single AA result object..

Chandler: Later tonight I am going to figure out what I need to do to my out of tree project to make this work. Hopefully everything is smooth.

Feb 17 2016, 3:37 PM
gottesmm updated subscribers of D17329: [AA] Hoist the logic to reformulate various AA queries in terms of other parts of the AA interface out of the base class of every single AA result object..
Feb 17 2016, 2:26 PM

Jan 31 2016

gottesmm added inline comments to D16708: Add a new attribute CFNoRelease..
Jan 31 2016, 7:12 PM
gottesmm added a comment to D16708: Add a new attribute CFNoRelease..

I think that my response via email did not hit phabriactor. So sorry for the delay.

Jan 31 2016, 7:11 PM

Jan 28 2016

gottesmm updated the diff for D16708: Add a new attribute CFNoRelease..

Added documentation.

Jan 28 2016, 10:39 PM
gottesmm updated subscribers of D16708: Add a new attribute CFNoRelease..
Jan 28 2016, 8:39 PM
gottesmm retitled D16708: Add a new attribute CFNoRelease. from to Add a new attribute CFNoRelease..
Jan 28 2016, 8:37 PM
gottesmm abandoned D16707: [codegen] When emitting functions with the "cf_no_release" attribute, attach the "clang-arc-no_release" string ttribute to the function..

I failed at using fabricator. I am going to close this until I get in the attribute version. That is what I meant to give to Doug to review.

Jan 28 2016, 8:36 PM
gottesmm retitled D16707: [codegen] When emitting functions with the "cf_no_release" attribute, attach the "clang-arc-no_release" string ttribute to the function. from to [codegen] When emitting functions with the "cf_no_release" attribute, attach the "clang-arc-no_release" string ttribute to the function..
Jan 28 2016, 8:34 PM

Jan 12 2016

gottesmm updated the diff for D16131: Fix PointerIntPair so that it can use an enum class as its integer template argument..

Removed an unneeded static cast.

Jan 12 2016, 9:51 PM
gottesmm retitled D16131: Fix PointerIntPair so that it can use an enum class as its integer template argument. from to Fix PointerIntPair so that it can use an enum class as its integer template argument..
Jan 12 2016, 9:03 PM
gottesmm resigned from D14723: Add dominator tree node downward splitting support.

I also am not appropriate for reviewing this. Resigning as well.

Jan 12 2016, 8:56 PM

Oct 24 2015

gottesmm accepted D9999: Refactor: Simplify boolean conditional return statements in lib/Transforms/ObjCARC.

LGTM.

Oct 24 2015, 2:51 PM

Oct 19 2015

gottesmm accepted D13418: [AA] Enhance the new AliasAnalysis infrastructure with an optional "external" AA wrapper pass..
Oct 19 2015, 2:52 PM
gottesmm added a comment to D13418: [AA] Enhance the new AliasAnalysis infrastructure with an optional "external" AA wrapper pass..

I just prepared all of the code that I need internally to work with this and it enables me to work through/verify all my use cases. This LGTM! Thanks Chandler!

Oct 19 2015, 2:49 PM

Dec 16 2014

gottesmm accepted D6477: Strength reduce intrinsics with overflow into regular arithmetic operations if possible..

LGTM

Dec 16 2014, 4:21 PM

Dec 14 2014

gottesmm added a comment to D6477: Strength reduce intrinsics with overflow into regular arithmetic operations if possible..

I would comment this a little differently. I think it is good to have the Hacker's Delight mention, but IIRC LLVM has some specific rules about this. I would just ask on the list or irc. The actual implementation looks fine to me (it is exactly the same as hacker's delight).

Dec 14 2014, 9:10 PM

Oct 9 2014

gottesmm updated subscribers of D5715: Add minnum / maxnum to APFloat.
Oct 9 2014, 7:54 PM