Page MenuHomePhabricator

jryans (J. Ryan Stinnett)
User

Projects

User Details

User Since
Nov 11 2012, 10:07 AM (524 w, 1 d)

Recent Activity

Wed, Nov 23

jryans accepted D138561: [Assignment Tracking] Fix DbgVariableIntrinsic::replaceVariableLocationOp.

Looks reasonable to me, thanks! 😄

Wed, Nov 23, 5:31 AM · debug-info, Restricted Project, Restricted Project

Fri, Nov 4

jryans added a project to D137400: [llvm-debuginfo-analyzer] Fix format string-type mismatch in LVScope: debug-info.
Fri, Nov 4, 4:49 AM · debug-info, Restricted Project, Restricted Project

Wed, Nov 2

jryans added a comment to D137156: [llvm-debuginfo-analyzer] Fix memory leak reported by sanitizers..

The creation of that issue is the next item on my list and I am hoping to finish it by Friday.
Currently I am writing a README.txt for the tool that contains:

  • Know issues
  • Limitations
  • Improvements
  • etc
Wed, Nov 2, 7:34 AM · Restricted Project, debug-info, Restricted Project
jryans added a comment to D137156: [llvm-debuginfo-analyzer] Fix memory leak reported by sanitizers..

Based on your suggestion, I can create a GitHub issue to include all the information and add that link to each of the entries in the reviews that refer to the memory handling.

Wed, Nov 2, 6:55 AM · Restricted Project, debug-info, Restricted Project

Tue, Nov 1

jryans accepted D137156: [llvm-debuginfo-analyzer] Fix memory leak reported by sanitizers..

Thanks, this looks reasonable to me! 🙂

Tue, Nov 1, 7:35 AM · Restricted Project, debug-info, Restricted Project

Oct 27 2022

jryans accepted D136837: [llvm-debuginfo-analyzer] (08/09) - ELF Reader - Test case (Undefined symbol - multistage).

Makes sense, thanks! 🙂

Oct 27 2022, 5:00 AM · Restricted Project, Restricted Project, debug-info
jryans accepted D136825: llvm-debuginfo-analyzer] (08/09) - ELF Reader - - Test case (No available targets).

Looks good, thanks for the quick fix! 🙂

Oct 27 2022, 2:42 AM · Restricted Project, Restricted Project, debug-info

Oct 26 2022

jryans accepted D136593: [llvm-debuginfo-analyzer] (07/09) - Compare elements - Test case (AddressSanitizer: leaked in allocations).

Seems like a reasonable fix, and it makes sense that you landed it quickly to fix the build issues. Thanks! 🙂

Oct 26 2022, 6:46 AM · Restricted Project, debug-info, Restricted Project

Oct 18 2022

jryans accepted D136159: [llvm-debuginfo-analyzer] Fix linking errors in buildbots (shared libraries)..

Looks reasonable to me, thanks! 😄

Oct 18 2022, 4:35 AM · Restricted Project, Restricted Project, debug-info

Oct 13 2022

jryans added a comment to D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solves issue #58252..

Ah yes, it’s all done now, feel free to clean up your local state however you prefer.

Oct 13 2022, 4:17 PM · Unknown Object (Project), Restricted Project
jryans added a comment to D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solves issue #58252..

No, once it has been committed, it can’t really be removed from a project of this size. Changes can be reverted, but the existence of the commits and messages remains. Don’t worry about it for this one, just something to think about next time.

Oct 13 2022, 3:28 PM · Unknown Object (Project), Restricted Project

Oct 12 2022

jryans added a comment to D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solves issue #58252..

Exciting, welcome to the LLVM community! 🙂

Oct 12 2022, 5:48 PM · Unknown Object (Project), Restricted Project

Oct 10 2022

jryans added a comment to D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solves issue #58252..

Please also give this patch a title that would make sense as the first line of a commit message. It currently just says "Summary:" at the moment.

Oct 10 2022, 9:38 AM · Unknown Object (Project), Restricted Project

Sep 28 2022

jryans accepted D134805: [ADT] IntervalTree - Random unittests failures in a debug build.

Thanks, looks good to me! 😄

Sep 28 2022, 6:21 AM · Restricted Project, Restricted Project

Sep 21 2022

jryans committed rG74f0e64bb94a: [LangRef][Docs] Fix RST header length for GC intrinsics (authored by jryans).
[LangRef][Docs] Fix RST header length for GC intrinsics
Sep 21 2022, 8:54 AM · Restricted Project, Restricted Project
jryans committed rG8c1a9e3cf37c: [LangRef][Docs] Align RST syntax for GC intrinsics (authored by jryans).
[LangRef][Docs] Align RST syntax for GC intrinsics
Sep 21 2022, 8:47 AM · Restricted Project, Restricted Project

Sep 12 2022

jryans committed rGd635695cf80b: [DebugInfo][Docs] Fix RST syntax for DW_OP_LLVM_arg in LangRef (authored by jryans).
[DebugInfo][Docs] Fix RST syntax for DW_OP_LLVM_arg in LangRef
Sep 12 2022, 4:50 AM · Restricted Project, Restricted Project

Sep 7 2022

jryans accepted D133304: [DebugInfo] [NFC] Refactor debug intrinsic copy and delete to instead just move.

Thanks, looks good to me! 😄

Sep 7 2022, 1:00 PM · Restricted Project, Restricted Project, debug-info
jryans accepted D133303: [DebugInfo] Fix minor debug info bug in deleteDeadLoop.

Thanks, looks sensible to me! 😄

Sep 7 2022, 12:52 PM · debug-info, Restricted Project, Restricted Project

Sep 6 2022

jryans accepted D132220: [Assignment Tracking][1/*] Add initial docs for Assignment Tracking .

Looks good overall, thanks! 😄

Sep 6 2022, 4:26 AM · Restricted Project, Restricted Project, debug-info

Sep 5 2022

jryans accepted D133286: [NFC] Add `DebugVariable` constructor that takes `DbgVariableIntrinsic *`.

Seems reasonable to me overall. I would think it's okay to land straight away, but it's also fine to bundle with rest of assignment tracking.

Sep 5 2022, 4:30 AM · Restricted Project, Restricted Project, debug-info

Aug 31 2022

jryans added inline comments to D132220: [Assignment Tracking][1/*] Add initial docs for Assignment Tracking .
Aug 31 2022, 2:05 PM · Restricted Project, Restricted Project, debug-info
jryans added a comment to D132220: [Assignment Tracking][1/*] Add initial docs for Assignment Tracking .

Overall, this looks great! Thanks for writing it up. 😄

Aug 31 2022, 1:38 PM · Restricted Project, Restricted Project, debug-info

Aug 24 2022

jryans added a comment to D132580: [Coro][Debuginfo] Add debug info to `_NoopCoro_ResumeDestroy` function.

Hmm, the "X instead of Y" example in the change summary seems to have the same output on both sides... Maybe one side was lost when preparing the summary? (Apologies if there is a difference I'm not seeing... 😅)

Aug 24 2022, 3:41 PM · debug-info, Restricted Project, Restricted Project

Aug 22 2022

jryans accepted D132357: [NFC] Move getDebugValueLoc from static in Local.cpp to DebugInfo.h.

Makes sense to me, seems like a useful shared utility function. 🙂

Aug 22 2022, 2:14 AM · Restricted Project, Restricted Project, debug-info

Aug 17 2022

jryans added a project to D129636: Fix a LSR debug invariance issue: debug-info.
Aug 17 2022, 9:35 AM · debug-info, Restricted Project, Restricted Project

Aug 9 2022

jryans accepted D131453: LiveDebugValues: Fix another crash related to unreachable blocks.

Thanks for the fix, looks good to me! 😄

Aug 9 2022, 2:10 AM · Restricted Project, Restricted Project

Aug 3 2022

jryans added a comment to D130999: Fix LDV InstrRefBasedImpl to not crash when encountering unreachable MBBs..

Looks reasonable to me, seems safe to keep it in. 🙂

Aug 3 2022, 1:15 PM · Restricted Project, Restricted Project

Jul 26 2022

jryans added a project to D130235: [WIP] Initial attempt to emit debug line record for an inlined callsite: debug-info.
Jul 26 2022, 5:25 AM · debug-info, Restricted Project, Restricted Project

Jul 7 2022

jryans added a member for debug-info: jryans.
Jul 7 2022, 7:27 PM

Jun 14 2022

jryans added a comment to D127626: [docs] Add document "Debugging C++ Coroutines".

Great work overall, this is very useful to have written up! 😄

Jun 14 2022, 5:41 AM · Restricted Project, debug-info, Restricted Project
jryans added a project to D127626: [docs] Add document "Debugging C++ Coroutines": debug-info.
Jun 14 2022, 5:29 AM · Restricted Project, debug-info, Restricted Project
jryans added a project to D127625: [Debug] [Coroutines] Get rid of DW_ATE_address: debug-info.
Jun 14 2022, 5:28 AM · debug-info, Restricted Project, Restricted Project

Jun 7 2022

jryans committed rGb878245af9e0: [DebugInfo][Docs] Improve code formatting in instruction referencing doc (authored by jryans).
[DebugInfo][Docs] Improve code formatting in instruction referencing doc
Jun 7 2022, 4:18 AM · Restricted Project, Restricted Project
jryans closed D126767: [DebugInfo][Docs] Improve code formatting in instruction referencing doc.
Jun 7 2022, 4:18 AM · debug-info, Restricted Project, Restricted Project
jryans added a comment to D126767: [DebugInfo][Docs] Improve code formatting in instruction referencing doc.

Thanks for the review! 😄

Jun 7 2022, 4:12 AM · debug-info, Restricted Project, Restricted Project
jryans added a comment to D126767: [DebugInfo][Docs] Improve code formatting in instruction referencing doc.

Thanks for taking a look @Orlando!

Jun 7 2022, 2:13 AM · debug-info, Restricted Project, Restricted Project

Jun 1 2022

jryans updated subscribers of D126767: [DebugInfo][Docs] Improve code formatting in instruction referencing doc.
Jun 1 2022, 3:18 AM · debug-info, Restricted Project, Restricted Project
jryans added a project to D126767: [DebugInfo][Docs] Improve code formatting in instruction referencing doc: debug-info.
Jun 1 2022, 3:17 AM · debug-info, Restricted Project, Restricted Project
jryans requested review of D126767: [DebugInfo][Docs] Improve code formatting in instruction referencing doc.
Jun 1 2022, 3:16 AM · debug-info, Restricted Project, Restricted Project

May 22 2022

jryans added a comment to D125777: [llvm-debuginfo-analyzer] 02 - Driver and documentation.

I've only read through the docs so far. This is looking great overall, and I'm excited for it to land. 😄

May 22 2022, 11:09 AM · Restricted Project, debug-info, Restricted Project

May 20 2022

jryans committed rG7a1d5ef703f6: [DebugInfo][NFC] Add instr-ref documentation, migration guide (authored by jryans).
[DebugInfo][NFC] Add instr-ref documentation, migration guide
May 20 2022, 6:14 AM · Restricted Project, Restricted Project
jryans closed D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide.
May 20 2022, 6:14 AM · Restricted Project, Restricted Project

May 18 2022

jryans updated the diff for D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide.

Addressed review feedback.

May 18 2022, 7:27 AM · Restricted Project, Restricted Project
jryans added inline comments to D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide.
May 18 2022, 7:27 AM · Restricted Project, Restricted Project
jryans added a comment to D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide.

Also, many thanks for driving this. After much introspection, I think that every time I came back to this document I tried to rewrite it from scratch, which is kind of a blocker against forward progress :(.

May 18 2022, 6:54 AM · Restricted Project, Restricted Project

May 10 2022

jryans updated the diff for D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide.

I've made various small improvements in this version:

May 10 2022, 6:38 AM · Restricted Project, Restricted Project
jryans commandeered D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide.

I've had a bit of time to work on this, so I'll post my revised version momentarily... I wasn't sure if I should commandeer this revision or start my own, but I figured commandeering this one seemed best to keep the conversation in one place.

May 10 2022, 6:34 AM · Restricted Project, Restricted Project

May 3 2022

jryans added a comment to D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide.

If you're interested in driving this forwards it'd be highly appreciated. I'll probably get around to this in another week or two otherwise, I'm periodically reminded elsewhere that I should have landed this ages ago.

May 3 2022, 1:55 PM · Restricted Project, Restricted Project

Apr 28 2022

Herald added a project to D113586: [DebugInfo][NFC] Add instr-ref documentation, migration guide: Restricted Project.

@jmorse It would be great to get this landed, as it's quite a useful reference to have around. 😄 If the main blocker is lack of time, I'd be happy to take over and work through the review comments so this can move forward.

Apr 28 2022, 9:10 AM · Restricted Project, Restricted Project

Apr 25 2022

jryans accepted D124398: [DebugInfo] Don't skip deletion of dead BasicBlocks because of debug-info instructions.

Thanks, this looks good to me. 😄

Apr 25 2022, 9:36 AM · Restricted Project, Restricted Project

Apr 21 2022

jryans added a watcher for debug-info: jryans.
Apr 21 2022, 7:56 AM
jryans committed rWde251158c6f3: Link to 2022 EuroLLVM event site (authored by jryans).
Link to 2022 EuroLLVM event site
Apr 21 2022, 6:19 AM · Restricted Project
jryans committed rW4ca25c04fe2a: Use a list for upcoming meetings (authored by jryans).
Use a list for upcoming meetings
Apr 21 2022, 6:18 AM · Restricted Project
jryans committed rW50c2dba3d46b: Fix various meeting lists (authored by jryans).
Fix various meeting lists
Apr 21 2022, 6:13 AM · Restricted Project

Nov 17 2021

jryans committed rG1f7827e6aa15: [MLIR][Docs] Fix link syntax in Rationale.md (authored by jryans).
[MLIR][Docs] Fix link syntax in Rationale.md
Nov 17 2021, 3:39 PM

Dec 8 2020

jryans committed rG776bb71d88e4: [XCore][docs] Fix XCore compiler writer documentation links. (authored by nigelp-xmos).
[XCore][docs] Fix XCore compiler writer documentation links.
Dec 8 2020, 4:25 AM
jryans closed D92019: [XCore][docs] Fix XCore compiler writer documentation links..
Dec 8 2020, 4:25 AM · Restricted Project
jryans accepted D92019: [XCore][docs] Fix XCore compiler writer documentation links..

Thanks for the update, this looks good to me. I'll work on committing the patch as well.

Dec 8 2020, 4:13 AM · Restricted Project

Sep 4 2019

jryans committed rL370993: Request commit access for jryans.
Request commit access for jryans
Sep 4 2019, 3:36 PM

Jul 30 2019

jryans accepted D65437: [lldb][docs] Update landing page for monorepo.

Thanks for working on this! 😁

Jul 30 2019, 6:34 AM · Restricted Project, Unknown Object (Project)

Jul 29 2019

jryans accepted D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Current version looks great to me! 😁

Jul 29 2019, 7:36 AM · Restricted Project, Unknown Object (Project)

Jul 26 2019

jryans added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Where did you find the sub-project list of versioned docs?

Jul 26 2019, 10:06 AM · Restricted Project, Unknown Object (Project)
jryans accepted D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

I added a few links to LLVM documentation here and wondered what to do with them, if this gets cherry-picked to release/9.x, e.g. https://llvm.org/docs/CMake.html Ideally they would point to their 9.x counterparts, e.g. https://releases.llvm.org/9.0.0/docs/CMake.html and with 9.0.1 it should become https://releases.llvm.org/9.0.1/docs/CMake.html

llvm/docs/AdvancedBuilds.rst links within one build directory using ":doc:CMake", but apparently this doesn't work cross-project?

I could imaging to patch it once for the release and use configure_file from CMake to import the current version, but I am no sure if it's worth the effort =)

Is there a simple way to do this in Sphinx? Ideas / opinions?

Jul 26 2019, 9:42 AM · Restricted Project, Unknown Object (Project)
jryans added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.
Jul 26 2019, 9:36 AM · Restricted Project, Unknown Object (Project)
jryans added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Since Visual Studio is the only section in Building LLDB with CMake and Other Generators now, I would like to:

  • move it merge it with another one, preferably Common CMake options > Windows
  • rename Building LLDB with CMake & Ninja into Building LLDB with CMake (analog and with a link to http://llvm.org/docs/CMake.html)

Would that be acceptable?

Jul 26 2019, 7:11 AM · Restricted Project, Unknown Object (Project)
jryans accepted D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

Great! 😁 Thanks for working on this!

Jul 26 2019, 6:44 AM · Restricted Project, Unknown Object (Project)
jryans added a comment to D65330: [lldb][docs] Update documentation for monorepo and CMake caches.

In general, this looks great overall! I added few comments on things that would be good to clarify.

Jul 26 2019, 6:07 AM · Restricted Project, Unknown Object (Project)

May 30 2019

jryans committed rGd45eaf9405c8: [Docs] Modernize references to macOS (authored by jryans).
[Docs] Modernize references to macOS
May 30 2019, 11:13 AM
jryans committed rUNW362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:13 AM
jryans committed rCXX362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:13 AM
jryans committed rLLD362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:13 AM
jryans committed rL362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:12 AM
jryans committed rLLDB362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:12 AM
jryans committed rC362113: [Docs] Modernize references to macOS.
[Docs] Modernize references to macOS
May 30 2019, 11:12 AM
jryans closed D62654: [Docs] Modernize references to macOS.
May 30 2019, 11:12 AM · Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project
jryans created D62654: [Docs] Modernize references to macOS.
May 30 2019, 5:22 AM · Restricted Project, Restricted Project, Unknown Object (Project), Restricted Project

May 23 2019

jryans committed rGb4cb7d8045e3: [NFC] Add blank line (test commit) (authored by jryans).
[NFC] Add blank line (test commit)
May 23 2019, 2:14 PM
jryans committed rL361555: [NFC] Add blank line (test commit).
[NFC] Add blank line (test commit)
May 23 2019, 2:14 PM
jryans committed rLLDB361555: [NFC] Add blank line (test commit).
[NFC] Add blank line (test commit)
May 23 2019, 2:14 PM

May 20 2019

jryans added a comment to D62138: [Docs] Increase Doxygen cache size.

I don't currently have commit access, so I would need someone to land this for me assuming it's approved. If it would be easier for me to submit separate patches for the llvm and clang changes, please let me know! 😄

May 20 2019, 6:37 AM · Restricted Project, Restricted Project
jryans added reviewers for D62138: [Docs] Increase Doxygen cache size: hintonda, jmorse.
May 20 2019, 6:07 AM · Restricted Project, Restricted Project
jryans created D62138: [Docs] Increase Doxygen cache size.
May 20 2019, 5:59 AM · Restricted Project, Restricted Project

May 17 2019

jryans added a comment to D62041: [Docs] Remove SVN checkout from LLDB build steps.

Thanks for the review @JDevlieghere! 😄 This should be ready for another look. I don't have commit access yet, so assuming it's approved, please commit when you have time.

May 17 2019, 1:58 AM · Restricted Project, Unknown Object (Project)
jryans updated the diff for D62041: [Docs] Remove SVN checkout from LLDB build steps.

Updated to remove the whole section

May 17 2019, 1:55 AM · Restricted Project, Unknown Object (Project)

May 16 2019

jryans created D62041: [Docs] Remove SVN checkout from LLDB build steps.
May 16 2019, 3:38 PM · Restricted Project, Unknown Object (Project)

May 15 2019

jryans added a comment to D61877: [CMake] Add error to clarify that lldb requires libcxx.

@sgraenitz Thanks for committing! 😄 I guess the original author info is lost for this one, but consider adding a "Patch by" line for future commits from those without access.

May 15 2019, 4:49 AM · Restricted Project, Unknown Object (Project)

May 14 2019

jryans added a comment to D61877: [CMake] Add error to clarify that lldb requires libcxx.

Thanks for the review! 😄 I don't have commit access yet, so could you please commit this for me?

May 14 2019, 9:26 AM · Restricted Project, Unknown Object (Project)
jryans added a comment to D61877: [CMake] Add error to clarify that lldb requires libcxx.

Thanks all for the review! 😄

May 14 2019, 4:00 AM · Restricted Project, Unknown Object (Project)
jryans updated the diff for D61877: [CMake] Add error to clarify that lldb requires libcxx.

Updated to support old project layout as well

May 14 2019, 3:50 AM · Restricted Project, Unknown Object (Project)

May 13 2019

jryans created D61877: [CMake] Add error to clarify that lldb requires libcxx.
May 13 2019, 4:23 PM · Restricted Project, Unknown Object (Project)